As i40e introduced recently in DPDK, the warnings should include i40e when no supported NIC port found during initialization at least in below example applications. * app/testpmd * exception_path * kni Signed-off-by: Helin Zhang <helin.zhang@intel.com> --- app/test-pmd/testpmd.c | 3 ++- examples/exception_path/main.c | 5 +++-- examples/kni/main.c | 5 +++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e8a4b45..0c0ac77 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1859,7 +1859,8 @@ main(int argc, char** argv) "check that " "CONFIG_RTE_LIBRTE_IGB_PMD=y and that " "CONFIG_RTE_LIBRTE_EM_PMD=y and that " - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your " + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and that " + "CONFIG_RTE_LIBRTE_I40E_PMD=y in your " "configuration file\n"); set_def_fwd_config(); diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c index 0204116..c4245a3 100644 --- a/examples/exception_path/main.c +++ b/examples/exception_path/main.c @@ -575,8 +575,9 @@ main(int argc, char** argv) nb_sys_ports = rte_eth_dev_count(); if (nb_sys_ports == 0) FATAL_ERROR("No supported Ethernet devices found - check that " - "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or " - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file"); + "CONFIG_RTE_LIBRTE_IGB_PMD=y, " + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or " + "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file"); /* Find highest port set in portmask */ for (high_port = (sizeof(ports_mask) * 8) - 1; (high_port != 0) && !(ports_mask & (1 << high_port)); diff --git a/examples/kni/main.c b/examples/kni/main.c index 7df1b36..f3666e2 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -898,8 +898,9 @@ main(int argc, char** argv) nb_sys_ports = rte_eth_dev_count(); if (nb_sys_ports == 0) rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - " - "check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or " - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n"); + "check that CONFIG_RTE_LIBRTE_IGB_PMD=y, " + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or " + "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file\n"); /* Check if the configured port ID is valid */ for (i = 0; i < RTE_MAX_ETHPORTS; i++) -- 1.8.1.4
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang
> Sent: Thursday, July 3, 2014 3:55 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: warnings should include i40e in some example applications
>
> As i40e introduced recently in DPDK, the warnings should include
> i40e when no supported NIC port found during initialization at
> least in below example applications.
> * app/testpmd
> * exception_path
> * kni
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
> app/test-pmd/testpmd.c | 3 ++-
> examples/exception_path/main.c | 5 +++--
> examples/kni/main.c | 5 +++--
> 3 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index e8a4b45..0c0ac77 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1859,7 +1859,8 @@ main(int argc, char** argv)
> "check that "
> "CONFIG_RTE_LIBRTE_IGB_PMD=y and that "
> "CONFIG_RTE_LIBRTE_EM_PMD=y and that "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your "
> + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and that "
> + "CONFIG_RTE_LIBRTE_I40E_PMD=y in your "
> "configuration file\n");
>
> set_def_fwd_config();
> diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c
> index 0204116..c4245a3 100644
> --- a/examples/exception_path/main.c
> +++ b/examples/exception_path/main.c
> @@ -575,8 +575,9 @@ main(int argc, char** argv)
> nb_sys_ports = rte_eth_dev_count();
> if (nb_sys_ports == 0)
> FATAL_ERROR("No supported Ethernet devices found - check that "
> - "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file");
> + "CONFIG_RTE_LIBRTE_IGB_PMD=y, "
> + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
> + "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file");
> /* Find highest port set in portmask */
> for (high_port = (sizeof(ports_mask) * 8) - 1;
> (high_port != 0) && !(ports_mask & (1 << high_port));
> diff --git a/examples/kni/main.c b/examples/kni/main.c
> index 7df1b36..f3666e2 100644
> --- a/examples/kni/main.c
> +++ b/examples/kni/main.c
> @@ -898,8 +898,9 @@ main(int argc, char** argv)
> nb_sys_ports = rte_eth_dev_count();
> if (nb_sys_ports == 0)
> rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - "
> - "check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n");
> + "check that CONFIG_RTE_LIBRTE_IGB_PMD=y, "
> + "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
> + "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file\n");
>
> /* Check if the configured port ID is valid */
> for (i = 0; i < RTE_MAX_ETHPORTS; i++)
> --
> 1.8.1.4
2014-07-03 15:54, Helin Zhang:
> As i40e introduced recently in DPDK, the warnings should include
> i40e when no supported NIC port found during initialization at
> least in below example applications.
> * app/testpmd
> * exception_path
> * kni
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
I think it's better to remove these warnings.
I am going to send a patch. Please ack if you agree.
--
Thomas
These references to drivers break the layering isolation between application and drivers. Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> --- app/test-pmd/testpmd.c | 7 +------ examples/exception_path/main.c | 4 +--- examples/kni/main.c | 4 +--- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index f76406f..c373e3a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1870,12 +1870,7 @@ main(int argc, char** argv) nb_ports = (portid_t) rte_eth_dev_count(); if (nb_ports == 0) - rte_exit(EXIT_FAILURE, "No probed ethernet devices - " - "check that " - "CONFIG_RTE_LIBRTE_IGB_PMD=y and that " - "CONFIG_RTE_LIBRTE_EM_PMD=y and that " - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your " - "configuration file\n"); + rte_exit(EXIT_FAILURE, "No probed ethernet devices\n"); set_def_fwd_config(); if (nb_lcores == 0) diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c index 3f8b1fb..692383b 100644 --- a/examples/exception_path/main.c +++ b/examples/exception_path/main.c @@ -546,9 +546,7 @@ main(int argc, char** argv) /* Get number of ports found in scan */ nb_sys_ports = rte_eth_dev_count(); if (nb_sys_ports == 0) - FATAL_ERROR("No supported Ethernet devices found - check that " - "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or " - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file"); + FATAL_ERROR("No supported Ethernet devices found"); /* Find highest port set in portmask */ for (high_port = (sizeof(ports_mask) * 8) - 1; (high_port != 0) && !(ports_mask & (1 << high_port)); diff --git a/examples/kni/main.c b/examples/kni/main.c index 1344a87..370ae1c 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -881,9 +881,7 @@ main(int argc, char** argv) /* Get number of ports found in scan */ nb_sys_ports = rte_eth_dev_count(); if (nb_sys_ports == 0) - rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - " - "check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or " - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n"); + rte_exit(EXIT_FAILURE, "No supported Ethernet devices found\n"); /* Check if the configured port ID is valid */ for (i = 0; i < RTE_MAX_ETHPORTS; i++) -- 2.1.3
Acked-by: Helin Zhang <helin.zhang@intel.com>
With minor changes suggested: 'devices' -> 'device'?
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, November 7, 2014 8:49 PM
> To: dev@dpdk.org
> Cc: Zhang, Helin
> Subject: [PATCH] app,examples: remove references to drivers config
>
> These references to drivers break the layering isolation between application and
> drivers.
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
> app/test-pmd/testpmd.c | 7 +------
> examples/exception_path/main.c | 4 +---
> examples/kni/main.c | 4 +---
> 3 files changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> f76406f..c373e3a 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1870,12 +1870,7 @@ main(int argc, char** argv)
>
> nb_ports = (portid_t) rte_eth_dev_count();
> if (nb_ports == 0)
> - rte_exit(EXIT_FAILURE, "No probed ethernet devices - "
> - "check that "
> - "CONFIG_RTE_LIBRTE_IGB_PMD=y and that "
> - "CONFIG_RTE_LIBRTE_EM_PMD=y and that "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your "
> - "configuration file\n");
> + rte_exit(EXIT_FAILURE, "No probed ethernet devices\n");
>
> set_def_fwd_config();
> if (nb_lcores == 0)
> diff --git a/examples/exception_path/main.c
> b/examples/exception_path/main.c index 3f8b1fb..692383b 100644
> --- a/examples/exception_path/main.c
> +++ b/examples/exception_path/main.c
> @@ -546,9 +546,7 @@ main(int argc, char** argv)
> /* Get number of ports found in scan */
> nb_sys_ports = rte_eth_dev_count();
> if (nb_sys_ports == 0)
> - FATAL_ERROR("No supported Ethernet devices found - check that "
> - "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file");
> + FATAL_ERROR("No supported Ethernet devices found");
> /* Find highest port set in portmask */
> for (high_port = (sizeof(ports_mask) * 8) - 1;
> (high_port != 0) && !(ports_mask & (1 << high_port)); diff --git
> a/examples/kni/main.c b/examples/kni/main.c index 1344a87..370ae1c 100644
> --- a/examples/kni/main.c
> +++ b/examples/kni/main.c
> @@ -881,9 +881,7 @@ main(int argc, char** argv)
> /* Get number of ports found in scan */
> nb_sys_ports = rte_eth_dev_count();
> if (nb_sys_ports == 0)
> - rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - "
> - "check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> - "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n");
> + rte_exit(EXIT_FAILURE, "No supported Ethernet devices found\n");
>
> /* Check if the configured port ID is valid */
> for (i = 0; i < RTE_MAX_ETHPORTS; i++)
> --
> 2.1.3
> > These references to drivers break the layering isolation between application and
> > drivers.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
> With minor changes suggested: 'devices' -> 'device'?
Applied with suggested changes.
Thanks
--
Thomas