From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7C04A7F11 for ; Wed, 29 Oct 2014 02:38:41 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 28 Oct 2014 18:45:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,807,1406617200"; d="scan'208";a="598047342" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga001.jf.intel.com with ESMTP; 28 Oct 2014 18:47:29 -0700 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 09:45:44 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 09:45:44 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0195.001; Wed, 29 Oct 2014 09:45:44 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 08/21] mbuf: extend fdir field Thread-Index: AQHP7ZPU7VTU16jQhUKB2gg4Ny/tFpxFBLyAgAFSTfA= Date: Wed, 29 Oct 2014 01:45:44 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B24F12@SHSMSX104.ccr.corp.intel.com> References: <1411711418-12881-1-git-send-email-jingjing.wu@intel.com> <1413939687-11177-1-git-send-email-jingjing.wu@intel.com> <1413939687-11177-9-git-send-email-jingjing.wu@intel.com> <1914722.TcObfZY1uh@xps13> In-Reply-To: <1914722.TcObfZY1uh@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 08/21] mbuf: extend fdir field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 01:38:41 -0000 Hi, Thomas Thanks for your comments. Jingjing > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, October 28, 2014 9:28 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 08/21] mbuf: extend fdir field >=20 > 2014-10-22 09:01, Jingjing Wu: > > extend fdir field to support flex bytes reported when fdir match >=20 > The commit log should explain why it is required (i40e?). > It will help to understand when digging into git history of mbuf file. >=20 OK. Will explain. > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -171,8 +173,14 @@ struct rte_mbuf { > > union { > > uint32_t rss; /**< RSS hash result if RSS enabled */ > > struct { > > - uint16_t hash; > > - uint16_t id; > > + union { > > + struct { > > + uint16_t hash; > > + uint16_t id; > > + }; > > + uint32_t lo; /**< flexible bytes low*/ > > + }; > > + uint32_t hi; /**< flexible bytes high*/ > > } fdir; /**< Filter identifier if FDIR enabled */ >=20 > Please explain what could be the data of "flexible bytes high". >=20 When set the report status to report flex bytes, flexible bytes high field report first 4 bytes in "little endian" notation. OK. Will add comments in detail. > -- > Thomas