Re: [dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure

["Wu, Jingjing" <jingjing.wu@intel.com>]

Hi, Thomas

Nop.

We target to have it in r1.8. And the whole patch set is almost ready, but lack of review internally.

I have two proposes here:
1. Send a patch set include all the ethdev, i40e, ixgbe, igb and testpmd changes just as my previous mail.

2. send a patch set only include the ethdev, i40e part. Without testpmd changes to support testing it in fortville. And will send remaining changes later. Maybe r2.0?

The second proposal will split the whole task to small patchset. And easy to review.

Which one do you prefer?

Look forward to your reply!
Thanks

Jingjing 


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, November 13, 2014 4:41 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/3] ethdev: define ctrl_pkt filter type and its structure
> 
> Hi Jingjing,
> 
> 2014-11-13 05:44, Wu, Jingjing:
> > The input set of control packet filter are dst_mac and ethertype in Ethernet head.
> > To be clear, I think it's better to use the name ethertype filter.
> >
> > While there is already ethertype filter existing in igb and ixgbe driver. I will rename
> > The patchset to ethertype filter and also integrate igb and ixgbe's ethertype filter
> > To the filter_ctrl API.
> >
> > What do you think?
> 
> OK, good.
> If I understand well, this feature is now planned for release 2.0?
> 
> --
> Thomas