From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A98947EB0 for ; Wed, 3 Dec 2014 08:48:01 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 02 Dec 2014 23:48:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,506,1413270000"; d="scan'208";a="641729569" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by fmsmga002.fm.intel.com with ESMTP; 02 Dec 2014 23:47:59 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 3 Dec 2014 15:47:58 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id 14.03.0195.001; Wed, 3 Dec 2014 15:47:56 +0800 From: "Wu, Jingjing" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [PATCH v2] i40e: fix of compile error Thread-Index: AQHQDpZiLsP1iVU3IUiks44lqjhRjZx9faQw Date: Wed, 3 Dec 2014 07:47:57 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B5A5AE@SHSMSX104.ccr.corp.intel.com> References: <1417419227-21465-1-git-send-email-helin.zhang@intel.com> <1417569207-30139-1-git-send-email-helin.zhang@intel.com> In-Reply-To: <1417569207-30139-1-git-send-email-helin.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix of compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2014 07:48:02 -0000 > -----Original Message----- > From: Zhang, Helin > Sent: Wednesday, December 03, 2014 9:13 AM > To: dev@dpdk.org > Cc: Cao, Waterman; Cao, Min; Wu, Jingjing; Zhang, Helin > Subject: [PATCH v2] i40e: fix of compile error >=20 > The compile error will occur as below when set > 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=3Dy'. > 'fd_id' should be used to replace 'fd', as 'fd' is not defined in that st= ructure at > all. In addition, local variable of 'flexbl' and 'flexbh' must be used on= ly if > 32 bytes RX descriptor is selected. >=20 > error logs: > lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir: > lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union > has no member named fd > lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl [- > Werror=3Dunused-variable] > lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh [- > Werror=3Dunused-variable] >=20 > Signed-off-by: Helin Zhang > --- > lib/librte_pmd_i40e/i40e_rxtx.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > v2 changes: > * Removed the changes for code style fix, and kept it for compile error f= ix > only. > * Re-word the commit logs. >=20 > diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_r= xtx.c > index 2d2ef04..63c872d 100644 > --- a/lib/librte_pmd_i40e/i40e_rxtx.c > +++ b/lib/librte_pmd_i40e/i40e_rxtx.c > @@ -424,13 +424,9 @@ static inline uint64_t i40e_rxd_build_fdir(volatile > union i40e_rx_desc *rxdp, struct rte_mbuf *mb) { > uint64_t flags =3D 0; > +#ifndef RTE_LIBRTE_I40E_16BYTE_RX_DESC > uint16_t flexbh, flexbl; >=20 > -#ifdef RTE_LIBRTE_I40E_16BYTE_RX_DESC > - mb->hash.fdir.hi =3D > - rte_le_to_cpu_32(rxdp->wb.qword0.hi_dword.fd); > - flags |=3D PKT_RX_FDIR_ID; > -#else > flexbh =3D (rte_le_to_cpu_32(rxdp->wb.qword2.ext_status) >> > I40E_RX_DESC_EXT_STATUS_FLEXBH_SHIFT) & > I40E_RX_DESC_EXT_STATUS_FLEXBH_MASK; > @@ -453,6 +449,10 @@ i40e_rxd_build_fdir(volatile union i40e_rx_desc > *rxdp, struct rte_mbuf *mb) > rte_le_to_cpu_32(rxdp- > >wb.qword3.lo_dword.flex_bytes_lo); > flags |=3D PKT_RX_FDIR_FLX; > } > +#else > + mb->hash.fdir.hi =3D > + rte_le_to_cpu_32(rxdp->wb.qword0.hi_dword.fd_id); > + flags |=3D PKT_RX_FDIR_ID; > #endif > return flags; > } > -- > 1.9.3 Acked-by: Jingjing Wu