From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2EDDE689B for ; Thu, 25 Dec 2014 04:39:08 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 24 Dec 2014 19:39:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,641,1413270000"; d="scan'208";a="652920255" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga002.fm.intel.com with ESMTP; 24 Dec 2014 19:39:06 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 25 Dec 2014 11:39:05 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0195.001; Thu, 25 Dec 2014 11:39:04 +0800 From: "Wu, Jingjing" To: "Qiu, Michael" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API Thread-Index: AQHQH/Kq8RsBoF7Dd0uSWo52KHEsR5yfplcw Date: Thu, 25 Dec 2014 03:39:04 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B6561A@SHSMSX104.ccr.corp.intel.com> References: <1419477270-14611-1-git-send-email-jingjing.wu@intel.com> <533710CFB86FA344BFBF2D6802E60286CA27E3@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CA27E3@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Dec 2014 03:39:08 -0000 Hi, Michael It's a long discuss in community. Due to in the development in i40e driver, we defined a new common API used = for kinds of filters. In R1.8, because of time limit and compatibility, we = just used the new API for i40e driver. While other driver still use old one= s. We have planned to integrate filter to this new API to make the APIs generi= c for different types of NICs. Jingjing > -----Original Message----- > From: Qiu, Michael > Sent: Thursday, December 25, 2014 11:27 AM > To: Wu, Jingjing; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixg= be > driver to new API >=20 > Hi Jingjing, >=20 > Would you mind to tell me why need new APIs? Any functional or > performance increase? > Better to state in commit log. >=20 > You know it should be careful to change APIs, especially for user interfa= ce. >=20 > Thanks, > Michael > On 12/25/2014 11:14 AM, Jingjing Wu wrote: > > The patch set uses new filter_ctrl API to replace old ethertype filter = APIs. > > It uses new functions and structure to replace old ones in igb/ixgbe > > driver, new commands to replace old ones in testpmd, and removes the > old APIs. > > > > Jingjing Wu (4): > > ixgbe: new functions replaces old ones for ethertype filters > > e1000: new functions replaces old ones for ethertype filters > > testpmd: new commands for ethertype filter > > ethdev: remove old APIs and structures of ethertype filters > > > > app/test-pmd/cmdline.c | 253 ++++++++++++-------------- > > app/test-pmd/config.c | 27 --- > > lib/librte_ether/rte_ethdev.c | 57 ------ > > lib/librte_ether/rte_ethdev.h | 88 --------- > > lib/librte_pmd_e1000/e1000_ethdev.h | 13 ++ > > lib/librte_pmd_e1000/igb_ethdev.c | 332 +++++++++++++++++++++----- > ------- > > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 354 > > +++++++++++++++++++++++------------- > > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 13 ++ > > 8 files changed, 579 insertions(+), 558 deletions(-) > >