From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 282012A9 for ; Mon, 29 Dec 2014 09:15:53 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 29 Dec 2014 00:13:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,659,1413270000"; d="scan'208";a="661831133" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga002.jf.intel.com with ESMTP; 29 Dec 2014 00:15:33 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 29 Dec 2014 16:15:32 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by shsmsx102.ccr.corp.intel.com ([169.254.2.216]) with mapi id 14.03.0195.001; Mon, 29 Dec 2014 16:15:31 +0800 From: "Wu, Jingjing" To: Sujith Sankar , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface Thread-Index: AQHQCNXiWpai+YYXyE6k0B1ZW3o2+ZymYLWA Date: Mon, 29 Dec 2014 08:15:31 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B6647D@SHSMSX104.ccr.corp.intel.com> References: <1416936405-25333-1-git-send-email-ssujith@cisco.com> <1416936405-25333-6-git-send-email-ssujith@cisco.com> In-Reply-To: <1416936405-25333-6-git-send-email-ssujith@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "prrao@cisco.com" Subject: Re: [dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2014 08:15:54 -0000 Hi, ssujith > + .tx_queue_release =3D enicpmd_dev_tx_queue_release, > + .dev_led_on =3D NULL, > + .dev_led_off =3D NULL, > + .flow_ctrl_get =3D NULL, > + .flow_ctrl_set =3D NULL, > + .priority_flow_ctrl_set =3D NULL, > + .mac_addr_add =3D enicpmd_add_mac_addr, > + .mac_addr_remove =3D enicpmd_remove_mac_addr, > + .fdir_add_signature_filter =3D NULL, > + .fdir_update_signature_filter =3D NULL, > + .fdir_remove_signature_filter =3D NULL, > + .fdir_infos_get =3D enicpmd_fdir_info_get, > + .fdir_add_perfect_filter =3D enicpmd_fdir_add_perfect_filter, > + .fdir_update_perfect_filter =3D enicpmd_fdir_add_perfect_filter, > + .fdir_remove_perfect_filter =3D enicpmd_fdir_remove_perfect_filter, > + .fdir_set_masks =3D NULL, > +}; > + I found that in perfect fdir is also supported in enic driver. During the R1.8 development, we defined a new dev_ops call filter_ctrl, whi= ch can be used to control kinds of filters, flow director is included too. = Which is mentioned in http://www.dpdk.org/ml/archives/dev/2014-September/0= 05179.html . In R1.8, filter_ctrl is only used by i40e driver. And we also planned use i= t in the existing ixgbe/e1000 driver in the next days. The old APIs such as= fdir_add_perfect_filter, fdir_remove_perfect_filter can be replaced then. So, do you have any plan to migrate the fdir in enic to the filter_ctrl API= ? Jingjing Thanks! > +struct enic *enicpmd_list_head =3D NULL; > +/* Initialize the driver > + * It returns 0 on success. > + */ > +static int eth_enicpmd_dev_init( > + __attribute__((unused))struct eth_driver *eth_drv, > + struct rte_eth_dev *eth_dev) > +{ > + struct rte_pci_device *pdev; > + struct rte_pci_addr *addr; > + struct enic *enic =3D pmd_priv(eth_dev); > + > + ENICPMD_FUNC_TRACE(); > + > + enic->rte_dev =3D eth_dev; > + eth_dev->dev_ops =3D &enicpmd_eth_dev_ops; > + eth_dev->rx_pkt_burst =3D &enicpmd_recv_pkts; > + eth_dev->tx_pkt_burst =3D &enicpmd_xmit_pkts; > + > + pdev =3D eth_dev->pci_dev; > + enic->pdev =3D pdev; > + addr =3D &pdev->addr; > + > + snprintf(enic->bdf_name, ENICPMD_BDF_LENGTH, > "%04x:%02x:%02x.%x", > + addr->domain, addr->bus, addr->devid, addr->function); > + > + return enic_probe(enic); > +} > + > +static struct eth_driver rte_enic_pmd =3D { > + { > + .name =3D "rte_enic_pmd", > + .id_table =3D pci_id_enic_map, > + .drv_flags =3D RTE_PCI_DRV_NEED_MAPPING, > + }, > + .eth_dev_init =3D eth_enicpmd_dev_init, > + .dev_private_size =3D sizeof(struct enic), }; > + > +/* Driver initialization routine. > + * Invoked once at EAL init time. > + * Register as the [Poll Mode] Driver of Cisco ENIC device. > + */ > +int rte_enic_pmd_init(const char *name __rte_unused, > + const char *params __rte_unused) > +{ > + ENICPMD_FUNC_TRACE(); > + > + rte_eth_driver_register(&rte_enic_pmd); > + return 0; > +} > + > +static struct rte_driver rte_enic_driver =3D { > + .type =3D PMD_PDEV, > + .init =3D rte_enic_pmd_init, > +}; > + > +PMD_REGISTER_DRIVER(rte_enic_driver); > + > -- > 1.9.1