From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 483AE2E81 for ; Fri, 30 Jan 2015 09:53:18 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 30 Jan 2015 00:53:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,491,1418112000"; d="scan'208";a="520109312" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by orsmga003.jf.intel.com with ESMTP; 30 Jan 2015 00:45:57 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 30 Jan 2015 16:53:13 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.231]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.253]) with mapi id 14.03.0195.001; Fri, 30 Jan 2015 16:53:12 +0800 From: "Wu, Jingjing" To: "'Sujith Sankar (ssujith)'" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface Thread-Index: AQHQCNXiWpai+YYXyE6k0B1ZW3o2+ZymYLWAgADeZoCAL8li8A== Date: Fri, 30 Jan 2015 08:53:11 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B87BD6@SHSMSX104.ccr.corp.intel.com> References: <1416936405-25333-1-git-send-email-ssujith@cisco.com> <1416936405-25333-6-git-send-email-ssujith@cisco.com> <9BB6961774997848B5B42BEC655768F8B6647D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "Prasad Rao \(prrao\)" Subject: Re: [dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 08:53:19 -0000 Hi, ssujith > -----Original Message----- > From: Sujith Sankar (ssujith) [mailto:ssujith@cisco.com] > Sent: Tuesday, December 30, 2014 12:46 PM > To: Wu, Jingjing; dev@dpdk.org > Cc: Prasad Rao (prrao) > Subject: Re: [dpdk-dev] [PATCH v6 5/6] enicpmd: DPDK-ENIC PMD interface >=20 >=20 >=20 > On 29/12/14 1:45 pm, "Wu, Jingjing" wrote: >=20 > >Hi, ssujith > > > >> + .tx_queue_release =3D enicpmd_dev_tx_queue_release, > >> + .dev_led_on =3D NULL, > >> + .dev_led_off =3D NULL, > >> + .flow_ctrl_get =3D NULL, > >> + .flow_ctrl_set =3D NULL, > >> + .priority_flow_ctrl_set =3D NULL, > >> + .mac_addr_add =3D enicpmd_add_mac_addr, > >> + .mac_addr_remove =3D enicpmd_remove_mac_addr, > >> + .fdir_add_signature_filter =3D NULL, > >> + .fdir_update_signature_filter =3D NULL, > >> + .fdir_remove_signature_filter =3D NULL, > >> + .fdir_infos_get =3D enicpmd_fdir_info_get, > >> + .fdir_add_perfect_filter =3D enicpmd_fdir_add_perfect_filter, > >> + .fdir_update_perfect_filter =3D enicpmd_fdir_add_perfect_filter, > >> + .fdir_remove_perfect_filter =3D enicpmd_fdir_remove_perfect_filter= , > >> + .fdir_set_masks =3D NULL, > >> +}; > >> + > > > >I found that in perfect fdir is also supported in enic driver. > > > >During the R1.8 development, we defined a new dev_ops call filter_ctrl, > >which can be used to control kinds of filters, flow director is > >included too. Which is mentioned in > >http://www.dpdk.org/ml/archives/dev/2014-September/005179.html . > >In R1.8, filter_ctrl is only used by i40e driver. And we also planned > >use it in the existing ixgbe/e1000 driver in the next days. The old > >APIs such as fdir_add_perfect_filter, fdir_remove_perfect_filter can be > >replaced then. >=20 >=20 > Hi Jingjing, > Thanks for the info and the link. I shall take a look at it. > It looks like bringing in one interface for all filter related operations= . > I believe ENIC should also move to it. >=20 > Thanks, > -Sujith >=20 Just let you know that, I already sent the patch to migrate the flow direct= or in ixgbe driver to new filter_ctrl API. http://www.dpdk.org/ml/archives/dev/2015-January/011830.html=20 To avoid compile error and influence to enic driver. I didn't remove the ol= d APIs and structures in rte_ethdev. I think they can be removed when the m= igration in enic driver is done. Do you have any plan for this? Thank u! Jingjing > > > >So, do you have any plan to migrate the fdir in enic to the filter_ctrl > >API? > > > >Jingjing > > > >Thanks! > > > >> +struct enic *enicpmd_list_head =3D NULL; > >> +/* Initialize the driver > >> + * It returns 0 on success. > >> + */ > >> +static int eth_enicpmd_dev_init( > >> + __attribute__((unused))struct eth_driver *eth_drv, > >> + struct rte_eth_dev *eth_dev) > >> +{ > >> + struct rte_pci_device *pdev; > >> + struct rte_pci_addr *addr; > >> + struct enic *enic =3D pmd_priv(eth_dev); > >> + > >> + ENICPMD_FUNC_TRACE(); > >> + > >> + enic->rte_dev =3D eth_dev; > >> + eth_dev->dev_ops =3D &enicpmd_eth_dev_ops; > >> + eth_dev->rx_pkt_burst =3D &enicpmd_recv_pkts; > >> + eth_dev->tx_pkt_burst =3D &enicpmd_xmit_pkts; > >> + > >> + pdev =3D eth_dev->pci_dev; > >> + enic->pdev =3D pdev; > >> + addr =3D &pdev->addr; > >> + > >> + snprintf(enic->bdf_name, ENICPMD_BDF_LENGTH, > >> "%04x:%02x:%02x.%x", > >> + addr->domain, addr->bus, addr->devid, addr->function); > >> + > >> + return enic_probe(enic); > >> +} > >> + > >> +static struct eth_driver rte_enic_pmd =3D { > >> + { > >> + .name =3D "rte_enic_pmd", > >> + .id_table =3D pci_id_enic_map, > >> + .drv_flags =3D RTE_PCI_DRV_NEED_MAPPING, > >> + }, > >> + .eth_dev_init =3D eth_enicpmd_dev_init, > >> + .dev_private_size =3D sizeof(struct enic), }; > >> + > >> +/* Driver initialization routine. > >> + * Invoked once at EAL init time. > >> + * Register as the [Poll Mode] Driver of Cisco ENIC device. > >> + */ > >> +int rte_enic_pmd_init(const char *name __rte_unused, > >> + const char *params __rte_unused) > >> +{ > >> + ENICPMD_FUNC_TRACE(); > >> + > >> + rte_eth_driver_register(&rte_enic_pmd); > >> + return 0; > >> +} > >> + > >> +static struct rte_driver rte_enic_driver =3D { > >> + .type =3D PMD_PDEV, > >> + .init =3D rte_enic_pmd_init, > >> +}; > >> + > >> +PMD_REGISTER_DRIVER(rte_enic_driver); > >> + > >> -- > >> 1.9.1 > >