Re: [dpdk-dev] [PATCH 00/15] migrate flow director in ingle driver to new API

Re: [dpdk-dev] [PATCH 00/15] migrate flow director in ingle driver to new API

[Wu, Jingjing]

> -----Original Message-----
> From: Zhang, Helin
> Sent: Wednesday, February 11, 2015 4:10 PM
> To: Wu, Jingjing; dev@dpdk.org
> Cc: Liu, Jijiang; Mcnamara, John; Cao, Min; Xu, HuilongX
> Subject: RE: [PATCH 00/15] migrate flow director in ixgbe driver to new API
> 
> 
> 
> > -----Original Message-----
> > From: Wu, Jingjing
> > Sent: Thursday, January 29, 2015 1:29 PM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing; Zhang, Helin; Liu, Jijiang; Mcnamara, John; Cao,
> > Min; Xu, HuilongX
> > Subject: [PATCH 00/15] migrate flow director in ixgbe driver to new
> > API
> >
> > The patch set uses new filter_ctrl API to replace old flow director filter APIs.
> > It uses new functions and structure to replace old ones in ixgbe
> > driver, updates commands to replace old ones in testpmd, and removes
> > the old APIs
> >
> > Jingjing Wu (15):
> >   ixgbe: migrate flow director filter operations (add/delete/update) to
> >     new API
> >   ethdev: extend flow type and flexible payload type definition for flow
> >     director
> >   ixgbe: implement the flexpayload configuration of flow director filter
> >   app/test: remove the flexbytes_offset setting in test_link_bonding
> >   testpmd: remove the flexbytes_offset setting
> >   ethdev: remove flexbytes_offset from rte_fdir_conf
> >   ethdev: structures definition for flow director masks
> >   ixgbe: implement the mask configuration of flow director filter
> >   ixgbe: implement the get info and statistic operations of flow
> >     director
> >   ixgbe: implement the flush operation of flow director
> >   testpmd: add and update commands for flow director
> >   testpmd: update function to show flow director information
> >   testpmd: set the default value of flow director's mask
> >   testpmd: remove old commands for flow director
> >   doc: commands changed in testpmd_funcs.rst for flow director
> >
> >  app/test-pmd/cmdline.c                      |  755 ++++-------------
> >  app/test-pmd/config.c                       |  197 +----
> >  app/test-pmd/parameters.c                   |   16 -
> >  app/test-pmd/testpmd.c                      |   14 +-
> >  app/test-pmd/testpmd.h                      |   16 -
> >  app/test/test_link_bonding.c                |    1 -
> >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  287 +++----
> >  lib/librte_ether/rte_eth_ctrl.h             |   15 +
> >  lib/librte_ether/rte_ethdev.h               |    3 +-
> >  lib/librte_pmd_ixgbe/ixgbe_ethdev.c         |   11 +-
> >  lib/librte_pmd_ixgbe/ixgbe_ethdev.h         |   43 +-
> >  lib/librte_pmd_ixgbe/ixgbe_fdir.c           | 1169
> > ++++++++++++++++-----------
> >  12 files changed, 1054 insertions(+), 1473 deletions(-)
> >
> > --
> > 1.9.3
> 
> Acked-by: Helin Zhang <helin.zhang@intel.com>
> 
> Note that there is dependency on "[PATCH v2 0/7] unified flow types and
> RSS offload types".
> That unified flow types and rss offload types should be merged first, and
> then rework is needed.

Yes, this patch is based on current code, it is using rte_eth_flow_type definition, while the patch (unified flow types and rss offload types http://www.dpdk.org/ml/archives/dev/2015-February/012364.html) changes the definition. So no matter which one is merged first, then the other patch need rework.