From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6EE315946 for ; Wed, 11 Feb 2015 09:19:39 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 11 Feb 2015 00:19:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,557,1418112000"; d="scan'208";a="664724408" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by fmsmga001.fm.intel.com with ESMTP; 11 Feb 2015 00:19:36 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 11 Feb 2015 16:19:35 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.192]) with mapi id 14.03.0195.001; Wed, 11 Feb 2015 16:19:35 +0800 From: "Wu, Jingjing" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [PATCH 00/15] migrate flow director in ingle driver to new API Thread-Index: AdBF03XKExWBy3XrTSKDdHrqvTuBSw== Date: Wed, 11 Feb 2015 08:19:34 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8BA5F26@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 00/15] migrate flow director in ingle driver to new API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Feb 2015 08:19:39 -0000 > -----Original Message----- > From: Zhang, Helin > Sent: Wednesday, February 11, 2015 4:10 PM > To: Wu, Jingjing; dev@dpdk.org > Cc: Liu, Jijiang; Mcnamara, John; Cao, Min; Xu, HuilongX > Subject: RE: [PATCH 00/15] migrate flow director in ixgbe driver to new A= PI >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Thursday, January 29, 2015 1:29 PM > > To: dev@dpdk.org > > Cc: Wu, Jingjing; Zhang, Helin; Liu, Jijiang; Mcnamara, John; Cao, > > Min; Xu, HuilongX > > Subject: [PATCH 00/15] migrate flow director in ixgbe driver to new > > API > > > > The patch set uses new filter_ctrl API to replace old flow director fil= ter APIs. > > It uses new functions and structure to replace old ones in ixgbe > > driver, updates commands to replace old ones in testpmd, and removes > > the old APIs > > > > Jingjing Wu (15): > > ixgbe: migrate flow director filter operations (add/delete/update) to > > new API > > ethdev: extend flow type and flexible payload type definition for flo= w > > director > > ixgbe: implement the flexpayload configuration of flow director filte= r > > app/test: remove the flexbytes_offset setting in test_link_bonding > > testpmd: remove the flexbytes_offset setting > > ethdev: remove flexbytes_offset from rte_fdir_conf > > ethdev: structures definition for flow director masks > > ixgbe: implement the mask configuration of flow director filter > > ixgbe: implement the get info and statistic operations of flow > > director > > ixgbe: implement the flush operation of flow director > > testpmd: add and update commands for flow director > > testpmd: update function to show flow director information > > testpmd: set the default value of flow director's mask > > testpmd: remove old commands for flow director > > doc: commands changed in testpmd_funcs.rst for flow director > > > > app/test-pmd/cmdline.c | 755 ++++------------- > > app/test-pmd/config.c | 197 +---- > > app/test-pmd/parameters.c | 16 - > > app/test-pmd/testpmd.c | 14 +- > > app/test-pmd/testpmd.h | 16 - > > app/test/test_link_bonding.c | 1 - > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 287 +++---- > > lib/librte_ether/rte_eth_ctrl.h | 15 + > > lib/librte_ether/rte_ethdev.h | 3 +- > > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 11 +- > > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 43 +- > > lib/librte_pmd_ixgbe/ixgbe_fdir.c | 1169 > > ++++++++++++++++----------- > > 12 files changed, 1054 insertions(+), 1473 deletions(-) > > > > -- > > 1.9.3 >=20 > Acked-by: Helin Zhang >=20 > Note that there is dependency on "[PATCH v2 0/7] unified flow types and > RSS offload types". > That unified flow types and rss offload types should be merged first, and > then rework is needed. Yes, this patch is based on current code, it is using rte_eth_flow_type def= inition, while the patch (unified flow types and rss offload types http://w= ww.dpdk.org/ml/archives/dev/2015-February/012364.html) changes the definiti= on. So no matter which one is merged first, then the other patch need rewor= k.=20