Re: [dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload types

["Wu, Jingjing" <jingjing.wu@intel.com>]

> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, February 24, 2015 9:45 PM
> To: Thomas Monjalon
> Cc: dev@dpdk.org; Wu, Jingjing; Chen, Jing D
> Subject: RE: [dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload types
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Monday, February 23, 2015 6:59 AM
> > To: Zhang, Helin
> > Cc: dev@dpdk.org; Wu, Jingjing; Chen, Jing D
> > Subject: Re: [dpdk-dev] [PATCH v2 0/7] unified flow types and RSS offload types
> >
> > > > It unifies the flow types and RSS offload types for all PMDs.
> > > > Previously flow types are defined specifically for i40e, and there
> > > > has different RSS offloads tyeps for 1/10G and 40G seperately. This
> > > > is not so convenient for application development, and not good for adding
> > new PMDs.
> > > > In addition, it enables new RSS offloads of 'tcp' and 'all' in testpmd.
> > > >
> > > > v2 changes:
> > > > * Integrated with configuring hash functions.
> > > > * Corrected the wrong help string of flow director parameters.
> > > > * Renamed the flow types from ETH_FLOW_TYPE_ to RTE_ETH_FLOW_.
> > > > * Removed useless annotations for flow type elements in rte_eth_ctrl.h.
> > > >
> > > > Helin Zhang (7):
> > > >   app/test-pmd: code style fix
> > > >   ethdev: code style fix
> > > >   i40e: code style fix
> > > >   ethdev: fix of calculating the size of flow type mask array
> > > >   ethdev: unification of flow types
> > > >   ethdev: unification of RSS offload types
> > > >   app/testpmd: support new rss offloads
> > >
> > > Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> >
> > Applied, thanks
> > There were some difficult merges with new flow director API and fm10K.
> > Please check everything is OK.
> 
> Thank you very much! We expected that merges would be difficult, and Jingjing planned to
> work out a new version.
> But, you had done that for us! Thanks for your great helps to get it being merged!
> We will check the master branch as a double check!
> 
> Regards,
> Helin

[Wu, Jingjing] add my great appreciation too. Thanks a lot.