From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5DBD35FEB for ; Thu, 26 Mar 2015 17:08:07 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 26 Mar 2015 09:08:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,473,1422950400"; d="scan'208";a="704625619" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga002.jf.intel.com with ESMTP; 26 Mar 2015 09:08:06 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 27 Mar 2015 00:08:03 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.149]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0224.002; Fri, 27 Mar 2015 00:08:02 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] e1000: modify mac type checking before flex filter is programmed Thread-Index: AQHQZ4DZzTDvvDcrmECAQZb8LGRxs50t3eoAgAEQMOA= Date: Thu, 26 Mar 2015 16:08:01 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8BDEC80@SHSMSX104.ccr.corp.intel.com> References: <1427345601-21059-1-git-send-email-jingjing.wu@intel.com> <13725317.BERf2HTN48@xps13> In-Reply-To: <13725317.BERf2HTN48@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] e1000: modify mac type checking before flex filter is programmed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 16:08:07 -0000 Hi, It's a fix. Because we don't support flex filter in NIC 82576 in current e1= 000 pmd, So add a check here. Only i350 and 82580 support it. So The MAC_TY= PE_FILTER_SUP_EXT is used to check whether the MAC type is i350 or 82580. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, March 26, 2015 12:50 AM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] e1000: modify mac type checking before fl= ex filter is > programmed >=20 > 2015-03-26 12:53, Jingjing Wu: > > This patch changes MAC_TYPE_FILTER_SUP to MAC_TYPE_FILTER_SUP_EXT in > > flex filter handling function. It will remove NIC 82576 from flex filte= r > > support. >=20 > Please, could you explain the goal of this change? > Is it a fix? an enhancement? Which behaviour is changed?