From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option
Date: Thu, 30 Jul 2015 06:08:19 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8C92AFE@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1438144692-10114-1-git-send-email-yong.liu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yong Liu
> Sent: Wednesday, July 29, 2015 12:38 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work
> with -m option
>
> From: Marvin Liu <yong.liu@intel.com>
>
> '--no-huge' option now can workable with -m option.
> Unit test for eal flag should change pass criterion.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index
> 0352f87..e6f7035 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -748,8 +748,8 @@ test_no_hpet_flag(void) }
>
> /*
> - * Test that the app runs with --no-huge and doesn't run when either
> - * -m or --socket-mem are specified with --no-huge.
> + * Test that the app runs with --no-huge and doesn't run when
> + --socket-mem are
> + * specified with --no-huge.
> */
> static int
> test_no_huge_flag(void)
> @@ -778,8 +778,8 @@ test_no_huge_flag(void)
> printf("Error - process did not run ok with --no-huge flag\n");
> return -1;
> }
> - if (launch_proc(argv2) == 0) {
> - printf("Error - process run ok with --no-huge and -m flags\n");
> + if (launch_proc(argv2) != 0) {
> + printf("Error - process did not run ok with --no-huge and -m
> +flags\n");
> return -1;
> }
> #ifdef RTE_EXEC_ENV_BSDAPP
> --
> 1.9.3
next prev parent reply other threads:[~2015-07-30 6:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 4:38 Yong Liu
2015-07-30 6:08 ` Wu, Jingjing [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-29 3:54 Yong Liu
2015-08-03 21:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F8C92AFE@SHSMSX104.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).