From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 76FFF5A76 for ; Sun, 1 Nov 2015 15:33:24 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 01 Nov 2015 06:33:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,229,1444719600"; d="scan'208";a="840025382" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 01 Nov 2015 06:33:23 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 1 Nov 2015 06:33:22 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 1 Nov 2015 06:33:22 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.194]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0248.002; Sun, 1 Nov 2015 22:33:21 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow director in VFs Thread-Index: AQHRE/ifbLV/kqxF+0aHZ3nyhfij3p6GtOCAgACGslA= Date: Sun, 1 Nov 2015 14:33:20 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8D0F1EC@SHSMSX104.ccr.corp.intel.com> References: <1446021688-17544-1-git-send-email-jingjing.wu@intel.com> <1446308653-2378-1-git-send-email-jingjing.wu@intel.com> <1446308653-2378-2-git-send-email-jingjing.wu@intel.com> <7872129.vXpfkMljjd@xps13> In-Reply-To: <7872129.vXpfkMljjd@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support flow director in VFs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 14:33:24 -0000 Hi, Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Sunday, November 1, 2015 10:28 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: extend struct to support f= low director in VFs >=20 > 2015-11-01 00:24, Jingjing Wu: > > This patch extends struct rte_eth_fdir_flow_ext to support flow > > director in VFs. > [...] > > --- a/lib/librte_ether/rte_eth_ctrl.h > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > @@ -426,6 +426,8 @@ struct rte_eth_fdir_flow_ext { > > uint16_t vlan_tci; > > uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN]; > > /**< It is filled by the flexible payload to match. */ > > + uint8_t is_vf; /**< 1 for VF, 0 for port dev */ > > + uint16_t dst_id; /**< VF ID, available when is_vf is 1*/ > > }; >=20 > Why adding these parameters in an input struct? > Shouldn't it be in rte_eth_fdir_action along with rx_queue? Thanks for your comments. The reason of adding these in input is because th= is is input but not action. The patch is to support Flow director works in VF, then direct packets to t= he rx_queue (belong this vf)=20 which defined in action, but not direct packets to VF. Thanks Jingjing