From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id F37498E7F
 for <dev@dpdk.org>; Fri, 22 Jan 2016 02:34:51 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 21 Jan 2016 17:34:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,328,1449561600"; d="scan'208";a="732052220"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by orsmga003.jf.intel.com with ESMTP; 21 Jan 2016 17:34:50 -0800
Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 21 Jan 2016 17:34:50 -0800
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 21 Jan 2016 17:34:50 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.172]) with mapi id 14.03.0248.002;
 Fri, 22 Jan 2016 09:34:48 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 1/3] i40e: enable extended tag
Thread-Index: AQHRO5jGN7lK/TADSUSKMj9auy7bKJ8G8Wmw
Date: Fri, 22 Jan 2016 01:34:47 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F8D8B660@SHSMSX104.ccr.corp.intel.com>
References: <1450665486-8335-1-git-send-email-helin.zhang@intel.com>
 <1450665486-8335-2-git-send-email-helin.zhang@intel.com>
In-Reply-To: <1450665486-8335-2-git-send-email-helin.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/3] i40e: enable extended tag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 01:34:52 -0000

Hi

>   */
>  static void
> -i40e_hw_init(struct i40e_hw *hw)
> +i40e_hw_init(struct rte_eth_dev *dev)
>  {
> +	struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> +
> +	i40e_enable_extended_tag(dev);
If the function i40e_enable_extended_tag is only used here without
Checking the return value, why not define it as void?

Thanks
Jingjing
> +
>  	/* clear the PF Queue Filter control register */
>  	I40E_WRITE_REG(hw, I40E_PFQF_CTL_0, 0);
>=20
> --
> 1.9.3