From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 54A0E5A34 for ; Tue, 26 Jan 2016 02:13:05 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 25 Jan 2016 17:12:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,347,1449561600"; d="scan'208";a="641375370" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jan 2016 17:12:52 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 25 Jan 2016 17:12:51 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 25 Jan 2016 17:12:51 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.117]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Tue, 26 Jan 2016 09:12:50 +0800 From: "Wu, Jingjing" To: "Chilikin, Andrey" , "dev@dpdk.org" Thread-Topic: [PATCH 2/4] i40e: split function for input set change of hash and fdir Thread-Index: AQHRPu6IjWEu6oChLECBjZCuk4IIhp8Ed5eAgADbo9CAALcigIAGFNig Date: Tue, 26 Jan 2016 01:12:49 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8D8CC76@SHSMSX104.ccr.corp.intel.com> References: <1451032200-24973-1-git-send-email-jingjing.wu@intel.com> <1451032200-24973-3-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8D8AB7A@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/4] i40e: split function for input set change of hash and fdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2016 01:13:05 -0000 > > > > Thanks for your comments. You are correct, I removed the > > I40E_INSET_FLEX_PAYLOAD from valid fdir input set values, and this is > > one reason why I splited function for input set change of hash and and > > it is because all flex payload configuration can be set in struct > > rte_fdir_conf during device configure phase. And it is a more flexible > > configuration including flexpayload's selection, input set selection by= word > and mask setting in bits. >=20 > Should it be then two patches? First patch to split fdir and hash input s= et > configuration and then second one to remove existing functionality? At th= e > moment it is not obvious that this patch not just splits fdir input set > configuration but removes some features in a way that fdir it is not > compatible with DPDK 2.2 anymore. >=20 OK. I will try to split it to two patches. > > > > If I enable it in the input set change API, it will be duplicate. And > > the input set change on flexible payload only on word, just some > > ability compared with rte_fdir_conf. > > If flexible selection isn't done in struct rte_fdir_conf, the input > > set selection in input set change API doesn't make sense. If flexible > > selection is done in struct rte_fdir_conf, why not selection input set > > in struct rte_fdir_conf at the same time? >=20 > I do not have a problem with selecting it at the same time - it always wa= s this > way with the legacy systems. But now new NIC supports new way of > configuring input set with flexible payload as a part of this input set. = So why > not to have new way of configuration available as well and change input s= et > using one API call instead of splitting single configuration in to two pa= rts? >=20 Yes, if we support two way, at least we need to make sure the consistency. In this patch set, I didn't add new way to configure flexible selection and= mask Setting. So to make sure consistency, just remove the flexible payload in t= his Patch. Thanks Jingjing > > And about you concern, "when application has to run on an old NIC and > > on a new one", The rte_fdir_conf is for each eth_dev, so it will be fin= e. > >