From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6ABAD568B for ; Fri, 29 Apr 2016 03:35:02 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 28 Apr 2016 18:34:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,549,1455004800"; d="scan'208";a="93987989" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 28 Apr 2016 18:34:49 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 28 Apr 2016 18:34:49 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 28 Apr 2016 18:34:48 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.229]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.184]) with mapi id 14.03.0248.002; Fri, 29 Apr 2016 09:34:47 +0800 From: "Wu, Jingjing" To: David Marchand , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "stephen@networkplumber.org" , "Richardson, Bruce" , "nhorman@tuxdriver.com" , "pmatilai@redhat.com" , "christian.ehrhardt@canonical.com" , "Zhang, Helin" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver Thread-Index: AQHRmwJvzYarb+rhVEO9Wq4BDCX1ap+gNrQQ Date: Fri, 29 Apr 2016 01:34:46 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8E2883D@SHSMSX103.ccr.corp.intel.com> References: <1453120248-28274-1-git-send-email-david.marchand@6wind.com> <1461156236-25349-1-git-send-email-david.marchand@6wind.com> <1461156236-25349-3-git-send-email-david.marchand@6wind.com> In-Reply-To: <1461156236-25349-3-git-send-email-david.marchand@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 01:35:03 -0000 Hi, David For the changes on igb, ixgbe, I saw you create a new header file called **= __pci_dev_ids.h to replace the rte_pci_dev_ids.h for each driver. But for the changes on i40e, you didn't do that way. If you look into the base code, you will find for each Intel NIC, the devic= e ids are defined there, such as ixgbe_type.h; i40e_devid.h; E1000_hw.h. I'd prefer the way you did in i40e driver. It's clearer and with minor chan= ge. Thanks Jingjing > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > Sent: Wednesday, April 20, 2016 8:44 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; stephen@networkplumber.org; > Richardson, Bruce; nhorman@tuxdriver.com; pmatilai@redhat.com; > christian.ehrhardt@canonical.com; Zhang, Helin; Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH v3 02/13] ixgbe: move pci device ids to driver >=20 > test application and kni still want to know ixgbe pci devices. > So let's create a header in the driver that will be used by them. >=20 > Same comment as for e1000 driver, we can't reuse base/ headers at the > moment because of macros redefinitions nightmare. >=20 > Signed-off-by: David Marchand > --- > app/test-pmd/Makefile | 2 + > app/test-pmd/cmdline.c | 2 +- > app/test/Makefile | 1 + > app/test/test_pci.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 +- > drivers/net/ixgbe/ixgbe_pci_dev_ids.h | 213 > ++++++++++++++++++++++++ > lib/librte_eal/common/include/rte_pci_dev_ids.h | 154 ----------------- > lib/librte_eal/linuxapp/kni/Makefile | 1 + > lib/librte_eal/linuxapp/kni/kni_misc.c | 4 +- > 9 files changed, 223 insertions(+), 160 deletions(-) create mode 100644 > drivers/net/ixgbe/ixgbe_pci_dev_ids.h >=20 > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index > 72426f3..a8899b8 100644