From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maciejx.t.gajdzica@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 3DD57B704
 for <dev@dpdk.org>; Fri, 20 Feb 2015 15:55:09 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 20 Feb 2015 06:55:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,615,1418112000"; d="scan'208";a="680896266"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga002.fm.intel.com with ESMTP; 20 Feb 2015 06:55:06 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.69]) by
 IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0195.001;
 Fri, 20 Feb 2015 14:54:29 +0000
From: "Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr struct declaration
Thread-Index: AQHQTRnvDDNTvr6JnEuO7W2Qav/R6pz5nxew
Date: Fri, 20 Feb 2015 14:54:28 +0000
Message-ID: <9CC680510C0AC140A846FED2EF7F962812E5F82E@IRSMSX102.ger.corp.intel.com>
References: <1423840570-6452-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1424366779-14256-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1424366779-14256-2-git-send-email-michalx.k.jastrzebski@intel.com>
 <1694402.UUemy3W7BY@xps13>
In-Reply-To: <1694402.UUemy3W7BY@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/6] net: changed arp_hdr
	struct	declaration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2015 14:55:09 -0000

> 2015-02-19 18:26, Michal Jastrzebski:
> > From: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
> >
> > Changed MAC address type from uint8_t[6] to struct ether_addr and IP
> > address type from uint8_t[4] to uint32_t. Also removed union from
> > arp_hdr struct. Updated test-pmd to match new arp_hdr version.
> >
> > Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
> =

> Why?
> "Changed A to B" is not a sufficient explanation.

Hi Thomas

I changed commit message to this:

Changed MAC address type from uint8_t[6] to struct ether_addr and IP =

address type from uint8_t[4] to uint32_t to make it consistent with other
DPDK code using MAC and IP addresses. It allows us to use is_same_ether_addr
and ether_addr_copy functions on MAC addresses in ARP header.  Also
removed union from arp_hdr struct to make calls to arp_data items
shorter. Updated test-pmd to match new arp_hdr version.

Is that sufficient?

Best regards,
Maciek
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the s=
ole use of the intended recipient(s). Any review or distribution by others =
is strictly prohibited. If you are not the intended recipient, please conta=
ct the sender and delete all copies.