Re: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each section in rte_cfgfile_close

["Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, June 18, 2015 2:30 PM
> To: Wodkowski, PawelX
> Cc: dev@dpdk.org; Gajdzica, MaciejX T
> Subject: Re: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each section
> in rte_cfgfile_close
> 
> 2015-06-17 16:48, Maciej Gajdzica:
> > From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> >
> > Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> What is fixed exactly? What was the problem?

I will merge this patch with 6th patch in the series. Freeing memory is changed because structure
that is freed changed and this change belongs to next patch in the series.

> 
> > @@ -60,6 +60,15 @@ struct rte_cfgfile {
> >   * for new entries do we add in */
> >  #define CFG_ALLOC_ENTRY_BATCH 16
> >
> > +/* Helpers */
> > +
> > +#define _skip_spaceses(str) ({  \
> > +	__typeof__(str) p = (str);  \
> > +	while (isspace(*p))         \
> > +		p++;                    \
> > +	p;                          \
> > +})
> 
> This macro is not used in this patch nor related.
> Is "spaceses" a typo?

Yes it's a typo, thanks.

> 
> > @@ -523,7 +530,7 @@ const char *
> >  rte_cfgfile_get_entry(struct rte_cfgfile *cfg, const char *sectionname,
> >  		const char *entryname)
> >  {
> > -	int i;
> > +	size_t i;
> 
> Why this change? seems not related to free.
> 
num_entries and num_sections variables changed type from int to size_t and now comparison with
i produces warning when compiling.