From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maciejx.t.gajdzica@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id EF261C616
 for <dev@dpdk.org>; Thu, 18 Jun 2015 15:08:39 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 18 Jun 2015 06:08:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,638,1427785200"; d="scan'208";a="745823521"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga002.fm.intel.com with ESMTP; 18 Jun 2015 06:08:38 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.117]) by
 irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0224.002;
 Thu, 18 Jun 2015 14:08:37 +0100
From: "Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Wodkowski, PawelX"
 <pawelx.wodkowski@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each
 section in rte_cfgfile_close
Thread-Index: AQHQqcKnz+ZXoSx+r0aY4AU52YLZFp2yOipA
Date: Thu, 18 Jun 2015 13:08:37 +0000
Message-ID: <9CC680510C0AC140A846FED2EF7F96281383DF1C@IRSMSX102.ger.corp.intel.com>
References: <1434552528-3576-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <1434552528-3576-6-git-send-email-maciejx.t.gajdzica@intel.com>
 <4427464.uLsMqpVbGa@xps13>
In-Reply-To: <4427464.uLsMqpVbGa@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each
 section in rte_cfgfile_close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 13:08:40 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, June 18, 2015 2:30 PM
> To: Wodkowski, PawelX
> Cc: dev@dpdk.org; Gajdzica, MaciejX T
> Subject: Re: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for ea=
ch section
> in rte_cfgfile_close
>=20
> 2015-06-17 16:48, Maciej Gajdzica:
> > From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> >
> > Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
>=20
> What is fixed exactly? What was the problem?

I will merge this patch with 6th patch in the series. Freeing memory is cha=
nged because structure
that is freed changed and this change belongs to next patch in the series.

>=20
> > @@ -60,6 +60,15 @@ struct rte_cfgfile {
> >   * for new entries do we add in */
> >  #define CFG_ALLOC_ENTRY_BATCH 16
> >
> > +/* Helpers */
> > +
> > +#define _skip_spaceses(str) ({  \
> > +	__typeof__(str) p =3D (str);  \
> > +	while (isspace(*p))         \
> > +		p++;                    \
> > +	p;                          \
> > +})
>=20
> This macro is not used in this patch nor related.
> Is "spaceses" a typo?

Yes it's a typo, thanks.

>=20
> > @@ -523,7 +530,7 @@ const char *
> >  rte_cfgfile_get_entry(struct rte_cfgfile *cfg, const char *sectionname=
,
> >  		const char *entryname)
> >  {
> > -	int i;
> > +	size_t i;
>=20
> Why this change? seems not related to free.
>=20
num_entries and num_sections variables changed type from int to size_t and =
now comparison with
i produces warning when compiling.