From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C2B92C75C for ; Fri, 19 Jun 2015 17:04:21 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 19 Jun 2015 08:04:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,644,1427785200"; d="scan'208";a="590946344" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 19 Jun 2015 08:04:20 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 19 Jun 2015 16:04:19 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.117]) by irsmsx155.ger.corp.intel.com ([169.254.14.239]) with mapi id 14.03.0224.002; Fri, 19 Jun 2015 16:04:18 +0100 From: "Gajdzica, MaciejX T" To: Thomas Monjalon Thread-Topic: [dpdk-dev] Issue with rte_compat versioning macros Thread-Index: AdCqnQQggYoEH26OSROSj81vK5Rplf//8xYA///qxzA= Date: Fri, 19 Jun 2015 15:04:17 +0000 Message-ID: <9CC680510C0AC140A846FED2EF7F96281383E8B5@IRSMSX102.ger.corp.intel.com> References: <9CC680510C0AC140A846FED2EF7F96281383E81B@IRSMSX102.ger.corp.intel.com> <2048288.aStCxb75UN@xps13> In-Reply-To: <2048288.aStCxb75UN@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 15:04:22 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, June 19, 2015 4:48 PM > To: Gajdzica, MaciejX T > Cc: dev@dpdk.org; nhorman@tuxdriver.com > Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros >=20 > 2015-06-19 14:38, Gajdzica, MaciejX T: > > There is an issue with macros in rte_compat.h. For shared library=20 > > case, macro BIND_DEFAULT_SYMBOL takes three arguments and for other=20 > > case it takes only two arguments. Also letters for macro variable=20 > > names are > not consistent in these two cases. >=20 > Yes, and your patch fix it: > http://dpdk.org/dev/patchwork/patch/5475/ > But it is part of a series which is not accepted yet. >=20 > It would be faster merged if you send it as a standalone patch. > Thanks But simple solution with adding third argument to static library case doesn= 't work. Comment in rte_compat.h file describes steps needed to add new ver= sion of the function and it says: * 2) rename the existing function int foo(char *string) to * int __vsym foo_v20(char *string) * * 3) Add this macro immediately below the function * VERSION_SYMBOL(foo, _v20, 2.0); * * 4) Implement a new version of foo. * char foo(int value, int otherval) { ...} * * 5) Mark the newest version as the default version * BIND_DEFAULT_SYMBOL(foo, 2.1); So probably BIND_DEFAULT_SYMBOL macro for shared library case needs to be m= odified to have two arguments. I'm not familiar with that symver syntax so I need some help. It would be b= etter when original author say how it should look like. Best Regards Maciek