From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3D2BFC64E for ; Mon, 22 Jun 2015 16:58:21 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 22 Jun 2015 07:58:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,660,1427785200"; d="scan'208";a="751118814" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga002.jf.intel.com with ESMTP; 22 Jun 2015 07:58:19 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 22 Jun 2015 15:58:18 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.117]) by irsmsx155.ger.corp.intel.com ([169.254.14.239]) with mapi id 14.03.0224.002; Mon, 22 Jun 2015 15:58:18 +0100 From: "Gajdzica, MaciejX T" To: "dev@dpdk.org" Thread-Topic: [PATCH v2 0/6] cfgfile: config file parsing extension Thread-Index: AQHQqQ09uzPpqXyq40K8Q+305peO7Z24oDjg Date: Mon, 22 Jun 2015 14:58:17 +0000 Message-ID: <9CC680510C0AC140A846FED2EF7F9628138455C8@IRSMSX102.ger.corp.intel.com> References: <1434552528-3576-1-git-send-email-maciejx.t.gajdzica@intel.com> In-Reply-To: <1434552528-3576-1-git-send-email-maciejx.t.gajdzica@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/6] cfgfile: config file parsing extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 14:58:21 -0000 > -----Original Message----- > From: Gajdzica, MaciejX T > Sent: Wednesday, June 17, 2015 4:49 PM > To: dev@dpdk.org > Cc: Gajdzica, MaciejX T > Subject: [PATCH v2 0/6] cfgfile: config file parsing extension >=20 > Added new implementation of section parsing in config file. Refactored ex= isting > code by spliting it to smaller functions. Changed section allocation sche= me and > added new features - variable length entry value and line continue chara= cter '\'. >=20 > Pawel Wodkowski (6): > librte_cfgfile: fix code formating in header file > librte_compat: fix macro definition > cfgfile: split rte_cfgfile_load to smaller functions > cfgfile: added line continue character '\' to make multiline values > possible > cfgfile: fixed calling free for each section in rte_cfgfile_close > cfgfile: added new implementation of section parsing >=20 > lib/librte_cfgfile/Makefile | 2 +- > lib/librte_cfgfile/rte_cfgfile.c | 793 +++++++++++++++++++++-= ------ > lib/librte_cfgfile/rte_cfgfile.h | 52 +- > lib/librte_cfgfile/rte_cfgfile_version.map | 8 + > lib/librte_compat/rte_compat.h | 8 +- > 5 files changed, 653 insertions(+), 210 deletions(-) >=20 > -- > 1.7.9.5 NACK - After reviewing this patchset, we decided that those changes are not= acceptable in current form. New section allocation scheme doesn't add much value. Also new implementati= on of rte_cfgfile_entry with static string for name and dynamic for value may cause confusion. We will g= o back to cfgfile improvements in 2.2. Best Regards Maciek