From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 842383784 for ; Mon, 22 Jun 2015 17:32:09 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 22 Jun 2015 08:32:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,660,1427785200"; d="scan'208";a="715571272" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 22 Jun 2015 08:32:04 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.117]) by irsmsx105.ger.corp.intel.com ([169.254.7.245]) with mapi id 14.03.0224.002; Mon, 22 Jun 2015 16:32:02 +0100 From: "Gajdzica, MaciejX T" To: Neil Horman Thread-Topic: [dpdk-dev] Issue with rte_compat versioning macros Thread-Index: AdCqnQQggYoEH26OSROSj81vK5Rplf//8xYA///qxzCAACGLAP/7QYZA Date: Mon, 22 Jun 2015 15:32:01 +0000 Message-ID: <9CC680510C0AC140A846FED2EF7F96281384660E@IRSMSX102.ger.corp.intel.com> References: <9CC680510C0AC140A846FED2EF7F96281383E81B@IRSMSX102.ger.corp.intel.com> <2048288.aStCxb75UN@xps13> <9CC680510C0AC140A846FED2EF7F96281383E8B5@IRSMSX102.ger.corp.intel.com> <20150619153208.GC4619@hmsreliant.think-freely.org> In-Reply-To: <20150619153208.GC4619@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 15:32:10 -0000 Hi Neil > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Friday, June 19, 2015 5:32 PM > To: Gajdzica, MaciejX T > Cc: Thomas Monjalon; dev@dpdk.org > Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros >=20 > On Fri, Jun 19, 2015 at 03:04:17PM +0000, Gajdzica, MaciejX T wrote: > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Friday, June 19, 2015 4:48 PM > > > To: Gajdzica, MaciejX T > > > Cc: dev@dpdk.org; nhorman@tuxdriver.com > > > Subject: Re: [dpdk-dev] Issue with rte_compat versioning macros > > > > > > 2015-06-19 14:38, Gajdzica, MaciejX T: > > > > There is an issue with macros in rte_compat.h. For shared library > > > > case, macro BIND_DEFAULT_SYMBOL takes three arguments and for > > > > other case it takes only two arguments. Also letters for macro > > > > variable names are > > > not consistent in these two cases. > > > > > > Yes, and your patch fix it: > > > http://dpdk.org/dev/patchwork/patch/5475/ > > > But it is part of a series which is not accepted yet. > > > > > > It would be faster merged if you send it as a standalone patch. > > > Thanks > > > > But simple solution with adding third argument to static library case d= oesn't > work. Comment in rte_compat.h file describes steps needed to add new vers= ion > of the function and it says: > > > > * 2) rename the existing function int foo(char *string) to > > * int __vsym foo_v20(char *string) > > * > > * 3) Add this macro immediately below the function > > * VERSION_SYMBOL(foo, _v20, 2.0); > > * > > * 4) Implement a new version of foo. > > * char foo(int value, int otherval) { ...} > > * > > * 5) Mark the newest version as the default version > > * BIND_DEFAULT_SYMBOL(foo, 2.1); > > > > So probably BIND_DEFAULT_SYMBOL macro for shared library case needs to > be modified to have two arguments. > > I'm not familiar with that symver syntax so I need some help. It would = be > better when original author say how it should look like. > > > > Best Regards > > Maciek > > > > >=20 > No adding the third parameter will work just fine. The documentation nee= ds to > be updated as well to reflect the 3rd argument: > * 5) Mark the newest version as the default version > * BIND_DEFAULT_SYMBOL(foo, foo, 2.1); >=20 >=20 > Neil >=20 For me versioning still don't work, even though I try to do it as you say. = I had function: int rte_cfgfile_section_entries(struct rte_cfgfile *cfg, const char *sectionname, struct rte_cfgfile_entry *entries, int max_entries) { [...] } And I wanted to add new version of it. So I marked it as _v20, added versio= n macro, added new implementation and default symbol macro: int __vsym rte_cfgfile_section_entries_v20(struct rte_cfgfile *cfg, const char *sectionname, struct rte_cfgfile_entry *entries, int max_entries) { [...] } VERSION_SYMBOL(rte_cfgfile_section_entries, _v20, 2.0); int __vsym rte_cfgfile_section_entries(struct rte_cfgfile *cfg, const char *sectionname, struct rte_cfgfile_entry2 **entries, int max_entries) { [...] } BIND_DEFAULT_SYMBOL(rte_cfgfile_section_entries, rte_cfgfile_section_entrie= s, 2.1); I edited map file so it looks like this: DPDK_2.0 { global: [...] rte_cfgfile_section_entries; [...] local: *; }; DPDK_2.1 { global: rte_cfgfile_section_entries; local: *; }; Then I try to build dpdk and qos_sched example which uses this function. Wh= en I build dpdk as static library, everything works fine. When I build dpdk as shared libra= ry, compilation of example returns error, that it doesn't see rte_cfgfile_section_entries function. Maybe I do something wrong, but it's obvious that better documentation is n= eeded. In current dpdk master code, versioning is not used. There are only 2 patchsets that t= ries to use it. This one and: http://dpdk.org/ml/archives/dev/2015-May/018169.html That second one probably uses it wrong, because second argument of BIND_DEF= AULT_SYMBOL is _v21. And you said, it should be the same as function name. I don't need versioni= ng for now as we decided That rte_cfgfile modifications should be done in next release. But knowing = that versioning macros are well documented and work properly could encourage more people to use it= . Best Regards Maciek