From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maciejx.t.gajdzica@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 63B7C8D3B
 for <dev@dpdk.org>; Wed, 12 Aug 2015 14:58:25 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP; 12 Aug 2015 05:58:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,660,1432623600"; d="scan'208";a="782672239"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by orsmga002.jf.intel.com with ESMTP; 12 Aug 2015 05:58:23 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.158]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.130]) with mapi id 14.03.0224.002;
 Wed, 12 Aug 2015 13:58:22 +0100
From: "Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the
 list
Thread-Index: AQHQ1PwBU6dpYS2+7kCapDmpI19dxJ4IQMgAgAARwpA=
Date: Wed, 12 Aug 2015 12:58:22 +0000
Message-ID: <9CC680510C0AC140A846FED2EF7F962826C0E964@IRSMSX102.ger.corp.intel.com>
References: <1439383287-28447-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <3605610.CPCfiOFDq4@xps13>
In-Reply-To: <3605610.CPCfiOFDq4@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the
 list
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Aug 2015 12:58:25 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, August 12, 2015 2:53 PM
> To: Gajdzica, MaciejX T
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to t=
he list
>=20
> 2015-08-12 14:41, Maciej Gajdzica:
> > test_table_ACL wasn't invoked when running table_autotest. Added this
> > test to table_tests array to make it run with other table tests.
> >
> > Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
> [...]
> > --- a/app/test/test_table_tables.h
> > +++ b/app/test/test_table_tables.h
> > @@ -36,7 +36,7 @@ int test_table_lpm(void);  int
> > test_table_lpm_ipv6(void);  int test_table_array(void);  #ifdef
> > RTE_LIBRTE_ACL -int test_table_acl(void);
> > +int test_table_ACL(void);
>=20
> Why renaming it uppercase?
> Function names should be lowercase.
>=20
> It is lowercase also in app/test/test_table_combined.h

Yes, but in app/test/test_table_acl.c it is uppercase, and there is no defi=
nition for lowercase function. I can change name in test_table_acl.c to low=
ercase.

Best Regards
Maciek