From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C987A8D8A for ; Thu, 13 Aug 2015 12:25:57 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 13 Aug 2015 03:25:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,669,1432623600"; d="scan'208";a="783328884" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga002.jf.intel.com with ESMTP; 13 Aug 2015 03:25:55 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.158]) by irsmsx110.ger.corp.intel.com ([169.254.15.29]) with mapi id 14.03.0224.002; Thu, 13 Aug 2015 11:25:55 +0100 From: "Gajdzica, MaciejX T" To: "Gajdzica, MaciejX T" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the list Thread-Index: AQHQ1PwBU6dpYS2+7kCapDmpI19dxJ4IQMgAgAARwpCAAWeiwA== Date: Thu, 13 Aug 2015 10:25:55 +0000 Message-ID: <9CC680510C0AC140A846FED2EF7F962826C0EC29@IRSMSX102.ger.corp.intel.com> References: <1439383287-28447-1-git-send-email-maciejx.t.gajdzica@intel.com> <3605610.CPCfiOFDq4@xps13> <9CC680510C0AC140A846FED2EF7F962826C0E964@IRSMSX102.ger.corp.intel.com> In-Reply-To: <9CC680510C0AC140A846FED2EF7F962826C0E964@IRSMSX102.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to the list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 10:25:58 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gajdzica, MaciejX T > Sent: Wednesday, August 12, 2015 2:58 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test to t= he list >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, August 12, 2015 2:53 PM > > To: Gajdzica, MaciejX T > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/1] test_table: added ACL table test > > to the list > > > > 2015-08-12 14:41, Maciej Gajdzica: > > > test_table_ACL wasn't invoked when running table_autotest. Added > > > this test to table_tests array to make it run with other table tests. > > > > > > Signed-off-by: Maciej Gajdzica > > [...] > > > --- a/app/test/test_table_tables.h > > > +++ b/app/test/test_table_tables.h > > > @@ -36,7 +36,7 @@ int test_table_lpm(void); int > > > test_table_lpm_ipv6(void); int test_table_array(void); #ifdef > > > RTE_LIBRTE_ACL -int test_table_acl(void); > > > +int test_table_ACL(void); > > > > Why renaming it uppercase? > > Function names should be lowercase. > > > > It is lowercase also in app/test/test_table_combined.h >=20 > Yes, but in app/test/test_table_acl.c it is uppercase, and there is no de= finition > for lowercase function. I can change name in test_table_acl.c to lowercas= e. In current code ACL table tests are executed at the end after table tests a= nd table tests combined, so this patch is not needed. I will only send patc= h with function name renamed to lowercase. Best Regards Maciek