Re: [dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add configuration file support

["Chen, Zhaoyan" <zhaoyan.chen@intel.com>]

Tested-by: Zhaoyan Chen <zhaoyan.chen@intel.com>
- Apply patch: Pass
- Compile: Pass
- OS: 3.17.4-301.fc21.x86_64
- GCC: 4.9.2

Test Case - Pass
- Launch ipsec-gateway with "-f" parameter and ep0.cfg, check the default configuration file work.
- Modified Algorithm in config file and launch ipsec-gateway and check the new algorithm effected
- Modified the key and check the key effected.
- Modified the iv and check the iv effected
- Modified the router rule and check the the rule effected

But for negative test, 
If input incorrect key and iv, the application will PANIC in parse_cfg_file()
For instance, change the line 70 in ep0.cfg, add 1 more <space> at the end of line, like "a0:a0:a0: \" 
The application will Abort (core dump). Expected it should report error and exit safe. 



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Wednesday, September 21, 2016 8:05 PM
> To: dev@dpdk.org
> Cc: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>
> Subject: [dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add
> configuration file support
> 
> This patch adds the configuration file support to ipsec_secgw
> sample application. Instead of hard-coded rules, the users can
> specify their own SP, SA, and routing rules in the configuration
> file. An command line option "-f" is added to pass the
> configuration file location to the application.
> 
> Configuration item formats:
> 
> SP rule format:
> sp <ip_ver> <dir> esp <action> <priority> <src_ip> <dst_ip> \
> <proto> <sport> <dport>
> 
> SA rule format:
> sa <dir> <spi> <cipher_algo> <cipher_key> <auth_algo> <auth_key> \
> <mode> <src_ip> <dst_ip>
> 
> Routing rule format:
> rt <ip_ver> <src_ip> <dst_ip> <port>
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  doc/guides/rel_notes/release_16_11.rst   |   4 +
>  doc/guides/sample_app_ug/ipsec_secgw.rst | 845 +++++++++++++----------
> --------
>  examples/ipsec-secgw/Makefile            |   1 +
>  examples/ipsec-secgw/ipsec-secgw.c       |  58 ++-
>  examples/ipsec-secgw/ipsec.h             |  14 +-
>  examples/ipsec-secgw/parser.c            | 599 ++++++++++++++++++++++
>  examples/ipsec-secgw/parser.h            | 116 +++++
>  examples/ipsec-secgw/rt.c                | 255 ++++------
>  examples/ipsec-secgw/sa.c                | 747 +++++++++++++++++----------
>  examples/ipsec-secgw/sp4.c               | 538 ++++++++++++--------
>  examples/ipsec-secgw/sp6.c               | 539 +++++++++++++-------
>  11 files changed, 2397 insertions(+), 1319 deletions(-)
>  create mode 100644 examples/ipsec-secgw/parser.c
>  create mode 100644 examples/ipsec-secgw/parser.h
> 
> diff --git a/doc/guides/rel_notes/release_16_11.rst
> b/doc/guides/rel_notes/release_16_11.rst
> index 451872e..da61798 100644
> --- a/doc/guides/rel_notes/release_16_11.rst
> +++ b/doc/guides/rel_notes/release_16_11.rst
> @@ -82,6 +82,10 @@ Libraries
>  Examples
>  ~~~~~~~~
> 
> +* **ipsec-secgw: add configuration file support**
> +
> +  ipsec-secgw sample application now supports configuration file to specify
> +  SP, SA, and routing rules.
> 
>  Other

[...] 

> --
> 2.5.5