From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D0CDE1E2F for ; Tue, 10 Jan 2017 09:39:00 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP; 10 Jan 2017 00:38:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,343,1477983600"; d="scan'208";a="51492822" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 10 Jan 2017 00:38:56 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 00:38:56 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Jan 2017 00:38:56 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Tue, 10 Jan 2017 16:38:52 +0800 From: "Chen, Zhaoyan" To: "dev@dpdk.org" CC: "Azarewicz, PiotrX T" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check Thread-Index: AQHSaocq/byqGzJrJEW55wY126GrBKExY3Xg Date: Tue, 10 Jan 2017 08:38:52 +0000 Message-ID: <9DEEADBC57E43F4DA73B571777FECECA3C809BD7@shsmsx102.ccr.corp.intel.com> References: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com> In-Reply-To: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 08:39:01 -0000 Tested-by: Zhaoyan Chen - Checked patch: success=20 - Apply patch: success - Compilation: success Tested basic openssl_pmd tests and check the extra bytes. Passed. Thanks /Joey > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz > Sent: Monday, January 9, 2017 10:46 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: stable@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded > check >=20 > EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is > unneeded. >=20 > Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") >=20 > Signed-off-by: Piotr Azarewicz > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c > b/drivers/crypto/openssl/rte_openssl_pmd.c > index 832ea1d..312154a 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -522,8 +522,7 @@ > if (EVP_DecryptInit_ex(ctx, algo, NULL, key, iv) <=3D 0) > goto process_cipher_decrypt_err; >=20 > - if (EVP_CIPHER_CTX_set_padding(ctx, 0) <=3D 0) > - goto process_cipher_decrypt_err; > + EVP_CIPHER_CTX_set_padding(ctx, 0); >=20 > if (EVP_DecryptUpdate(ctx, dst, &dstlen, src, srclen) <=3D 0) > goto process_cipher_decrypt_err; > -- > 1.7.9.5