From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0A9D21B8EF for ; Mon, 29 Jan 2018 18:21:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 09:21:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,432,1511856000"; d="scan'208";a="23163579" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga003.jf.intel.com with ESMTP; 29 Jan 2018 09:21:41 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.188]) by IRSMSX103.ger.corp.intel.com ([169.254.3.197]) with mapi id 14.03.0319.002; Mon, 29 Jan 2018 17:21:25 +0000 From: "Zhang, Roy Fan" To: "Zhang, Roy Fan" , Jay Zhou , "dev@dpdk.org" CC: "yliu@fridaylinux.org" , "maxime.coquelin@redhat.com" , "arei.gonglei@huawei.com" , "Zeng, Xin" , "weidong.huang@huawei.com" , "wangxinxin.wang@huawei.com" , "longpeng2@huawei.com" Thread-Topic: [PATCH] virtio: add new driver for crypto devices Thread-Index: AQHTX8dFV/HgsE430UOJJXSBBIVIC6OLh3WAgAAD2LA= Date: Mon, 29 Jan 2018 17:21:25 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C604330ABC4E@IRSMSX101.ger.corp.intel.com> References: <1510938620-15268-1-git-send-email-jianjay.zhou@huawei.com> <9F7182E3F746AB4EA17801C148F3C604330ABC27@IRSMSX101.ger.corp.intel.com> In-Reply-To: <9F7182E3F746AB4EA17801C148F3C604330ABC27@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGVlMDgwN2UtOWY3Yi00YThkLWJiZjctMmI1NTFkNzE1MzZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InROWktqVTlvU0I0SlBkckt4SnZaNkZFbmZucktKdFBzMHpkRTZKZ0wrb0k9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] virtio: add new driver for crypto devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 17:21:44 -0000 Hi Jay, =20 > > + switch (cmd_id) { > > + case VIRTIO_CRYPTO_CMD_CIPHER_HASH: > > + case VIRTIO_CRYPTO_CMD_HASH_CIPHER: > > + ctrl->u.sym_create_session.op_type > > + =3D VIRTIO_CRYPTO_SYM_OP_ALGORITHM_CHAINING; >=20 > The above line is clearly a bug. My bad, it isn't a bug. Regards, Fan