From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 573177CFA for ; Wed, 21 Mar 2018 05:08:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2018 21:08:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,338,1517904000"; d="scan'208";a="184627159" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 20 Mar 2018 21:08:53 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX151.ger.corp.intel.com ([169.254.4.3]) with mapi id 14.03.0319.002; Wed, 21 Mar 2018 04:08:52 +0000 From: "Zhang, Roy Fan" To: 'Jay Zhou' , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "thomas@monjalon.net" , "arei.gonglei@huawei.com" , "Zeng, Xin" , "weidong.huang@huawei.com" , "wangxinxin.wang@huawei.com" , "longpeng2@huawei.com" , "Zhang, Roy Fan" Thread-Topic: [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices Thread-Index: AQHTrXGO3KpBOCc01k2EaUoZWj7B9aO4gxDg Date: Wed, 21 Mar 2018 04:08:51 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C604331024B8@IRSMSX101.ger.corp.intel.com> References: <02e4c16f6c0f330f8c7941160a69e8d20510713f.1519477564.git.jianjay.zhou@huawei.com> In-Reply-To: <02e4c16f6c0f330f8c7941160a69e8d20510713f.1519477564.git.jianjay.zhou@huawei.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2QzZTk1NTEtNGU2MC00YTc5LTk3YWItMjBhNGVjOTBjYjQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InJNODVZSE1vdWZLRGNhMG11SXR4aXMzS3NnT3QxZ0JzRXk1N3Eya1RTSmc9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 04:08:56 -0000 Hi Jay, Excellent work! The patch, although need some minor rework, has improved th= e performance. Some comments: 1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhost = crypto proxy backend only AESCBC and SHA1 are supported (in cryptodev_vhost= _user_init() definition), I believe in this version these two algorithms sh= all be enough. Actually for the same reason I suggest you to remove all AE= S_CTR test cases in the virtio_crypto PMD functional test, as they will fai= l when vhost_user crypto backend is used. You may use driver/crypto/qat/qat_crypto_capabilities.h as example. The con= st capabilities array shall be returned to the application when virtio_cryp= to_dev_info_get() is called. 2. there is a bug in virtio_crypto_queue_setup(), you declared " uint32_t i= , j;" while i may be used uninitialized later. Regards, Fan > diff --git a/drivers/crypto/virtio/virtio_rxtx.c > b/drivers/crypto/virtio/virtio_rxtx.c > new file mode 100644 > index 0000000..b7d8066 > --- /dev/null > +++ b/drivers/crypto/virtio/virtio_rxtx.c > @@ -0,0 +1,533 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD. > + */ > +