From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix missing case for virtio-crypto
Date: Fri, 2 Nov 2018 10:01:59 +0000 [thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <2772595.iFPTlCQAWG@xps>
Hi Thomas,
You are right, the problem can happen with any PMD falls into RTE_KDRV_UIO_GENERIC and RTE_KDRV_NIC_UIO driver type. As riginally rte_pci_read_config() only covered 2 out of 4 possible driver types' .
The patch was submitted for fixing the Virtio Crypto Initialization Segmentation Fault problem introduced in 18.11 RC1, and it did. The problem is I don't think the patch will fix all problems of rte_pci_read_config(). Even I added RTE_KDRV_UIO_GENERIC type into the switch case there is a remaining RTE_KDRV_NIC_UIO type I am not sure where to fit due to the limited knowledge.
That's why I write the patch title like this. I hope someone else with better bus knowledge could submit a complete fix patch.
Best regards,
Fan
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, November 1, 2018 1:35 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; alejandro.lucero@netronome.com
> Subject: Re: [PATCH] bus/pci: fix missing case for virtio-crypto
>
> 01/11/2018 13:10, Fan Zhang:
> > The recent change to rte_pci_read_config() caused virtio-crypto device
> > initialization always failed as it has a RTE_KDRV_UIO_GENERIC driver
> > type. This patch fixes the problem.
>
> Hi Fan,
> this issue is not related at all to virtio-crypto.
> It can happen with any PMD, right?
>
> In the title, we should mention UIO generic driver.
>
>
next prev parent reply other threads:[~2018-11-02 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 12:10 Fan Zhang
2018-11-01 13:35 ` Thomas Monjalon
2018-11-02 10:01 ` Zhang, Roy Fan [this message]
2018-11-02 10:39 ` Thomas Monjalon
2018-11-05 22:18 ` Thomas Monjalon
2018-11-06 1:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com \
--to=roy.fan.zhang@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).