From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <roy.fan.zhang@intel.com> Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6A2DD5B2C for <dev@dpdk.org>; Wed, 27 Mar 2019 16:20:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 08:20:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,277,1549958400"; d="scan'208";a="130641031" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga006.jf.intel.com with ESMTP; 27 Mar 2019 08:20:16 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.230]) by IRSMSX151.ger.corp.intel.com ([169.254.4.91]) with mapi id 14.03.0415.000; Wed, 27 Mar 2019 15:20:14 +0000 From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com> To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Doherty, Declan" <declan.doherty@intel.com>, "Trahe, Fiona" <fiona.trahe@intel.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> Thread-Topic: [PATCH] app/test-crypto-perf: improve dequeue logic Thread-Index: AQHU5JLk4oLoEw6av0KMpJVh9+yHtaYfle1Q Date: Wed, 27 Mar 2019 15:20:12 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C604335B6323@IRSMSX101.ger.corp.intel.com> References: <20190327113823.13481-1-akhil.goyal@nxp.com> In-Reply-To: <20190327113823.13481-1-akhil.goyal@nxp.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjlkMzMyZmYtYzUxNS00NGRlLTgxNmMtMjFkMzlhYzRjOGU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUzJGTGx5MnlJQ3Zrc0sxZzJZQytPZGx4c0FzZUtvMFNzODZYdmNJWnR5Z0toSlp0bW9BRUdnbjN4Zk9IMzFRbyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: improve dequeue logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 27 Mar 2019 15:20:19 -0000 Hi Akhil, This patch seems introduced performance degradation on my server with QAT DH895XCC by more than 10% for big packets (>=3D256). Fiona/Pablo, could you have a try with it? Regards, Fan > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Wednesday, March 27, 2019 11:48 AM > To: dev@dpdk.org > Cc: Doherty, Declan <declan.doherty@intel.com>; Akhil Goyal > <akhil.goyal@nxp.com> > Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: improve dequeue logic >=20 > In case of hardware PMDs (which may take a longer duration for processing > the packets), there may be a case when the number of enqueued packets > are more than the dequeued. >=20 > So if the difference is more than 8 times the burst size, more dequeue > operations should be performed otherwise all the buffers will be blocked = in > hardware. >=20 > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> > --- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5F805A05D3 for <public@inbox.dpdk.org>; Wed, 27 Mar 2019 16:20:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 324FE5B36; Wed, 27 Mar 2019 16:20:21 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6A2DD5B2C for <dev@dpdk.org>; Wed, 27 Mar 2019 16:20:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2019 08:20:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,277,1549958400"; d="scan'208";a="130641031" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga006.jf.intel.com with ESMTP; 27 Mar 2019 08:20:16 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.230]) by IRSMSX151.ger.corp.intel.com ([169.254.4.91]) with mapi id 14.03.0415.000; Wed, 27 Mar 2019 15:20:14 +0000 From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com> To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Doherty, Declan" <declan.doherty@intel.com>, "Trahe, Fiona" <fiona.trahe@intel.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> Thread-Topic: [PATCH] app/test-crypto-perf: improve dequeue logic Thread-Index: AQHU5JLk4oLoEw6av0KMpJVh9+yHtaYfle1Q Date: Wed, 27 Mar 2019 15:20:12 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C604335B6323@IRSMSX101.ger.corp.intel.com> References: <20190327113823.13481-1-akhil.goyal@nxp.com> In-Reply-To: <20190327113823.13481-1-akhil.goyal@nxp.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjlkMzMyZmYtYzUxNS00NGRlLTgxNmMtMjFkMzlhYzRjOGU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUzJGTGx5MnlJQ3Zrc0sxZzJZQytPZGx4c0FzZUtvMFNzODZYdmNJWnR5Z0toSlp0bW9BRUdnbjN4Zk9IMzFRbyJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test-crypto-perf: improve dequeue logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190327152012.Y3ihuFhj-BtkgYIF0VeFlfruZNs7UdVzzRkZf0iDCZ0@z> Hi Akhil, This patch seems introduced performance degradation on my server with QAT DH895XCC by more than 10% for big packets (>=3D256). Fiona/Pablo, could you have a try with it? Regards, Fan > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Wednesday, March 27, 2019 11:48 AM > To: dev@dpdk.org > Cc: Doherty, Declan <declan.doherty@intel.com>; Akhil Goyal > <akhil.goyal@nxp.com> > Subject: [dpdk-dev] [PATCH] app/test-crypto-perf: improve dequeue logic >=20 > In case of hardware PMDs (which may take a longer duration for processing > the packets), there may be a case when the number of enqueued packets > are more than the dequeued. >=20 > So if the difference is more than 8 times the burst size, more dequeue > operations should be performed otherwise all the buffers will be blocked = in > hardware. >=20 > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com> > ---