DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: Jens Freimann <jfreimann@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
Date: Mon, 17 Jun 2019 09:09:59 +0000	[thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C6043363953D@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20190516080709.pq3wwurtynf6dnwy@jenstp.localdomain>

Hi Jens,

You are right. Sorry the code wasn't cleaned up properly in the first place.
Do you want me to send a v2 with new title?

Regards,
Fan

> -----Original Message-----
> From: Jens Freimann [mailto:jfreimann@redhat.com]
> Sent: Thursday, May 16, 2019 9:07 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked
> return value
> 
> On Wed, May 15, 2019 at 05:25:48PM +0100, Fan Zhang wrote:
> >This patch tries to fix the coverity issue of unchecked return value.
> >Since the function that causes the problem is unused, it is removed
> >completely.
> >
> >Coverity issue: 336816
> >Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> >---
> > examples/vhost_crypto/main.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> 
> It really is unused.
> 
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
> 


  parent reply	other threads:[~2019-06-17  9:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 16:25 Fan Zhang
2019-05-15 16:25 ` Fan Zhang
2019-05-16  8:07 ` Jens Freimann
2019-05-16  8:07   ` Jens Freimann
2019-06-17  9:09   ` Zhang, Roy Fan [this message]
2019-06-19 11:56     ` Jens Freimann
2019-06-17  9:26 ` Kovacevic, Marko
2019-06-20  9:43 ` Maxime Coquelin
2019-06-24 12:25   ` Zhang, Roy Fan
2019-06-20  9:59 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9F7182E3F746AB4EA17801C148F3C6043363953D@IRSMSX101.ger.corp.intel.com \
    --to=roy.fan.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jfreimann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).