From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC03242AC3; Wed, 10 May 2023 07:50:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CBE8406BA; Wed, 10 May 2023 07:50:26 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2084.outbound.protection.outlook.com [40.107.8.84]) by mails.dpdk.org (Postfix) with ESMTP id 9B26940697 for ; Wed, 10 May 2023 07:50:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EcWwav8sAG3yc3+FURio7WwRyNo/JZwC40HDQKY0kuS7sFE2M8hxVwMTNaAEhJ2pvFUgdDR2NOyT0xc7yGcqq2yblOCZw9rj4rFcO7u1i5S6uQSI1eEPtdh5GdxIrzAEjft/VrM+FwR+0LFhcDfF62tsX3fsqm9k4j4unf3G5MSXK4W+NGJxEtzJFPMaaK0zBaNJFUB3ATzZ4UGb/P6UVEVN1qUCi8cvKgPiZ35pEb0Pc+rEvDhytLvYRbh0vt7GtS62aTs3zhlhRJ6pPyck5cjtn0/11xulIS4Cz6VgJ7MRXbOzhzJR1Ch90zlyaebl+VM6rRbDXIHC46bUM2mFVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sDVx489TJIQDu0/1xvlxdK1bF7pOTsBsztVdQHhc2WE=; b=YBV95TN+67IMFEB6GYPU0VRC/SETn+NnaxGGaahY2bL2IDdX43xICuywttokj0jWfEL2bQIlfZXdvLPzM2gZLLa1NYQhoPtPsyZvHcsPT8AQsoLEUuLTLRDc5MMTfhNwUA/xzZwEdNTHFyaV9l+d96vBkjpMxNKifLRrEMNzvo5LrUMbVYs0h6rX8MbmmnaZnfCTFLwQ8XwoodCPycGjWN6UyTNBrRiV75D0k26Kt69Q8K2JfLMCma6/Lu5b2I+VM2Wa9tzuq+goTn7eL/w/GUbtMCEDw/qnnUZrRPLpF3/HDmaJ8ueZpVe0IVeF5kPU1G7rH/IyqzwMXiVf8LxUAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDVx489TJIQDu0/1xvlxdK1bF7pOTsBsztVdQHhc2WE=; b=S5J7XgUd6fLlHFixP7uKX7HjlczYBgptiuY+vqEMR50dGBhBmkFParx0d+2T/cWrI6wWyWh4ZJYIlt6Q+z7cAK48+b5Ax4X4CNlq4y4oYeAdGusZLDbXR9hezY2Zsfg4/j5fmwZcSeAeq6HXyEVJ9KM+73697dUOqtVkz5n3QgY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) by GVXPR04MB10045.eurprd04.prod.outlook.com (2603:10a6:150:11a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.18; Wed, 10 May 2023 05:50:22 +0000 Received: from AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::5787:8cca:9d7e:956c]) by AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::5787:8cca:9d7e:956c%5]) with mapi id 15.20.6363.033; Wed, 10 May 2023 05:50:22 +0000 Message-ID: <9a101fa4-d704-c3c9-43e9-56bfe2de993a@oss.nxp.com> Date: Wed, 10 May 2023 11:20:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] net/dpaa2: set check sum good flags Content-Language: en-US To: Tianli Lai , dev@dpdk.org, Sachin Saxena Cc: Hemant Agrawal References: <20230508105725.4559-1-laitianli@tom.com> From: "Sachin Saxena (OSS)" Organization: NXP In-Reply-To: <20230508105725.4559-1-laitianli@tom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI1PR02CA0043.apcprd02.prod.outlook.com (2603:1096:4:1f6::19) To AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8562:EE_|GVXPR04MB10045:EE_ X-MS-Office365-Filtering-Correlation-Id: ceab5d81-8531-40f3-77eb-08db511a71db X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wdEv7x47v8aEwZdHpk2IjM+blNe3XRmvHZsEXhfIlY34yymVBwtvOpcXnjpMtSHOGiumqyixqAtt+skEG378gXbWZqay4UQebuzJF09KcEA364rk+st4MMESA+4AZiwrN3VjLMyS+pD6XMtTcWvZXn0qaRa1F5JqiK1YibjtYMlvdjb/Xwx+ccf9RQJCFyDYsP4aMXm6otHtjyoirKrkpmvFAzq+1bPWngLnC2bREdQwMqjxdr+9scNRbvltf8NQTxpOAUeaGfE/avHQB+tBsry8NMpHSE8/vylpw3gglO/G/RrsDCrQ+Ope9lbYz31Mjve/rjkEX3CYpEhUhhGFOut0wyz8QDGvqzWqbSJQyP5k5aWZSAuOch+TcxVFp90Lp2EOKVFdBveMdH2UWcnySl733w/wJChmpq70EV05aSGDTt+4C7tjllVHsjZnLFSW3T5fkpaNkA0TImD0WGyXbSpmzal20oNlYz84i6j41Q9v6lmVuRPV7ixOuriCroa4J1F6jO3z7QYb9zrBHJxf6HM1esIANk7nIzMaYWtVyltOvLGg6s6ftFmW0wAb83paRGVR2j5oIJnYJEkOUEErxZq0DlPtplK6EAM4fTEnXtJT9qcyvB8TPuN0uZKIVScmKsCCVD9zGBVgWyTyH7BXZg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8562.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(451199021)(31686004)(2906002)(31696002)(83380400001)(86362001)(53546011)(186003)(6512007)(66556008)(478600001)(66476007)(66946007)(4326008)(36916002)(5660300002)(6666004)(6486002)(110136005)(2616005)(26005)(6506007)(41300700001)(316002)(38100700002)(8936002)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2NjU0dpdnhyQXZWQkwwMzZRdHFlVldjV2svQjE0LzUvUE0yREVBY2pDVFA5?= =?utf-8?B?cXFWZ0h3eVRpMytBTFA4QkQxKzVMS3ZFZDVYWHJINTVLMnNSZHJnNWdWOFRi?= =?utf-8?B?bDNwS01xNWN4RGpwZ050MlhyTGxNTE1EL3JJRFFLeG8wNDJ1SnNlcFFLOHV1?= =?utf-8?B?aDRnaHljRllyYmx2RHcrbXFqSWdWTFNJZFdPbnRTU09tSWhveHlSekVFb2xs?= =?utf-8?B?VDFRV3lySDUvbFQ5TUpPa2VtUVJVdVA3QWRCMkVxMFBqVmVoNHc5Wk40N2o1?= =?utf-8?B?K0IxSnhSRnRzRVRpZndUM2xjazc5ZXdBRTVsT0NnZlIyWGZhVE9xV0dudVR3?= =?utf-8?B?VEFBc2NCMzF3UFcxbWhGWGlhb1lXc3Mzd21KWlRiNFlTZ0lheDdGSW02RVgy?= =?utf-8?B?VlZSaFduZ1pyUTJBajdhcGx1RkI4L3VRK2loNVpwUmw4dHFQc3ZWVURDbFB5?= =?utf-8?B?MzVMQUROcFFHdk5na2cvbVVIZktWZjAzWGszalRZbGczNkZqQyt5V0dyclNY?= =?utf-8?B?cmw2bzRKOHUxUjY2d2ZyWFA1c1g2eXkrYXRVUmNYMi9XRkUxUzlvZnp4Wlpk?= =?utf-8?B?YmhZdVkyM2JLem5Sbkp2djNOcld3dXJpNEZWU2pXYUd0SUJLNEhWcXNnSnQ2?= =?utf-8?B?N2xJSm9ET2UraFRUOVZ6d1FJMWhQZGE5M1hqSUUwVmRhd3hCeUdYbFRMdkhG?= =?utf-8?B?dDJRazdOT2FrLzBxbmcvVlQwYjBSMjNPdFlrUXpFWWh3V3Bzei8zYlNLb2lz?= =?utf-8?B?dCtOQy9nTWFLTXZER3h1MjVycmc3ejZENDFjQzJCblUzckVvSzZGcUhxWHhw?= =?utf-8?B?cTRqS1ROU3RKdyt6a3NmaVhzbGEvRXNuL1Fxcmw1OGpCak96cnJnTk1rcW5u?= =?utf-8?B?TERlYUhtUXF1enE2Q3Y5end5b3p6cXBQTUV2dElYV2NRcVNoU1lvd1kva2RL?= =?utf-8?B?WU9BWjBwa2M3ZDl4UmNwRXFUNXRPOGp2NnZBVGlzcEVwZjdUNEtlNkZPTGZM?= =?utf-8?B?UGJKMzA0Rk93VmMvcjRkNitaMVN1am1vMHUxK0FGL0ZTc05kWlpqbjN2TGdD?= =?utf-8?B?dTNaQmF3R1hyODlZT1BYMEhQaG5HNHdRVmF5Y09YeFRuWnRuSFU0aUY0ZXU2?= =?utf-8?B?TzhXMWZjd2dQc0k1bjZTY1VENnFUdHFKYmJ1OEplYkZNT0Y4eW44dk1EN0RY?= =?utf-8?B?eVBiaUVYYklBM1RHalA2RVhMM2U4d3FSR3Zjazk5QU9JNWZ1MmE1cHAwRG9Q?= =?utf-8?B?Mm5YUENEV0FlUzhldzVtbS90bjFjZklhWk00czEwSy9YdHE1VVFqbFdWZU5y?= =?utf-8?B?cStIR1I0aDAxV1p1Y3JpZ1I0RWF6UlA3cExzeCtXYXhuWkI3aDZybVE1K3Nr?= =?utf-8?B?c2hZSlFDdnE2K1lwNzJOSXZuVWFNS0g1aFYxc1pYUXIxczc5eTRaZmlXMTV2?= =?utf-8?B?Q00ycTZ1enpVM2hsSlZZUFk5cWVQeCs0OG1JTE5xM1dQNjBJN2U2ZTZBNG1F?= =?utf-8?B?REt0WWdzUTRHTHROYk9IM1RqZUYveEpjeGVVU2Q4ZGtSVVl5eEd1bzM5ZzVC?= =?utf-8?B?REZmOTRpeHFlYURmL3NLVDdYMnhWNmZ1dzBUYVlQWHQ2TmFQSTNLdkEwT3kr?= =?utf-8?B?Z2E0WnRLeXhNRExMcVYxa1duemZWc09NaWs4UG1xLzhPZkZ1MmNyZW1Hb3Zy?= =?utf-8?B?QWtkemlxSi9NekFVNHpIUHBYTlRPN0ZaTndsbzdTOTJYRVd2aFBJMFdPMCtv?= =?utf-8?B?UUUxMnB5cWxsV1Q2WTRiSGF3UGx4MnRLSkx4V0NFWWlsSGlpY3pVSVI4UXhB?= =?utf-8?B?WHIxSUw0YiszMDVEaTc5OXIwTjVBM00vcmxtWTRxa05lRy93YWNhTUZmTXJv?= =?utf-8?B?RVJFbE5lVCtIMTJycEl0NmVLY3lLWmQvakVtcmZXL1VlRm9NRVh1ZFNHeGRn?= =?utf-8?B?YmJRN2l2am1FMkw0d3ZESTVheHNId2Y2bTduWFBJVEd0SEhqYnFFRytXdnJO?= =?utf-8?B?N0hVQ2Y1SitvQWM2SDFTYjRqUFpLR2puOG02T2hIQXd1ZGZ2M1Q1by8rNnNB?= =?utf-8?B?Q2JFSzdCUGxQMnZLWUU0RVJIdVg3cWtPNU9hY1VmSWpKcHg4Q2VsVEJxMUV3?= =?utf-8?B?TXJuNVozbVJvRVVKK2tKaThpcHpjTEh1OWswRlRORVdtZkZvbXhYN1N4Q01N?= =?utf-8?B?U0E9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ceab5d81-8531-40f3-77eb-08db511a71db X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8562.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 05:50:22.6951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2iXgawdG3U+b7URLMs1qqH7/Nty1EZvnE87bwpzusM7DwcxFjzJnk9FTNhB5KLPd56b6F3xPL+EKW7zbg7eE4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB10045 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/8/2023 4:27 PM, Tianli Lai wrote: > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button > > > set check sum good flags when dpaa2 hardware set check result. > > Signed-off-by: Tianli Lai > --- > drivers/net/dpaa2/dpaa2_rxtx.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c > index f60e78e1fd..85910bbd8f 100644 > --- a/drivers/net/dpaa2/dpaa2_rxtx.c > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c > @@ -198,8 +198,12 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, > > if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE)) > mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD; > - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) > + else > + mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD; > + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) > mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; > + else > + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; > > if (BIT_ISSET_AT_POS(annotation->word4, L3_IP_1_FIRST_FRAGMENT | > L3_IP_1_MORE_FRAGMENT | > @@ -241,8 +245,12 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) > > if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE)) > mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD; > - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) > + else > + mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD; > + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) > mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; > + else > + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; > > if (dpaa2_enable_ts[mbuf->port]) { > *dpaa2_timestamp_dynfield(mbuf) = annotation->word2; > -- > 2.27.0 > Acked-by: Sachin Saxena -- Thanks, Sachin Saxena (NXP)