From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1B74345DD5;
	Fri,  6 Dec 2024 19:15:42 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E7A1240E03;
	Fri,  6 Dec 2024 19:15:41 +0100 (CET)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com
 [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id F33044064F
 for <dev@dpdk.org>; Fri,  6 Dec 2024 19:15:40 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.18.186.31])
 by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Y4fTK5SlGz6K6nd;
 Sat,  7 Dec 2024 02:11:17 +0800 (CST)
Received: from frapeml500006.china.huawei.com (unknown [7.182.85.219])
 by mail.maildlp.com (Postfix) with ESMTPS id 359B31403A2;
 Sat,  7 Dec 2024 02:15:40 +0800 (CST)
Received: from frapeml500007.china.huawei.com (7.182.85.172) by
 frapeml500006.china.huawei.com (7.182.85.219) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Fri, 6 Dec 2024 19:15:39 +0100
Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by
 frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039;
 Fri, 6 Dec 2024 19:15:39 +0100
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Tomasz Duszynski <tduszynski@marvell.com>, Thomas Monjalon
 <thomas@monjalon.net>
CC: "Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>,
 "konstantin.v.ananyev@yandex.ru" <konstantin.v.ananyev@yandex.ru>,
 "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
 "mb@smartsharesystems.com" <mb@smartsharesystems.com>,
 "roretzla@linux.microsoft.com" <roretzla@linux.microsoft.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "zhoumin@loongson.cn" <zhoumin@loongson.cn>
Subject: RE: [PATCH v16 1/4] lib: add generic support for reading PMU events
Thread-Topic: [PATCH v16 1/4] lib: add generic support for reading PMU events
Thread-Index: AQHbOY1KBjHWsiyy5UGZGTeF94ZHIrLZoPPA
Date: Fri, 6 Dec 2024 18:15:39 +0000
Message-ID: <9a3357e180194e75a6a35a57c78f5e32@huawei.com>
References: <20241025085414.3412068-1-tduszynski@marvell.com>
 <20241118073706.3129423-1-tduszynski@marvell.com>
 <20241118073706.3129423-2-tduszynski@marvell.com>
In-Reply-To: <20241118073706.3129423-2-tduszynski@marvell.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.206.138.73]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



>=20
> Add support for programming PMU counters and reading their values
> in runtime bypassing kernel completely.
>=20
> This is especially useful in cases where CPU cores are isolated
> i.e run dedicated tasks. In such cases one cannot use standard
> perf utility without sacrificing latency and performance.
>=20
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
> ---

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>

As future possible enhancements - I think it would be useful to
make control-path API MT safe, plus probably try to hide some of
the exposed internal structures (rte_pmu_event_group, etc.) inside .c
(to minimize surface for possible ABI breakage).

> --
> 2.34.1