DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Julien Meunier <julien.meunier@nokia.com>, dev@dpdk.org
Cc: stable@dpdk.org, "Liang, Cunming" <cunming.liang@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/pmd_perf: change the way to drain the port
Date: Tue, 8 Jan 2019 17:33:10 +0000	[thread overview]
Message-ID: <9a3766ff-80a5-5620-7c86-d9e48661c89b@intel.com> (raw)
In-Reply-To: <20190102155535.29488-1-julien.meunier@nokia.com>

On 1/2/2019 3:55 PM, Julien Meunier wrote:
> If the port has received less than ``pkt_per_port`` packets (for
> example, the port has missed some packets), the test is in an infinite
> loop.
> 
> Instead of expecting a number of packet to receive, let the port to be
> drained by itself. If no more packets are received, the test can
> continue.

This looks like fixing the test_pmd_perf test case, which can stuck into endless
loop without this patch, and since there will be already a new version for below
comment, can you please update the patch title to describe the fix, like

test/pmd_perf: fix ....


> 
> Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
> ---
>  test/test/test_pmd_perf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/test/test_pmd_perf.c b/test/test/test_pmd_perf.c
> index f5095c8..286e09d 100644
> --- a/test/test/test_pmd_perf.c
> +++ b/test/test/test_pmd_perf.c
> @@ -493,15 +493,15 @@ main_loop(__rte_unused void *args)
>  
>  	for (i = 0; i < conf->nb_ports; i++) {
>  		portid = conf->portlist[i];
> -		int nb_free = pkt_per_port;
> +		int nb_free = 0;

'nb_free' is not more used or required, it can be removed completely I think.

>  		do { /* dry out */
>  			nb_rx = rte_eth_rx_burst(portid, 0,
>  						 pkts_burst, MAX_PKT_BURST);
>  			nb_tx = 0;
>  			while (nb_tx < nb_rx)
>  				rte_pktmbuf_free(pkts_burst[nb_tx++]);
> -			nb_free -= nb_rx;
> -		} while (nb_free != 0);
> +			nb_free += nb_rx;
> +		} while (nb_rx != 0);

Isn't there already something wrong with this logic? It assumes after test done
device still has 'pkt_per_port' packets in its queues, it tries to receive and
free them, but:

nb_free = pkt_per_port = MAX_TRAFFIC_BURST = 2048
RTE_TEST_RX_DESC_DEFAULT = RTE_TEST_TX_DESC_DEFAULT = 1024

When device queue length is 1024, how it can be holding 2048 packets? So it
can't exit from this loop. Since this should be working, what am I missing?

But overall, this stage is after the test done and for cleanup, I think your
suggestion is reasonable, only please check above 'nb_free' comment.

Thanks,
ferruh

  reply	other threads:[~2019-01-08 17:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 15:55 [dpdk-dev] " Julien Meunier
2019-01-08 17:33 ` Ferruh Yigit [this message]
2019-01-08 21:16   ` [dpdk-dev] [dpdk-stable] " Meunier, Julien (Nokia - FR/Paris-Saclay)
2019-02-03 19:42 ` [dpdk-dev] [PATCH v2] test/pmd_perf: fix " Julien Meunier
2019-02-07 12:28   ` Ferruh Yigit
2019-02-18 11:25     ` Meunier, Julien (Nokia - FR/Paris-Saclay)
2019-02-18 12:28       ` Ferruh Yigit
2019-02-20 21:06   ` [dpdk-dev] [PATCH v3] " Julien Meunier
2019-02-21 16:46     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a3766ff-80a5-5620-7c86-d9e48661c89b@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=cunming.liang@intel.com \
    --cc=dev@dpdk.org \
    --cc=julien.meunier@nokia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).