From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D60C3A034C; Wed, 31 Aug 2022 14:53:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D0B040F17; Wed, 31 Aug 2022 14:53:56 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85]) by mails.dpdk.org (Postfix) with ESMTP id 112DE40395 for ; Wed, 31 Aug 2022 14:53:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kl01WufRPQX6L83W8sB7k3lvjOhfrQXSALhlfFIvr7gibOCMY4q8MBBNG3hgrgdtu+zweOMS4wDm8zJ04E5Eb1YNBNMpTgy078UVd/KPQhc/BzZfwa69mJN2Tal/yThIgpXm6DHFOo4Y4HEkaU9C2TKX6U2yIaqYTVwqDoglhIEPePcagw7t1lARLTXcw7kpEL8/T7ChI9BGLdhg7pFVkF9uwDno+HeFHmgYgvCaPuvtv93tpG0ymMpQMtj0h3NWCb+qCCTpwI3o/vcDkIU6sEXLyl6twYmPBrxxbwxon+WdL/Tey2eSlf686n8HEmn+qWAGA3bFk3+nsixoEU7/kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nAHnS3Jq9TDR3Uyqai1swAuzgozufFHUdDfRrBFUCGM=; b=GirSJn/UPutPKmYpHozSCB2/7fHDyT/w1JTwh0xASO6XGHTMep6//qJweuQmaeiFxakS0x/SGnJ9i3EY8MF4KtWyPH30KMqLGdcxCht43VhPM6TQxNafsESycThXN4+aTli6ZJOdpkOmYr51VAbYJALjZRDGswCJIiN37deGtqP7nrCrN22fM47Om+NXtAnnAD+VXewoHRZtW+D5Q7rts62Duws7o8rmxk3wjmG1Hi/CKcURUwyy8PEuzbgjQSomV2/3nUjZ559b+SaJC99adBUlV9MhgUG0lTEv1b96WzkMGvSANs8NlvR7doqEessFUHQr/AXWlWXftOgZk2dwrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nAHnS3Jq9TDR3Uyqai1swAuzgozufFHUdDfRrBFUCGM=; b=S2GKGlttYVD9kUdgn5nfZp6qjBVzQcOLyEIKl70i6HrjS0DqNeAPNMzH4ofEWC4cQdCAhDy/KsHeZBTMfDZE0/7qNh9JEJ+QFBS3GKh1LoYO+0HbwmxTMJXUqRiXcyMtmcEwS/437qiwhJtTHrNlMb+zZBrGHQU3EU0uLhl1r6c= Received: from DS7P222CA0022.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::25) by MWHPR02MB3232.namprd02.prod.outlook.com (2603:10b6:301:64::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 31 Aug 2022 12:53:51 +0000 Received: from DM3NAM02FT060.eop-nam02.prod.protection.outlook.com (2603:10b6:8:2e:cafe::38) by DS7P222CA0022.outlook.office365.com (2603:10b6:8:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11 via Frontend Transport; Wed, 31 Aug 2022 12:53:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT060.mail.protection.outlook.com (10.13.4.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Wed, 31 Aug 2022 12:53:50 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 31 Aug 2022 13:53:37 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 31 Aug 2022 13:53:37 +0100 Envelope-to: qi.z.zhang@intel.com, jie1x.wang@intel.com, dev@dpdk.org, qiming.yang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, stevex.yang@intel.com Received: from [10.71.194.74] (port=63233) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oTNDs-0005lk-OH; Wed, 31 Aug 2022 13:53:37 +0100 Message-ID: <9a58149a-aafa-4d74-b5a3-27627d283c19@xilinx.com> Date: Wed, 31 Aug 2022 13:53:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 0/5] support flow subscription Content-Language: en-US To: "Zhang, Qi Z" , "Wang, Jie1X" , "dev@dpdk.org" CC: "Yang, Qiming" , "Wu, Jingjing" , "Xing, Beilei" , "Yang, SteveX" References: <20220809062122.1203281-1-jie1x.wang@intel.com> <20220830180514.693175-1-jie1x.wang@intel.com> <99638187-2ad7-61f9-5db1-4c5b54e33a07@xilinx.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 82e0dc15-9fb0-4853-b3f7-08da8b4fda2b X-MS-TrafficTypeDiagnostic: MWHPR02MB3232:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h0KBjtTw5i2UXEwOfhMdGT1MQ/okc207mV1zC10xI51pS+Uoa/OEP4UzzcdpEtfYEc5tpjqVySYkQrjs6R4hNmtlmypXNQufb+PM5e67GC7vvfRUnu7vY5v0cMzPZ8cO9nnH0OYNoMz9cZqVrnStaDyAu2hzuSsIxOFiFRBUn+Ft8vbu9rk/ZGDpCs7JUo3ODOLwEalU4G90oX/89eQzOMmxYkMqttmQJr4cVJ9RoXRSPq3ypJxeW/ExjBm+dHRYbiRyX8R8PL4bu7+5+kWB19/RMI3Vmr8z5l0yb/OLs3LkPVsqoz2AW73YSN0gzmebZdhijx/Q76Cg3Rw1LSzsgcIoROr3qyJZKUyKgyeQPDuIS43+eqsm56TWmHklmgj9XCVvzSnEkDJ1WaejVPf/1VBpIkRQ99R7gU/diWTWAaif/jgiM4XopdwIGU7+8E9j/sZl3fL6TbOyOeNm/D37aZtrVNqW5UanD8WqqFoK6a6IUvIUaFrD+8TZkn3vN1fR/k61RvfipxsZIwbEYV+6q8V4iOUCZRf53ouPEQEvBKz9OdFtZz9t6DLgC3irpnc6ZouPuj7n4UYkXDfLQ0Amp4713Fcijg+9itoukvmvIgaGdPyvZuxVHIdX3sk5LAEHYE06YBLV/RUwveMWZe2Wc2DA4xdwYPsy7BfhG5/hhvrDMoGPek8/vJ6Ps097oBcpRyOlUtYKGXLjqUt8rWX9a84GXhA/WC7mRXBqlEWVDzUckIpNdJcdJ+Ke1YcOav1TiodZLqOKYQZAhBhMFiWNwnejy8/DQR2xpLQmWFUDYZ+utgBEJFFlUkOMgtYiWXbcLFM9Du89GMepVo4Pkrdk8Q== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(40470700004)(46966006)(36840700001)(41300700001)(26005)(478600001)(70206006)(54906003)(316002)(110136005)(82310400005)(31696002)(36860700001)(53546011)(40460700003)(82740400003)(356005)(83380400001)(2616005)(336012)(426003)(9786002)(47076005)(44832011)(7636003)(36756003)(31686004)(40480700001)(186003)(8936002)(5660300002)(8676002)(2906002)(70586007)(4326008)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 12:53:50.2977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 82e0dc15-9fb0-4853-b3f7-08da8b4fda2b X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT060.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3232 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/31/2022 1:28 PM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, August 31, 2022 6:57 PM >> To: Wang, Jie1X ; dev@dpdk.org >> Cc: Yang, Qiming ; Zhang, Qi Z >> ; Wu, Jingjing ; Xing, Beilei >> ; Yang, SteveX >> Subject: Re: [PATCH v3 0/5] support flow subscription >> >> On 8/30/2022 7:05 PM, Jie Wang wrote: >>> Add support AVF can be able to subscribe a flow from PF. >>> >> >> Hi Jie, >> >> Can you please provide more details, what does subscribing a flow from PF >> mean? > > The answer is in patch 1/5's commit log which would be better in cover letter also :) > Hi Qi, I checked all commit logs, but the feature wasn't clear to me, it can be useful to elaborate more. Is it the case that: - PF create a flow rule - VF subscribes to this rule, which means - Packets will be sent to VF instead of PF If above is correct, will both PF and VF receive packets, or only VF? Can multiple VF subscribe to same rule? Can PF destroy the rule while VF is subscribed? How PF can prevent subscription to some flows from not trusted VF for security concern? ... >> >> Thanks, >> ferruh >> >>> -- >>> v3: >>> * fix eth layer inputset. >>> * rebase. >>> v2: >>> * split v1 patch 2/2 to 4 small patches. >>> * remove rule action RTE_FLOW_ACTION_TYPE_VF and add >>> RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT. >>> >>> Jie Wang (5): >>> common/iavf: support flow subscription >>> net/iavf: add flow subscription to AVF >>> net/iavf: support flow subscrption pattern >>> net/iavf: support flow subscription rule >>> net/iavf: support priority of flow rule >>> >>> doc/guides/rel_notes/release_22_11.rst | 4 + >>> drivers/common/iavf/virtchnl.h | 104 +++- >>> drivers/net/iavf/iavf.h | 13 + >>> drivers/net/iavf/iavf_fdir.c | 4 + >>> drivers/net/iavf/iavf_fsub.c | 745 +++++++++++++++++++++++++ >>> drivers/net/iavf/iavf_generic_flow.c | 40 +- >>> drivers/net/iavf/iavf_generic_flow.h | 2 + >>> drivers/net/iavf/iavf_hash.c | 5 + >>> drivers/net/iavf/iavf_ipsec_crypto.c | 16 +- >>> drivers/net/iavf/iavf_vchnl.c | 133 +++++ >>> drivers/net/iavf/meson.build | 1 + >>> 11 files changed, 1046 insertions(+), 21 deletions(-) >>> create mode 100644 drivers/net/iavf/iavf_fsub.c >>> >