From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D71442C4D; Wed, 7 Jun 2023 13:38:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F289427F2; Wed, 7 Jun 2023 13:38:01 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) by mails.dpdk.org (Postfix) with ESMTP id 48877427F2 for ; Wed, 7 Jun 2023 13:37:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=liB88MpVbQ/gd3p8lyq9neQ8AQC+/DgFO791YKYnBphYpXeiu7Y1cdVpSsVUgI8XjTGrtPUzxzinYXbsJG7k1C0xou8PvkWyGETQMAo0RbRLtTRWNQ2l7fO7AcFijW0X6LeZCruExMe4KIF5A+KxyK/HatYkg9UXMKOavVqGXMdXKjLHtj2KHo6ujMLWuCEf9XgA8y6Wj8zD+0WiHBdhMq/GqbOa00ifeYz3zbDmE9Ho+GqGrQtxBmYKvJVDqxcJTYG46SYC4bPekjjPTgr4PvKvG3dYGS5W/QRDF0eGGrIpcbBWlMRDp52UzGsOyw07Vm63pOJwtWBRZvRry/R+VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eYq7yOilwEcCe7TgiZ1S2FQK0QlR2pW/Oqg2a2a8N3c=; b=LYYQuRUjMGF6CGtqLX8z6nHhHYd09kGVvubWVZSegkssjus8xD4L8cdiY8zJ85RFn4R5b3XaufyZBxqF+zp1fjhhW2olvGAV7qq20EMwv4eLvLakfeKlxmxcE1ef2kwUZvKvMSC6Ty8enPzb7KFrticE+xgrepK/GyditE1l7z2lbDkI3YIZYfY1VimfZ+MUPP0mqEjeJ/N7LKbWGyngKBb0D5yrinX8QELV5VR3msM8K+VaQxqdIkQvSdsGdPrHwbdVs1ersmIjUPj9ji13BoIAc6DTrW13KQIF2ReWCUiHQCFpwQDUzrq1voX59bH6IpfvEYuF8qGHkpnow5ROHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eYq7yOilwEcCe7TgiZ1S2FQK0QlR2pW/Oqg2a2a8N3c=; b=bsamJsTFJZosbo0/k7bqRlHFjDcEH+glfcK01jOYfeiZ14E/Unt0Zns0HFptLVfeq/mW6VaCStrFrQtPX1XEpVmSUHoYqD8adxon/whvYMWKDIww0HD3B4hSPJBE59E5LYXkydLyUEwYc/Gu7kJl5JDozfw6Vgh3HZrOKf/F/6Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH8PR12MB6914.namprd12.prod.outlook.com (2603:10b6:510:1cb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Wed, 7 Jun 2023 11:37:57 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::3b9d:9ac6:f3ce:e106]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::3b9d:9ac6:f3ce:e106%3]) with mapi id 15.20.6455.034; Wed, 7 Jun 2023 11:37:57 +0000 Message-ID: <9a7832fe-df4f-caf7-c227-1cecea15da7e@amd.com> Date: Wed, 7 Jun 2023 12:37:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Jie Hai , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, liudongdong3@huawei.com References: <20230530090510.56812-1-haijie1@huawei.com> <20230607074209.4798-1-haijie1@huawei.com> <20230607074209.4798-4-haijie1@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH v2 03/13] ethdev: extract codes parsing port ID as a function In-Reply-To: <20230607074209.4798-4-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0110.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::7) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH8PR12MB6914:EE_ X-MS-Office365-Filtering-Correlation-Id: 97382d06-ce25-4799-cebe-08db674ba3be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JU1rVKmOagFiG6/ytO6Qfb8x6KGQx80Bn8//dm2r3B4xkPwlHSRNw1eSbFJwBGgJ4tIuAJ8nweyW/6ZBldyuaE22Jr73FGpAKq8p5dFghZqV2sLwp5zjfEw4W0c7RKzJKCg+4GO9dNAzIhVkh5/1eIpzl1cqz+xshX5rDjtVoKoF3sPKcEeUWTf9YA+bAoHi+Q16J5XQuLhEcdrGf0Bx2wKa4y2+FMbbuEuurYv1XlcO6Gf2t0oZn/uCqUldYiQJs+YuBLwZHu7bArRkIAjn//83HimNc2lPOGe3Gg9TN2WsNwcPZgIaYsxlo+ZcJC1EZiS3S8gFaW/9Ol+qfMN/EWxLc+9dt6VmM7kDaimgEgbqpsrqyJmvwnqE0S4Yu+tQqaifFUzF5Xbm2KNCL2/fe1TCnwTC93p8eCcm/pzlHBDludN14pDuiXabPvX7vbuNiFlSHQYJT9ESU9X6QSArakL/Y0w0LFfo9TvafeUHtOJ+nkikz6t8sf5R0XjwqT5/PWsz2x/NOD5iqlwQD5a4yrtLaMbtYonlssowWSbjltWI6wTHgC71N+TNelVMlJUQM9/AH/J0SKvdSfE02AiJHWPm32aCTgrFMLioqoqIolxoN6BVzUAvr0cJ+t/rk7PgaoCgqNGGCFzX7aHeAEPGpw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199021)(36756003)(41300700001)(186003)(26005)(6512007)(6506007)(53546011)(5660300002)(83380400001)(2616005)(8676002)(8936002)(110136005)(478600001)(66946007)(66556008)(66476007)(4326008)(316002)(6666004)(6486002)(38100700002)(2906002)(86362001)(31696002)(44832011)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVNwV3FwZ2J1cmsyd2NsRDEvSnpVcGRuTUl1VlFNRHRNcjAzd1JSMGVCUUtl?= =?utf-8?B?aEdFSDdwdnhFRThiSE1qMlJNL2NJcnYrMDRoNklDOVBMLzFhcUJrNlBPaTFy?= =?utf-8?B?cGRHa280amJEL3IrMDkxNDNBS1hpS2d1bnFxeXRTclUwc1E3M0pWZ05GL0s0?= =?utf-8?B?WHkxM1BHRzgrWnVRUHhBU3dPZzJvc0RpajF0VXRYcVRJdk1LbTlrR3BjQzhL?= =?utf-8?B?L01EMEozR2xsQ2MxdEt0RXlJUVllcUREdlNmaGdqZVZvcll4RzJ1dCt0TFFj?= =?utf-8?B?L1JxcWkzUEw3SHp3NllmSnNFN2hHZ2hocEdZNTgrNy9rekZBVElDNTRLOFRI?= =?utf-8?B?QnUrQ0hadUNYRlhuL3VjbUF1UXM3RGVPOFFydlYwTzM1ODhPWnpKMlFhU0Qv?= =?utf-8?B?MThqdkRHNG02TEFMOHhZY0d2UFNFdFlsOExPTmt1NXVCVzVUajFoVmFBR3Js?= =?utf-8?B?Qm4xK1RBWDRhWllETDVXTy93WGthUnd0QmVQN1U0SGEzL0h0anNWYnMyUjVI?= =?utf-8?B?WkZzZWhldmhwZEJSU3VGamdiNlRuUXRPSGc0WW56OXpIL3NacVRsc1dEQTQy?= =?utf-8?B?S0VGaklnZUkvRkhxdXhKcE1oYS81Nmkrc3Z3cEd0bEV4UHZCNVE2L1dwbXJO?= =?utf-8?B?aThIejMzU09MdUE4RCtqTXZsQjdNd3lvejNLbmVaM2ZWOVlMVXl3WTRyQWxQ?= =?utf-8?B?U3pBaUxCbSt6d0hiajJOdVVTMWRrUlRmUVYra2lQSkFaZmNjSG9pS3oxZXYv?= =?utf-8?B?akxYdU1rNFJZTFcrNTNObXhxUXNQZmJpM2hsOGphTkJsWUxwbFlweDRhTGFj?= =?utf-8?B?SDcyY2k5eENvVVhhaWE2aHZFcVA2cFUvdFM1VE03OFRrZXI0dDNHRXBFWW9U?= =?utf-8?B?MTNoK1UwaWJhOGJ0MWtBZ09aQnNzWVhFc24ya1dMUTlzM2RPa3VIdURKR1Z6?= =?utf-8?B?Z0ZNQ0t5VUxieWJ6Y3dabXRjdjBLUk1QNkZmL3l4RE1EalgrbHNxZGYwL2pG?= =?utf-8?B?RVd0S0N4Q21pUjZ5M2VVTERHQjhMY2xhWTAxeGxTY3MwWE9kSlNsRFFIYXI0?= =?utf-8?B?NTIwRUx0Mzl0b3VoYVl0eGkrRG1FUVZaUFJPYXFOcWRJdWxxRlN2aFkzci9u?= =?utf-8?B?bTBTdTZQajVsL2hSbjdQdEVrTnhCT2tUenQva1hGUmVPYlVCNG1vSGJUWjlI?= =?utf-8?B?c1IrUWNYaUZiVlErZVFkdTBqMy9jOXJEQ1l0ZGphM1NxME5iVnI2NmNzNjFC?= =?utf-8?B?UWdudlJJbENWTENiNndjVEMrTUUxWlpPY2M5bnlMVmdmTkJUMWJERXliN0xY?= =?utf-8?B?elVQNFFoSTRsS29BK3VycnlSS2N1V2NmSWZBbEhLZ2pIT01yQTR5OG9LNWhv?= =?utf-8?B?RDJWb2phcGM3akZnM296ekJxUW1HM0EvUlhXM0RIM2JPZjg4OERxU1puTy9k?= =?utf-8?B?emFIcUJ0aGZtZjJaT2Q0aDQyN0JCdy9Ockp2cnJ0RFh1SU1uVlNpL3hSMmVC?= =?utf-8?B?d0NOMmhUclhXOXNZVTFUdXNHTWMvUmUxbWI2ajd1NU5uY1pLaFZQOS9LRVVn?= =?utf-8?B?aldENmNuMmZyWWthOUV2MDc0eUR3RVJZak4zZzdkbzZCWDYvVjMvb2NNNmwx?= =?utf-8?B?MjBWUDdua3JGTTRpMndYSkVHdWlzU29RK2NtU0tGbExrSWV0bVBhcm1sK0kr?= =?utf-8?B?K2lneG1mMmxhQmgwdkxmYUdBaXJxWHNlMDBPcmU1UHpDL0tBdzB3Q1ZIYUtr?= =?utf-8?B?MHEyY0dCaGxHSUJXNk0xNFlwdExmQlRxNngvZzh5S2dUM1E3bEh6SmpXQ2hI?= =?utf-8?B?WTlzdVRkRWsxSEhPL2hiWXZrZzdBTkFGbi9oOWs2UW1hSWxEQlJUMk1rTndm?= =?utf-8?B?SjhMU2JxSytjbWlseTlaKzl2MDRFdElUSUQ4VUhZVnUxMjA5R1NCM1J4bzd2?= =?utf-8?B?WFFMcjVpRDRBNGxlc3VoOWREcUwvaFJEYWlObnlmZ1NSZDJJeWFFb2JsTmdN?= =?utf-8?B?ZUx2ZjA2Z3N6TTMySVlUeklkSCtNNEtHSEk3b2J5ZW5qYXRQelZ4OXVYWWhk?= =?utf-8?B?MTcwaG9CbndkdkNFNmNCeVNid1oxYTJWZnhYS0tpMVRiVk9kbjVhbW9uTTRa?= =?utf-8?Q?E27YaR9cIg6xMUOP08zUQiBZ+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97382d06-ce25-4799-cebe-08db674ba3be X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 11:37:57.1888 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0/HyogJJpsrUee/GooiPVRxLWq63cPr3x+jr8tKlfKgJ0ngilfs7Kv9QvWGZdhEo X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6914 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 8:41 AM, Jie Hai wrote: > This patch extracts codes parsing port_id as a function. > The port id of 'int' or 'unsigned long' type passing as > 'uint16_t' may cause truncation, fix it. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev_telemetry.c | 95 ++++++++++++++++--------------- > lib/ethdev/sff_telemetry.c | 4 +- > 2 files changed, 52 insertions(+), 47 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c > index ec8e48877187..5e70d0c2a66a 100644 > --- a/lib/ethdev/rte_ethdev_telemetry.c > +++ b/lib/ethdev/rte_ethdev_telemetry.c > @@ -11,6 +11,29 @@ > #include "ethdev_driver.h" > #include "sff_telemetry.h" > > +static int > +eth_dev_parse_port_params(const char *params __rte_unused, uint16_t *port_id, > + char **end_param, bool has_next) > '__rte_unused' is not required for 'params' > +{ > + uint64_t pi; > + > + if (params == NULL || strlen(params) == 0 || > + !isdigit(*params) || port_id == NULL) > + return -EINVAL; > + > + pi = strtoul(params, end_param, 0); > + if (**end_param != '\0' && !has_next) > + RTE_ETHDEV_LOG(NOTICE, > + "Extra parameters passed to ethdev telemetry command, ignoring\n"); > + > + if (pi >= UINT16_MAX || !rte_eth_dev_is_valid_port(pi)) > + return -EINVAL; > + > + *port_id = pi; > there is 64 -> 16 bit conversion, there is a "pi >= UINT16_MAX" check already but not sure if all compilers get it, better to add explicit cast for any case.