From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8211438A4; Fri, 12 Jan 2024 16:06:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7B4040633; Fri, 12 Jan 2024 16:06:21 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by mails.dpdk.org (Postfix) with ESMTP id BB5AF402AD for ; Fri, 12 Jan 2024 16:06:20 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TgrVvMAGj4cOdV3J1zSchoijiLe5Lznbp5WCVF8VNCB/gSUrnDqKFFGDrXeHNe4bOGA8vW0w3UhYC3PrtyLeI+iovwkxn8a3T3Z4/HOfA6Z9ppJHR4qsX5BdJ8bfiemmEfM5tnmzMZqwj3N/jLW8dBUwTW1cPZD4AFjiNobDBzHqGuQEML911Ti9WS0TCZmoFjuSRTyQdzgH0vE1DRJg6Y3u9YFtdty2GrZSHr76QBLwihix+cC18qrI5gQrVrergrHkdOyw6rqo6T9D/JS73ZQukJRdfP/E3nwckZm4tcePVAgs4gemT79Ud6f7ZosXx/wI0stLVvFWK/vVCxVFcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3yquTV6G/1Hjev5BPmAVqO5N4e7cJnNPPZaX0xNs4Ec=; b=cdy0Ebx8FvG13U7qkgYKT2HruCy9ifTFTlaTc7xtxIKBr0t/NkITB8wIhFjxuc+/m5r4Uvj3wVvQksoOYA2sBOl92zdGGcjSVn9QfVCPpCfWA4Xxh1v1o6czTp/yZDocJoALN1NMqaepDX5sVX3HwBLGOmow8EFqhbeA4MG3GQPXfD3sgRsrDejOLZdhq2FJT8heeZ+73PCwp0HNXyJ5KBaYDV1nk75oPTgY2U10vhvfv3Az07dQXfPjnRyATMG4AWy2DOKKNnPdg1+6m4JJlHG4h3OVQy0J/cii5RvwSC1plOiWFJM4dTVXZg4XgF6hXr9ggiOOKHt1HgjJCGsH6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3yquTV6G/1Hjev5BPmAVqO5N4e7cJnNPPZaX0xNs4Ec=; b=LgR3Gmjg9QV19eoMkDXHFYmWmaNJvQWO7XBFQrCjYqV5tVXQX2UHEqNwA6/AL1azbfXr580D++naxSRMsBh1A3OTin3ArKS2QLNEFSGIX4fiuVKKTtdL++VxgnyIrCiuuU/axS5Itng5JaT8Wxj/Vpc6prAwXXruHncF8dURycQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB8242.namprd12.prod.outlook.com (2603:10b6:930:77::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.24; Fri, 12 Jan 2024 15:06:18 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7181.018; Fri, 12 Jan 2024 15:06:18 +0000 Message-ID: <9a9e3d4c-f0f1-4192-bd92-1b4a7a2c9c20@amd.com> Date: Fri, 12 Jan 2024 15:06:13 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/gve: Enable stats reporting for GQ format Content-Language: en-US To: Rushil Gupta , junfeng.guo@intel.com, jeroendb@google.com, joshwash@google.com Cc: dev@dpdk.org References: <20231222153953.1266615-1-rushilg@google.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231222153953.1266615-1-rushilg@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0231.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e9::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB8242:EE_ X-MS-Office365-Filtering-Correlation-Id: af197040-530e-4792-0588-08dc13800728 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VvV0H47H1GxGhnXkwxyFVzW59ySH2T1aF+ZeSjETi1/Manm+uTHT2CMtJ9eXm/iv4p7wbIGe/1baEcYCVHQNp+reLGD28PjmXiu+vbPJgMgcvsdGS9pBL41QFK40z3mGUQd/p/hE7Aa0qctd1UdLOK++LGQG8eRPtVQZYXNZQEmlCQ2IbRUpzxMibVRzlCxON1qNYSTVHgfFOwH1v5hQ5+fzxovj+gSAJ9zgrfdcxVqSF8g/zCm+uvBVK7UYrzyjRfddywVeYBaQDPxtJbeijHPCvYK7WxvFDOHgVRNWWbZ9SvqbUUweZpKB6Qpu0NA79gGM+CDg0Q0x7z28xGyBAwVvdeLCo6nMiG5ySoIJulvUIAW4rTbJUOrzWxU/1rrmFkM+HpFEsJpKESP9jKUXmXMvUyb0Cc5fzTMQ/aNfOyxMk8gzN9GgYZo9hJ2qq7/tKiDZD91bA1ymvP3DkGmXLMqOYRU+VHlz/Z9MGVu+Zpw+cc9Y0a/pin+1PRClPsFNFgZsic7ECRAsIyh+gVuRf/UQnDK6OT5+y7MXRKnBP/YX7RTxOjIZ5Ezn2JJXYLQIdUEIXVKGDM4dHecyjuOWP94s9+VKutv1tc/6bQKgCZSbz9t+fcwTNU4h6w7vJtlNWcZLOW9gmGAwdklXhIY3nmNGqIAUjWFKytuSeXiV5RPC0VLol7/7Ag5s86+ZYHgp X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(39860400002)(136003)(346002)(366004)(230173577357003)(230273577357003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(38100700002)(6486002)(83380400001)(8676002)(66556008)(44832011)(66476007)(2616005)(8936002)(31696002)(31686004)(316002)(36756003)(4326008)(66946007)(53546011)(26005)(6512007)(6506007)(478600001)(86362001)(6666004)(2906002)(5660300002)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGZhZXRKQldpSUIrMDVtYS9SbnhmSmgvVlBBZkVTOEM1dG1mWXQrWmdqRkdM?= =?utf-8?B?bkhtY3hxRkNVTTZ1Z0VId1dPdzdQZ09xWEpUaGNHRGE0RlBBQ3RqbDRmQXlL?= =?utf-8?B?QlRZbkNYMGVsTzJyUFByd1IvazQ4Vlp5QndxSXZLMmQ3NjE4TjlSRkhpL2tM?= =?utf-8?B?QlJzc2RJN25LdG1iODlDMW9wTmN0R0M2ejUzOXc0MUNNc3pqTWcxMU9odStt?= =?utf-8?B?WjZHS1pwN3R6Rk5yUUxCTjZuS254aVppVVErVEdNYzdhZGJWbjZ2SE1ZNEZq?= =?utf-8?B?WW5Fd1l1Ylpxa3I4OHNSdVNycHl4MnZyZERVdCtzQllFbDlXUzRIelYvN2F4?= =?utf-8?B?dzVRUkdmcGtXR2d1TlRreEdqc3c1TWVwRUh1TjZPeVhXaG9hZnV1UDViTkpO?= =?utf-8?B?YlVtbVRXUitMYjRrSEVWK2V1Z0lDZWgzcFlUNVBqTHRmWXBXaFZTaXFNeEdj?= =?utf-8?B?YnZMV0dYL0JDeXFWMFBsN0F3WFVDR1hYcmpHcHhDV04zcmZTdTR5SkkrMFBm?= =?utf-8?B?WnR1VTdLRkl6YXF1QzBVTDlXVkgzVzdBL1JPZjYwUk9YQ2w2V3VkQmlKMlhK?= =?utf-8?B?bUhlZTFwVWk1NTdzTDRIbVd5WVUwMkNMaU1jU1lpdUtuTjI1c211bW5GNnhl?= =?utf-8?B?M2JmUU9OR3J1Y1g1aFJhWTZVNWRMWTl4d1ZzeUpLYXFIWWNROFkrSXJjUE1L?= =?utf-8?B?cU5yTm90czdtL2xzV1FQKzkrOW5YTC96ZmJjYjJvd0U4ZW1DUlNCV3BKM21w?= =?utf-8?B?b29WMlBUdWsyNGxRNVlkWnJzdW5yVTBEa25JWUoxS1I3bW1SQVROcXovMmdC?= =?utf-8?B?OUhuVFYvUzdnRUlmTzZCb3R6RHpDdVMzVS9vclE2UXNCcmpveDJCek84MlZ6?= =?utf-8?B?QXFTY2IvdElLMXh4eTdsS3VHL2dwL2IxZzhvOVZOa1duL1BHenVvN0ZIbkRj?= =?utf-8?B?ZjF4N1QyeDJ0YVV5c2JxR0FFak1QVllaSUdRZmlLSk9hbm1JR1pjU01QM1RI?= =?utf-8?B?bWdNYy9pR1JuSFdEZ0RuaUo1VDJwallYK2FUejE5d3J4T241OWNqcmxtUUp6?= =?utf-8?B?T0JwelZTZyt3QkRhN2p6K2lMMWNIYmo4YXpIRjlyZ044UW5IZEdqek1LTjNn?= =?utf-8?B?VWJ3a1phMUdnQUJ3QWUyWDJqRmFCMDlPNFpySGt0SThJZzhZNzFKMEpvUGdj?= =?utf-8?B?U2w3Z3VlNHJzbWtkc2pqVUtHb3VJekd3Tk5wK0tJU0t1NFZvcnlmNVNycWQv?= =?utf-8?B?OWxUY3VjSHVNcDZ5WnBxSmVMVVZCQ1NxbCtDV0hQRitUbUdzbmEvSGJncU9z?= =?utf-8?B?VUNmbnpwS1FvazZOWGhJSVVLWEpDQkM3Z3dXYVk2K2NFbzJ5K0tlVXBUT3NN?= =?utf-8?B?YjVzQUNpNmdQc0FRS2dYTUE3alpMME52bG9rNkVWZlM4SnFZeDdXNEpEYTUz?= =?utf-8?B?MUZVZTlabjFNL1dXUnVXRWw4eWR2ajRYdzV4OUdCMGxVZW5hMldwakFrY3Rw?= =?utf-8?B?cExNcUZSc082ZE1OL1BheUdHdHN5b2pzaWdXVUM2VXpQZ1hMejlRckErVnhu?= =?utf-8?B?OGp1amFqNUI3Y3ZCVEN4ZEF4bXpGMXIxU2hYVW45REZnd1QvUFVTQVVvb2lO?= =?utf-8?B?ZTFTa3E1a0Vrb0NZd29uejEvNUV6NC80L2h1aEdTcXZ0TitWaVEzTmNTcXY0?= =?utf-8?B?OWVxZ2psT0J4cGtBRysxMkJ1VzZjZExiYktLaGRBRTVROEsvbkI2UGFWMEVr?= =?utf-8?B?L0YrcW9qbXd6K3dSQXlIUThtbXlneUtpNFU1K3V0RXdUQnY0Zk90ZTNETURK?= =?utf-8?B?VDltdThZV0xRTnJxWTVTVTFEK1B6VFVya3VmeTJrWVZTbERZVEt1SkRJdlcr?= =?utf-8?B?N3hoeEJOWjFyYjZoc1FWSWF5SEhiTlBKZ0FNUG1DQStacjYxaElBR0pPYThj?= =?utf-8?B?THp0Ui83WGREN3FmV1pmeWlvWnVyNDR3Ym83UHROVXZTZjZ5RkU0RnM1akY5?= =?utf-8?B?MURiSU5qT2hERDBCR3JLSXVRRWR2UGZLMHhMeUZ6QnVVU3hSRTN6UzhPRjFx?= =?utf-8?B?MGlhL3A1TFB1TTM4V3lLTUJCdm02RmlRTHJONDhwS1FualJiUTlYUVVsUEYx?= =?utf-8?Q?QIuQ=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: af197040-530e-4792-0588-08dc13800728 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 15:06:18.0344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Ar8Q8ZoGoEO2qwfuzQZpdixtrq2y2JWslxzYe0BG59Ow6EUuipHLRkAhO7pWN15 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8242 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/22/2023 3:39 PM, Rushil Gupta wrote: > Read from shared region to retrieve imissed statistics for GQ from device. > Tested using `show port xstats ` in interactive mode. > This metric can be triggered by using queues > cores. > Looks good but please check following comments: Checkpatch gives warning on the patch title, and this patch adds 'imissed' support so it can be added to the patch title, something like: "net/gve: enable imissed stats for GQ format" <...> > +static int gve_alloc_stats_report(struct gve_priv *priv, > + uint16_t nb_tx_queues, uint16_t nb_rx_queues) > +{ > + char z_name[RTE_MEMZONE_NAMESIZE]; > + int tx_stats_cnt; > + int rx_stats_cnt; > + > + tx_stats_cnt = (GVE_TX_STATS_REPORT_NUM + NIC_TX_STATS_REPORT_NUM) * > + nb_tx_queues; > + rx_stats_cnt = (GVE_RX_STATS_REPORT_NUM + NIC_RX_STATS_REPORT_NUM) * > + nb_rx_queues; > + priv->stats_report_len = sizeof(struct gve_stats_report) + > + sizeof(struct stats) * (tx_stats_cnt + rx_stats_cnt); > + > + snprintf(z_name, sizeof(z_name), "stats_report_%s", priv->pci_dev->device.name); > Can you please add 'gve_' prefix to the memzone name, to prevent any possible collision. <...> > +static void gve_free_stats_report(struct rte_eth_dev *dev) > +{ > + struct gve_priv *priv = dev->data->dev_private; > + rte_memzone_free(priv->stats_report_mem); > What will happen if user asks stats/xstats after port stopped? <...> > gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > { > uint16_t i; > + if (gve_is_gqi(dev->data->dev_private)) > + gve_get_imissed_from_nic(dev); > This updates imissed in RxQ struct for all queues for basic stats, but what if user only calls xstats, I guess in that case stat won't be updated.