From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA50442826; Thu, 23 Mar 2023 15:50:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA48E4111C; Thu, 23 Mar 2023 15:50:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E1A994021E for ; Thu, 23 Mar 2023 15:50:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679583039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h2pqa+5BUgxG8LEqlQLvQ8fIoDhjEJ8mpA7Bq1j7ocM=; b=d62pirZzPb9ekHbXcJcGOIiW+Ayzh+W80ezqJ3s3OdXkDXas/Rwf9nXxQwmqSYK7+762vm 7BiGEvvsY0jeHTX39pvDpBfseCrxq+9x2fhKGS8sbJC0Jpw2Ca4J4H19+RDmFRYuCdJBCV G4JuSZ1WJ6Gmkyb0LZiXSxVnQY3lxhM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-H_FaKVSPN0mF59elBkSE9Q-1; Thu, 23 Mar 2023 10:50:38 -0400 X-MC-Unique: H_FaKVSPN0mF59elBkSE9Q-1 Received: by mail-wm1-f70.google.com with SMTP id r11-20020a05600c458b00b003eea8d25f06so119171wmo.1 for ; Thu, 23 Mar 2023 07:50:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679583037; h=content-transfer-encoding:in-reply-to:subject:references:cc:to:from :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h2pqa+5BUgxG8LEqlQLvQ8fIoDhjEJ8mpA7Bq1j7ocM=; b=3qGPyj8EKNFiVsH5PFyQsZHG0M2a8hEsL6TjmhlFtqLVdsuzwB74Ksskm/EmqdlHd2 nLholD4kiiQ2gpqTm9N/hjPrzypvZ8giVcbG2VsjmYRCOY1a2fMgZVtNhYxMCCIdYmEU jiZQar+jj23YmxcryBEP+LbUspEsWwsKfRdIO7KAjzhEwjHxnpvwHL5L+uwr/x6sr7ki wMK31kmIFHxW7eL2gJrpBSa6NG0GVQPacBwrg9i0QZWjOQgLqhkJwBcM0jSh/zeSAcj/ I/9nINfXCPRoPbYWUnMdkIACqr0lRcpntXYZUZosVcl1zSeeml5dk1GEJcA9DhR7zdV7 1gJQ== X-Gm-Message-State: AAQBX9cUeH8XdLM7AYQcHkGtv3UI2nyNzOpS5gFzTB52NE/yShj9cG++ GxTABVO07PskHptOOtw+X6z2F9nEFo5+jK5iZTNdTuycPQ8plu3Z8bhTkqFj7b1zvgWqkPwKWPy KPjE= X-Received: by 2002:adf:fd06:0:b0:2c9:23c4:8f93 with SMTP id e6-20020adffd06000000b002c923c48f93mr2509006wrr.57.1679583037160; Thu, 23 Mar 2023 07:50:37 -0700 (PDT) X-Google-Smtp-Source: AKy350Zg8LuhsSxsi2Qwjga6Y/MANkkFNFTvWtjftbutttkqkSGKuhTee0is2QbftvVy267GF7uIqw== X-Received: by 2002:adf:fd06:0:b0:2c9:23c4:8f93 with SMTP id e6-20020adffd06000000b002c923c48f93mr2508992wrr.57.1679583036921; Thu, 23 Mar 2023 07:50:36 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id b15-20020adfe30f000000b002c706c754fesm16346322wrj.32.2023.03.23.07.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 07:50:36 -0700 (PDT) Message-ID: <9aa3b88a-5e2f-d857-b554-d88a572b46b2@redhat.com> Date: Thu, 23 Mar 2023 14:50:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Kevin Traynor To: "Zhang, Qi Z" , "Su, Simei" , "Xing, Beilei" , "Zhang, Yuying" , "david.marchand@redhat.com" , "Jiang, YuX" Cc: "dev@dpdk.org" , "Yang, Qiming" , "stable@dpdk.org" , Luca Boccassi , "Mcnamara, John" References: <20230202123632.56730-1-simei.su@intel.com> <20230220075952.444153-1-simei.su@intel.com> <8fecda8e-15b4-63e0-f319-6e4a4a5edf83@redhat.com> Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration In-Reply-To: <8fecda8e-15b4-63e0-f319-6e4a4a5edf83@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 22/03/2023 16:50, Kevin Traynor wrote: > On 27/02/2023 00:35, Zhang, Qi Z wrote: >> > > Hi Simei/Qi/Yu > Hi Yu, >> >>> -----Original Message----- >>> From: Su, Simei >>> Sent: Monday, February 20, 2023 4:00 PM >>> To: Xing, Beilei ; Zhang, Yuying >>> ; Zhang, Qi Z ; >>> david.marchand@redhat.com >>> Cc: dev@dpdk.org; Yang, Qiming ; Su, Simei >>> ; stable@dpdk.org >>> Subject: [PATCH v6] net/i40e: rework maximum frame size configuration >>> >>> One issue is reported by David Marchand that error occurs in OVS due to the >>> fix patch in mentioned changes below. The detailed reproduce step and >>> result are in https://patchwork.dpdk.org/project/dpdk/patch/ >>> 20211207085946.121032-1-dapengx.yu@intel.com/. >>> >>> This patch removes unnecessary link status check and directly sets mac config >>> in dev_start. Also, it sets the parameter "wait to complete" true to wait for >>> more time to make sure adminq command execute completed. >>> > >>> Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level") >>> Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port level") >>> Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") >>> Cc: stable@dpdk.org > > These patches caused an observable regression in multiple 20.11 and > 21.11 LTS releases that was only caught a long time after releases. > > Is there anything being added to LTS validation for regression testing > this issue, so we don't get caught again? > This is the issue I was talking about earlier during the release meeting. Not sure if we were talking about the same patch. I was asking if there are some regression tests added/can be added to LTS validation that will be run during each LTS validation cycle so we don't have any more regressions on it. thanks, Kevin. > After reverting the original patch and 2 fixes, I'm a bit reluctant to > take more fixes without some form of regression testing in place. > > thanks, > Kevin. > >>> >>> Reported-by: David Marchand >>> Signed-off-by: Simei Su >> >> Acked-by: Qi Zhang >> >> Applied to dpdk-next-net-intel. >> >> Thanks >> Qi >> >