From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3BC7A460CB;
Tue, 21 Jan 2025 04:31:22 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2A42842707;
Tue, 21 Jan 2025 04:31:21 +0100 (CET)
Received: from lf-2-53.ptr.blmpb.com (lf-2-53.ptr.blmpb.com [101.36.218.53])
by mails.dpdk.org (Postfix) with ESMTP id 2EFA440264
for <dev@dpdk.org>; Tue, 21 Jan 2025 04:31:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
s=feishu2403070942; d=yunsilicon.com; t=1737430269; h=from:subject:
mime-version:from:date:message-id:subject:to:cc:reply-to:content-type:
mime-version:in-reply-to:message-id;
bh=lSNz2pl/zxb00zaHRS1G9ICjg6ccCE/hCeGGTEQp1iM=;
b=D5sboWUfDVcz3v0v+6ofGS8rq3TMHH8HxoxA12MMzs/zyHujIIcHvOQC/lX1aSh4mxWQjP
nFMXTi2a8sq1a/6Mvo1Adhqqdl0ZMovkTxJXBIxZ763BjNWQJVJXOS2AJhVrjeyuDyC+cC
Qq3b2ftT/VyD5+LKd+MMsEQ1K9T8Tjjlp1ojSHIAmyyPbUy3xNev1yHJ/BVKWiLzrm7iw4
nGMEcCPyFfZwU3lyXYelhfc0xraCvsp1ojjca1hXW2RY3tsW7asswNvIxrxWZFMNUADAOH
Sfm2gQT6VDiV0aC9ST75ACBQWEL0k8bmVy42B7a8zQm8BSrbX2JOT2gRD4OaQA==
To: "Stephen Hemminger" <stephen@networkplumber.org>
From: "WanRenyong" <wanry@yunsilicon.com>
Mime-Version: 1.0
X-Original-From: WanRenyong <wanry@yunsilicon.com>
User-Agent: Mozilla Thunderbird
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,
<qianr@yunsilicon.com>, <nana@yunsilicon.com>, <zhangxx@yunsilicon.com>,
<xudw@yunsilicon.com>, <jacky@yunsilicon.com>, <weihg@yunsilicon.com>
Message-Id: <9aa48077-d499-4e26-a588-b90e912ca00f@yunsilicon.com>
Received: from [127.0.0.1] ([218.1.186.193]) by smtp.feishu.cn with ESMTPS;
Tue, 21 Jan 2025 11:31:06 +0800
References: <20250120111431.1048479-1-wanry@yunsilicon.com>
<20250120111436.1048479-4-wanry@yunsilicon.com>
<20250120101924.5ff437c3@hermes.local>
X-Lms-Return-Path: <lba+2678f14fb+7ddb83+dpdk.org+wanry@yunsilicon.com>
Subject: Re: [PATCH v6 03/15] net/xsc: add xsc mailbox
Date: Tue, 21 Jan 2025 11:31:05 +0800
In-Reply-To: <20250120101924.5ff437c3@hermes.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 2025/1/21 2:19, Stephen Hemminger wrote:
> On Mon, 20 Jan 2025 19:14:37 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>> +static struct xsc_cmdq_req_msg *
>> +xsc_cmdq_req_msg_alloc(struct xsc_dev *xdev, int len)
>> +{
>> + struct xsc_cmdq_req_msg *msg;
>> + struct xsc_cmdq_mbox *head = NULL;
>> + int cmd_len, nb_mbox;
>> +
>> + msg = (struct xsc_cmdq_req_msg *)malloc(sizeof(*msg));
> Malloc returns void *, so cast here is unnecessary in C
Thanks for your review.
I will address this issue and any similar issues elsewhere in the next
version.
--
Best regards,
WanRenyong