From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B685D7EBB; Wed, 26 Apr 2017 10:15:16 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2017 01:15:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,253,1488873600"; d="scan'208";a="849934569" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.144.52]) ([10.252.144.52]) by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2017 01:15:13 -0700 To: Rasesh Mody , dev@dpdk.org Cc: Harish Patil , Dept-EngDPDKDev@cavium.com, stable@dpdk.org References: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> From: Ferruh Yigit Message-ID: <9aa7e885-ab58-00a2-a473-494b8dc05de9@intel.com> Date: Wed, 26 Apr 2017 09:15:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 01/11] net/qede: fix default MAC address handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 08:15:17 -0000 On 4/25/2017 8:28 AM, Rasesh Mody wrote: > From: Harish Patil > > - In qede_mac_addr_set(), in order to configure default MAC address we > first delete the existing MAC address before trying to add new one. During > init time, there is no MAC filter to begin with, so trying to remove a > non-existing MAC address causes a firmware exception. This can be prevented > by internally calling qede_mac_addr_add() which has the checks in place to > delete a MAC address only if it was added before. > > - Remove setting of the default MAC address from within > qede_dev_configure() since rte_eth_dev_start() calls mac_addr_set() anyway. > > Fixes: 2ea6f76aff40 ("qede: add core driver") > Cc: stable@dpdk.org > > Signed-off-by: Harish Patil Series applied to dpdk-next-net/master, thanks. Thanks for taking care of coverity issues as well as base files CFLAGS. (Mail addressed updated to current ones.)