DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ziyang Xuan <xuanziyang2@huawei.com>,
	Guoyang Zhou <zhouguoyang@huawei.com>,
	Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>
Cc: dev@dpdk.org, Qingqing Li <liqingqing3@huawei.com>,
	Hushiyuan <hushiyuan@huawei.com>
Subject: Re: [dpdk-dev] [PATCH]net/hinic: fix coredump when secondary process using the hinic port.
Date: Thu, 18 Feb 2021 17:54:39 +0000	[thread overview]
Message-ID: <9aaaab09-5fb9-5574-2f45-9d06d790bc12@intel.com> (raw)
In-Reply-To: <e799848e-4768-cdd7-fa54-e01bc8552830@intel.com>

On 11/11/2020 1:07 PM, Ferruh Yigit wrote:
> On 11/2/2020 2:48 PM, Qingqing Li wrote:
>> the reason is that during the stage of secondary process port initialization,
>> it lacks the initialization of "eth_dev->dev_ops".
>>
>> Signed-off-by: Qingqing Li <liqingqing3@huawei.com>
> 
> Hi Ziyang, Guoyang, Xiaoyun,
> 
> The patch is around for a long time [1], can you please review the patch?
> 
> Review has been requested multiple times now, not sure why there is no response.
> 
> As 'hinic' driver maintainers, expectation is not just send patches to your 
> driver, also review patches in the community, *at least* ones against your driver.
> 
> Thanks,
> ferruh
> 
> 
> [1]
> https://patches.dpdk.org/patch/75318/
> https://patches.dpdk.org/patch/75319/
> [ There are a few more versions in between ]
> https://patches.dpdk.org/patch/83174/
> https://patches.dpdk.org/patch/83421/ [This one]


Hi Ziyang, Guoyang, Xiaoyun,

What is the latest status of this patch?

  reply	other threads:[~2021-02-18 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2027a001-c422-6464-ccff-1d3d90039ecd@huawei.com>
2020-11-02 14:48 ` Qingqing Li
2020-11-11 13:07   ` Ferruh Yigit
2021-02-18 17:54     ` Ferruh Yigit [this message]
2020-08-08  7:20 [dpdk-dev] [PATCH] net/hinic: " liqingqing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aaaab09-5fb9-5574-2f45-9d06d790bc12@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=dev@dpdk.org \
    --cc=hushiyuan@huawei.com \
    --cc=liqingqing3@huawei.com \
    --cc=xuanziyang2@huawei.com \
    --cc=zhouguoyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).