From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5B8B91B3EE; Wed, 3 Oct 2018 16:50:09 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55557C0270D2; Wed, 3 Oct 2018 14:50:08 +0000 (UTC) Received: from [10.36.112.44] (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 92A4E309136C; Wed, 3 Oct 2018 14:50:00 +0000 (UTC) To: Ilya Maximets , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com Cc: dgilbert@redhat.com, stable@dpdk.org References: <20181002093651.24795-1-maxime.coquelin@redhat.com> <20181002093651.24795-3-maxime.coquelin@redhat.com> <20181003132429eucas1p195b034c06ad265826eee360abc775cd8~aHA4HDRm11505315053eucas1p1U@eucas1p1.samsung.com> From: Maxime Coquelin Message-ID: <9ab6a638-f89d-5509-fd99-7d4be219aa04@redhat.com> Date: Wed, 3 Oct 2018 16:49:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181003132429eucas1p195b034c06ad265826eee360abc775cd8~aHA4HDRm11505315053eucas1p1U@eucas1p1.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 03 Oct 2018 14:50:08 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 14:50:09 -0000 On 10/03/2018 03:26 PM, Ilya Maximets wrote: > On 02.10.2018 12:36, Maxime Coquelin wrote: >> VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE >> and VHOST_USER_SET_LOG_BASE require replies, so their handlers >> should return VH_RESULT_REPLY, not VH_RESULT_OK. >> >> Fixes: 2cfbbb86c62a ("vhost: unify message handling function signature") >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost_user.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >> index 060b41893..ce0ac0098 100644 >> --- a/lib/librte_vhost/vhost_user.c >> +++ b/lib/librte_vhost/vhost_user.c >> @@ -1161,7 +1161,7 @@ vhost_user_get_vring_base(struct virtio_net **pdev, >> >> msg->size = sizeof(msg->payload.state); >> >> - return VH_RESULT_OK; >> + return VH_RESULT_REPLY; >> } >> >> /* >> @@ -1218,7 +1218,7 @@ vhost_user_get_protocol_features(struct virtio_net **pdev, >> msg->payload.u64 = protocol_features; >> msg->size = sizeof(msg->payload.u64); >> >> - return VH_RESULT_OK; >> + return VH_RESULT_REPLY; >> } >> >> static int >> @@ -1298,7 +1298,7 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg) >> >> msg->size = sizeof(msg->payload.u64); > > Maybe we need to set size to zero? This message should not have > "Slave payload" according to docs and QEMU does not check it. I agree with the fix, but it's here since the beginning, not related to this series. I will add it at the beginning of the series though. I think the spec could also be updated, to clarify what payload is expected when VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. > >> >> - return VH_RESULT_OK; >> + return VH_RESULT_REPLY; >> } >> >> static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused, >>