From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90381A0527; Mon, 9 Nov 2020 12:16:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E3BE5AA7; Mon, 9 Nov 2020 12:16:52 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AE7E35AA6 for ; Mon, 9 Nov 2020 12:16:50 +0100 (CET) IronPort-SDR: NEHDGLUN+9fhePqcObno9XE71lDxmwECRNNgz4b3rbTCTsIHaEvmQYWuFxpxEwzXat/c/OSQWR gHe0J/e5P2+A== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="254491465" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="254491465" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 03:16:48 -0800 IronPort-SDR: fKqFvXCn57kTkGgko+7rEE918C2Y2Q6WJuR77MKfDwmqL3Lz0J9bkuEdELQiLQBJ6YSRzIYnF7 JYeNHqyPxK0Q== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="530690917" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.177]) ([10.213.193.177]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 03:16:46 -0800 To: Dekel Peled , Xiaoyu Min , Ori Kam , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Matan Azrad , Ajit Khaparde Cc: "dev@dpdk.org" , Jack Min , Andrew Rybchenko , NBU-Contact-Thomas Monjalon , Hyong Youb Kim , John Daley , Asaf Penso References: <20201103132022.14132-1-jackmin@mellanox.com> <5218b9e5-68a8-085d-3336-ae1b4f0971a9@intel.com> <500a6ffc-2c12-9e2e-4413-d4e5b097d61a@intel.com> From: Ferruh Yigit Message-ID: <9abde710-7669-279d-c1b5-8cc29be4f310@intel.com> Date: Mon, 9 Nov 2020 11:16:44 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2020 11:14 AM, Dekel Peled wrote: > Hi Ferruh, > > Sorry for the late response, we are checking for additional impacts of this change. > Looks like there is another fix needed, after all checks are completed we'll submit all relevant patches. > Thanks Dekel, appreciated. > Regards, > Dekel > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, November 9, 2020 12:05 PM >> To: Xiaoyu Min ; Ori Kam ; >> Wenzhuo Lu ; Beilei Xing ; >> Bernard Iremonger ; Matan Azrad >> ; Dekel Peled ; Ajit Khaparde >> >> Cc: dev@dpdk.org; Jack Min ; Andrew Rybchenko >> ; NBU-Contact-Thomas Monjalon >> ; Hyong Youb Kim ; John >> Daley ; Asaf Penso >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr >> struct >> >> On 11/3/2020 2:27 PM, Ferruh Yigit wrote: >>> On 11/3/2020 1:20 PM, Xiaoyu Min wrote: >>>> From: Xiaoyu Min >>>> >>>> The rte_flow_item_eth and rte_flow_item_vlan items are refined [1]. >>>> The structs do not exactly represent the packet bits captured on the >>>> wire anymore so set raw_encap/decap commands should only copy real >>>> header instead of the whole struct. >>>> >>>> Replace the rte_flow_item_* with the existing corresponding rte_*_hdr. >>>> >>>> [1]: >>>> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and >>>> VLAN >>>> items") >>>> >>>> Signed-off-by: Xiaoyu Min >>> >>> >>> Hi Dekel, Ori, >>> >>> This is second fix [1] we get related to the "rte_flow_item_xxx" size >>> changes [2] from you. >>> >>> The assumption that 'rte_flow_item_xxx' size is same as xxx header >>> size seems implemented in multiple locations, and changing >>> 'rte_flow_item_xxx' struct size breaking those usage. >>> >>> Can one of you guys spend some time to actively check all possible >> breakages? >>> They may be very hard to find unless someone explicitly check for this. >>> >> >> Hi Dekel, Ori, >> >> Is there anyone actively checking for this? >> >> >>> Thanks, >>> ferruh >>> >>> >>> [1] >>> first one: >>> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc >>> >> hes.dpdk.org%2Fpatch%2F82863%2F&data=04%7C01%7Cdekelp%40nvi >> dia.com >>> >> %7C3ab20dfba7264766e7e808d88496fab7%7C43083d15727340c1b7db39efd9c >> cc17a >>> >> %7C0%7C0%7C637405131289676761%7CUnknown%7CTWFpbGZsb3d8eyJWIj >> oiMC4wLjAw >>> >> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sda >> ta=xF >>> >> xO%2BmzQP6bjS9BE1Eg9fd1pd8VPLNHV%2FJm83cwJ2Xw%3D&reserve >> d=0 >>> >>> >>> [2] >>> Fixes: ad976bd40d28 ("ethdev: add extensions attributes to IPv6 item") >>> Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN >>> items") >