From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 89A561B360 for ; Tue, 16 Jan 2018 20:16:51 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2018 11:16:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,369,1511856000"; d="scan'208";a="19895850" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga003.jf.intel.com with ESMTP; 16 Jan 2018 11:16:47 -0800 To: sodey@rbbn.com, jan@semihalf.com, jpa@semihalf.com, netanel@amazon.com, evgenys@amazon.com Cc: dev@dpdk.org References: <20180116190606.20208-1-sodey@rbbn.com> From: Ferruh Yigit Message-ID: <9ad79501-24bc-1292-1f20-7ce365721a17@intel.com> Date: Tue, 16 Jan 2018 19:16:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180116190606.20208-1-sodey@rbbn.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] drivers/net/ena: Copy PCI info to rte_eth_dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 19:16:51 -0000 On 1/16/2018 7:06 PM, sodey@rbbn.com wrote: > From: Souvik Dey > > We need to add the pci_dev info to the rte_eth_dev structure > during the eth_ena_dev_init. Informantions like driver_name > and numa_node will not be populated otherwise. stacktrace is like: eth_ena_pci_probe rte_eth_dev_pci_generic_probe rte_eth_dev_pci_allocate rte_eth_copy_pci_info eth_ena_dev_init So, before eth_ena_dev_init() called, rte_eth_copy_pci_info() already should be called and eth_dev updated with pci_dev info. And you shouldn't need this patch. Do you observe any missing data in eth_dev? > > Signed-off-by: Souvik Dey > > --- > > drivers/net/ena/ena_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index ac0803d..329cb29 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1270,6 +1270,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev) > pci_dev->addr.devid, > pci_dev->addr.function); > > + rte_eth_copy_pci_info(eth_dev, pci_dev); > + > adapter->regs = pci_dev->mem_resource[ENA_REGS_BAR].addr; > adapter->dev_mem_base = pci_dev->mem_resource[ENA_MEM_BAR].addr; > >