From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 759E4A09FF; Tue, 5 Jan 2021 10:02:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 145021607B5; Tue, 5 Jan 2021 10:02:26 +0100 (CET) Received: from postout2.mail.lrz.de (postout2.mail.lrz.de [129.187.255.138]) by mails.dpdk.org (Postfix) with ESMTP id 36B251607AA for ; Tue, 5 Jan 2021 10:02:25 +0100 (CET) Received: from lxmhs52.srv.lrz.de (localhost [127.0.0.1]) by postout2.mail.lrz.de (Postfix) with ESMTP id 4D962S3zp8zycQ; Tue, 5 Jan 2021 10:02:24 +0100 (CET) Authentication-Results: postout.lrz.de (amavisd-new); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=tum.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tum.de; h= content-language:content-transfer-encoding:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:subject:subject:received :received; s=postout; t=1609837343; bh=vrAcroK79/eH+O7Dy/j619OeF ZCr3n4+IR7h5LdqhmE=; b=MRcrYOtMff9RhLHgj/IVTANI3PcPQG8giCPiZLlof nErWwC6ekOW5e9NPM/WX9QiiM31xBy0nV9CVf7B7P76wGHZLth2UTpxyYpxbk8Mm 8xzj0B7qtA+v/194o1yeW4YcbEw+7NvDE1EbaukPUkD5V/zsP0cRcavxPMZYqCqb 9FGVo6hURKJp3A7WEk6LIQg13udqsYmyb42/p8/rAbKxrOQfkXNpSmp3Dh8y91yR vjP66Zfg2J/Tl0BJLopWj+H4bpAT/2caw3gx47q8GRalQzAQDzz9KNjrracWAc3X Es5+eteAi+uekokLuMiAd9yTi19xuZ3PERjdNznUYn75g== X-Virus-Scanned: by amavisd-new at lrz.de in lxmhs52.srv.lrz.de X-Spam-Flag: NO X-Spam-Score: -3.122 X-Spam-Level: X-Spam-Status: No, score=-3.122 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, DMARC_ADKIM_RELAXED=0.001, DMARC_ASPF_RELAXED=0.001, DMARC_POLICY_NONE=0.001, LRZ_DMARC_FAIL=0.001, LRZ_DMARC_FAIL_NONE=0.001, LRZ_DMARC_POLICY=0.001, LRZ_DMARC_TUM_FAIL=0.001, LRZ_DMARC_TUM_REJECT=3.5, LRZ_DMARC_TUM_REJECT_PO=-3.5, LRZ_ENVFROM_FROM_ALIGNED_STRICT=0.001, LRZ_ENVFROM_FROM_MATCH=0.001, LRZ_ENVFROM_TUM_S=0.001, LRZ_FROM_HAS_A=0.001, LRZ_FROM_HAS_AAAA=0.001, LRZ_FROM_HAS_MDOM=0.001, LRZ_FROM_HAS_MX=0.001, LRZ_FROM_HOSTED_DOMAIN=0.001, LRZ_FROM_NAME_IN_ADDR=0.001, LRZ_FROM_PHRASE=0.001, LRZ_FROM_PRE_SUR=0.001, LRZ_FROM_PRE_SUR_PHRASE=0.001, LRZ_FROM_TUM_S=0.001, LRZ_HAS_CLANG=0.001, LRZ_HAS_IN_REPLY_TO=0.001, LRZ_HAS_SPF=0.001, LRZ_MSGID_HL8_3HL4_HL12=0.001, LRZ_MSGID_MOZ=0.001, LRZ_UA_MOZ=0.001, LRZ_URL_PLAIN_SINGLE=0.001, NICE_REPLY_A=-0.249] autolearn=no autolearn_force=no Received: from postout2.mail.lrz.de ([127.0.0.1]) by lxmhs52.srv.lrz.de (lxmhs52.srv.lrz.de [127.0.0.1]) (amavisd-new, port 20024) with LMTP id 4YbJbJauTAQx; Tue, 5 Jan 2021 10:02:23 +0100 (CET) Received: from [192.168.1.3] (dynamic-077-009-123-153.77.9.pool.telefonica.de [77.9.123.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by postout2.mail.lrz.de (Postfix) with ESMTPSA id 4D962R3K8szyc2; Tue, 5 Jan 2021 10:02:23 +0100 (CET) To: Ferruh Yigit , "Wang, Haiyue" , "Guo, Jia" Cc: "dev@dpdk.org" References: <20201217171452.24914-1-simon.ellmann@tum.de> From: Simon Ellmann Message-ID: <9b039080-a3a6-ca58-f0a7-2af4ce327585@tum.de> Date: Tue, 5 Jan 2021 10:02:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-IE Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/4/21 4:56 PM, Ferruh Yigit wrote: > On 12/18/2020 2:34 AM, Wang, Haiyue wrote: >>> -----Original Message----- >>> From: Simon Ellmann >>> Sent: Friday, December 18, 2020 01:15 >>> To: Guo, Jia ; Wang, Haiyue >>> Cc: dev@dpdk.org; Simon Ellmann >>> Subject: [PATCH] net/ixgbe: clear registers of all queues on VF reset >>> >>> ixgbe devices support up to 8 Rx and Tx queues per virtual function. >>> Currently, the registers of only seven queues are set to default when >>> resetting a VF. >>> >> >> Fixes: d17d0b7a2407 ("ixgbe/base: reset VF registers") >> Cc: stable@dpdk.org >> >>> Signed-off-by: Simon Ellmann >>> --- >>>   drivers/net/ixgbe/base/ixgbe_vf.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >> >> Good catch, thanks! >> >> Acked-by: Haiyue Wang >> > > This seems a very long lived defect, I am just suspicious if there was > a reason to limit queue number to 7. > > > Simon, > > How did you find the defect? And did you test/verify it with the > update? (assuming you are using all 8 queues for the VF) Hi Ferruh, I was implementing ixgbevf for ixy.rs (https://ixy.rs/) by reading the code in DPDK and Linux. While doing that I noticed that DPDK was only resetting 7 queues which looked like a off-by-one error to me. I would have expected a comment if this behaviour was intentional. I haven't checked the update. Simon