From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0047.outbound.protection.outlook.com [104.47.41.47]) by dpdk.org (Postfix) with ESMTP id BF02A2C39 for ; Wed, 1 Feb 2017 20:31:54 +0100 (CET) Received: from BN3PR03CA0115.namprd03.prod.outlook.com (10.174.66.33) by BL2PR03MB467.namprd03.prod.outlook.com (10.141.92.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Wed, 1 Feb 2017 19:31:53 +0000 Received: from BL2FFO11FD042.protection.gbl (2a01:111:f400:7c09::167) by BN3PR03CA0115.outlook.office365.com (2603:10b6:400:4::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12 via Frontend Transport; Wed, 1 Feb 2017 19:31:53 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD042.mail.protection.outlook.com (10.173.161.138) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.874.2 via Frontend Transport; Wed, 1 Feb 2017 19:31:53 +0000 Received: from [127.0.0.1] ([10.214.249.79]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v11JVkr0005910; Wed, 1 Feb 2017 12:31:50 -0700 To: Olivier Matz References: <1484678576-3925-1-git-send-email-hemant.agrawal@nxp.com> <1484896280-18814-1-git-send-email-hemant.agrawal@nxp.com> <20170131105535.2831ac3d@platinum> CC: , From: Hemant Agrawal Message-ID: <9b0e2213-e294-8224-faff-2af5b4dfc91e@nxp.com> Date: Thu, 2 Feb 2017 01:01:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170131105535.2831ac3d@platinum> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131304511132926844; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39410400002)(39400400002)(39850400002)(39860400002)(39840400002)(39450400003)(39380400002)(2980300002)(1109001)(1110001)(339900001)(377454003)(199003)(189002)(76104003)(24454002)(83506001)(8936002)(7126002)(65806001)(86362001)(4326007)(23746002)(54906002)(47776003)(5660300001)(31686004)(2906002)(105606002)(50466002)(92566002)(31696002)(38730400001)(36756003)(77096006)(229853002)(65826007)(65956001)(356003)(50986999)(110136003)(85426001)(53936002)(626004)(97736004)(6666003)(2950100002)(189998001)(81166006)(6916009)(230700001)(106466001)(7246003)(104016004)(64126003)(68736007)(8676002)(120886001)(76176999)(54356999)(305945005)(81156014)(4001350100001)(33646002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL2PR03MB467; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD042; 1:Jg4pj6IcijwAXYZVb932zu1S/0yXayZov96MFvQFImTb8E4cE8K18LDtW+H71kHqAWXGXFeWKIWXexsOKcfpIPyWPxb5cHfElB0aLcPqHQgkoHUJEIDWfZCovLFtUxYQcXVT039R2tP7kyD1R9VNzixDawBpyHVnvh6evc0K092XbIP3yCbgwPlWCprGuWr6bXipsz+Dbd2vLyBQ0xQyuJqKKkAgY7GlCg6QSyC5sGyDJyaBdxZgZJsVlMMSXXMQTlhuNd0cpRb4JUdiOF8L2mRZAEb5T8afJzhfyBmO4gMYXT31yBI+kW8WoASpD4Qo6tCu97u7ccsS+g56naO6hVUwon9VX2tqraoVEeYPTeHaSsnt4DI9FFQj/kumxUA/v+NrxErq7E+Z3HuGn8PCD9SBKNJt6MKoFUfSBFxEBal7y41VImreyvGkNVRFkCtLSjcwr3o1VLHItV9t4HexAd6PAGs3lWdI7ggicPUxScW43IButltZzPw4YYO65+e2I4otumOTfrJnNrK4bWxBMGIaZvlsb0eG6bQ4tW2MWrROeATLAkqvvJ3NA/tmp/OSDEvPzQtQOS3XzlCIU2J4tw== X-MS-Office365-Filtering-Correlation-Id: cc6e49a3-25d9-400a-a21b-08d44ad8f9f0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BL2PR03MB467; X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB467; 3:KKrgwMBQhwjVYMqwhkJh3sWDInxx87dl84T99t18ql23RIxNhh3QDVwTcwWy6iwqpyFeRphWOmez/se1gerRtzrW1r8GmgXkJVelWJrd1cSEzk87GWUKbtp3SUlpwKcRBAc5zwDsRSVeIMB8HKeuJkaUfvGZ+RPgirOaYG2TOza3erpDfRoz5nLABor6Kgd57rARJfY5g1ZYSpf+qbvUjkBgEeYMAAyqV5ChggfaNmK8GrmbLsuoMCsf6luVOzdLMGhPszLpCephClCFHXqa/8iIQ4EiDzs3LudAwXz3bB8PSKna9DS1vnETHDbz9J73eof2/Zn3BKjLEQLKhyvHMyayneJV2an/HW1YEup1oDrma+vU41R2R8LZkTBSuAuR X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB467; 25:ft6n0JPOJnvIizXUsyfMbE5ii6Gt5gpLyUpkHZwQkcKb8lCYaZCrhyO/FzzFoC3qocbvNTlmU1gA9+vyeHRCvdd5mVMW13G+aJpowYQcqetYyUJ3zjI0I4crtWzM3+OfLk2tnSYqRGANynS9XVaDDtPVKAV8iWh2MK2XI1j5ygSTv9s9zg5jriXw6AWAgsEig64sSLZUf6zSJ9S24Qvyrw4nIUJ/6LdtxKGd5CSdpfoYXtfYm3VtnJkEIJGyS3sI5dU9fnJw9XpDMHTiRtKVgJmpXwcJa23DZ2+SF3CY07AiXih6n2ZhSjnZVVVv5trFvmmBtfuW7UGZvCYz5Hb77vdSfpKz9+V5XNouytgeVC8xKwgzXK9Fngb7f5kBiUk5tPDAob4rCiizLYXmHZpuC+E6+MSra9DFJPp/d/39zk2NEZbnHvGByKdAUXsbka4fkWR2Ent0RN2/mX15RwPbd+5nhPYyytfY9gR9oxO0pRhdWg0enaPX47iIDSRY+bMOGRJDDfYuvnokI083R6TtJ+d+1xhIOvtHs31/yQWTY7pntvVyt4aVir9vTNyjPbEiXQAChhIGmwNmT27Ff1E10H2zW75/cxNTXgh6RXBqmYtxlAMgObhsEDmDlQZ8UBsEA3nrJADYRKV50a1jw/+YDrAzzTNojkBfBSsJ7oPvQRBGk2b2koUlg/C7cfj7GgfHQfQm3s81eAEYTwVC2TJym3Tmc7oqL/rY1rLdVsGx1lYPk+ohb+KqjgatU8BlY6P6 X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB467; 31:CMCV1EDFi9zkCQ32F194zpYmweSIvxtzaOmT966Fq9XTBveaHs5MGRvvfEzXqkg3/TqKYjXRKs9rWwcNOocFOvWKoXAGfsQR5FS+ALRRAwLxwHEoWM2Q1PkbBM9s3TPESuUdRAOqooggcny5StcV3Q8rLfOrKXVzt8lNuW8PiAhd91J0HoCHgjMM1Vi5yWUZUXQI67ioNa4e+URDNwuMsgq+CNxmni3l7lBZHgbnaPbBPq2yH9BL8+i8lrHBYcG4tWg6Ps4FvxY511jxSJNu7BoC6t5EdFac2GvwmxcAM2A= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(8121501046)(5005006)(13023025)(13015025)(13017025)(13024025)(13018025)(3002001)(10201501046)(6055026)(6096035)(20161123563025)(20161123565025)(20161123559025)(20161123561025)(20161123556025); SRVR:BL2PR03MB467; BCL:0; PCL:0; RULEID:(400006); SRVR:BL2PR03MB467; X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB467; 4:OZ3mZe/SeYWp0PbPYLonub+LCKPJw0/CkHo7OT4c6MbHoPJdFgdROFYNwQ5O/a2GpHGp+kWTBDZJ3dZrvDdzNQeA7jGunMlzByFWx+dpS/kJevAyaj9Q56GcY5WQvNFLy00+x+MqZq8c1h46PSpqb9qOY4hfBWbKrxZdOyKC/t4CJJD1jSzFoYQ+IWxS/gi4gnehSSYPcw69ec3a8JlYqpThZuiWbQNYrPh32FqUTgiuaT88R52vKtrHjRff5jabyOyG4mMgJRxBmBKI4kM7UxQenBF2MsUrfj5BULyLq4Oy5BhFZv5TBG0UX2jY3u2gJrfSHrX56Pcyl1/sHXOwjN4nZqOGb9NJhCTwh1BFFg05acX/VQrOYpVUFqaImzDN5M52xtghFXZRm99wtaXJM8aEaKfvbNB3E3+0ErCtamIiU2ysdXyRtPi1a84muamdmWcNVO7Rvd6/Wk9KvqL2dVpPJYGX06hQXVoGL3x4Mu0RaZAGNPp2pxmP5ca8pC9vT416HhFFIdVZc4Q6P3hDaM8I8PkEGHb8RqC8rIxz/O0lJ/CfCemWsfXy+swYyK2UTGvWSNHIBcfeSgVY0M73N82txSL2gNH6QnjSHkOwg/lH9QY8hIZpC5auKp3rzBIEM08fnNmEXeK+1Cu5MajVGDW2aY0pmuMt3NhQ9qcLT3t4z0uHNOHu2uWBCSnyTMGco3p8kz3Y8iBxnTN3Pjflx2P/2KQWaIN+5ee5QeIpLsm9UqZGuOMtdnvIqpr0RCJxsH8BM0t9H2bqppxXfga3BA== X-Forefront-PRVS: 0205EDCD76 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BL2PR03MB467; 23:3Jd2V92pJ6AJcVCoGQ1gRs2kzEvFfIyfMMkiPH?= =?Windows-1252?Q?g0NpehO9kVfIFEBIj9iy0nLOFCJkoHmN4/E+c/JTbeqhkDoaI/GS4aTd?= =?Windows-1252?Q?aT76aCpjcrv8fl65unea+LdpddS8N611HecyWgsVFKaqG+ILaAg1GZpR?= =?Windows-1252?Q?KhJXOUNL25ZlwQ7xiwbbfME4P4bHEWGKVmDMDdwcYTMxJCpDLO+gZ8a1?= =?Windows-1252?Q?mtSYHqvc4UMATKRlqm/tiwAyAGryDMUzaLVMVAEaLBWpeESsEWWSBfo6?= =?Windows-1252?Q?QVrpRPCVSU55ui6DAtwK6WdHKDbihaQrZ9LQryQ9WYapbvXJm/QrNlKG?= =?Windows-1252?Q?NjWO6Zl4qbkPvWDMUcH+yRIRtJfPeYbOYx2gg6JveBPeloG4xUdjSTN9?= =?Windows-1252?Q?MvF/rp6lFybFENer6xmPLiL1hMCfW7K+DQUzw3D3ucp/JgC8YH/9sIVu?= =?Windows-1252?Q?1N4SCCql8rVP0Lf8XM96NDRme8Sed8/R1Ur77moWQOzH9F1ZeJhBK9mE?= =?Windows-1252?Q?0a8y2/AiDsGJzb28LdYIw5EzCPYve/z3l56KlpnjTKbu20ZjQkJrw63y?= =?Windows-1252?Q?0ngrrZGYKWG+KCWqwLO+exienOZMQ03d99SyEpWxkiL9tItX5kNdwXzj?= =?Windows-1252?Q?Ow4pKSNe2QvYx/ifGQrusPVhqj0izC380m2Vk+B0QI+pnXJJMYs+Vckm?= =?Windows-1252?Q?SxL+kwErEBwgz0OXWQLSf9AeQ2CQMS8eQIQTAnbXLHuPYgOUWa0XpgdO?= =?Windows-1252?Q?Rb0GzxGIZ4nJa2fX4AaEYPh0gD2kYtD1bbKLV8wyz67m7SXu8nmWTMdy?= =?Windows-1252?Q?r3BnSKaMSBJndDYyryO/7hRM45uZeZ6pzxscByx8ndksiBrl77+zQF0M?= =?Windows-1252?Q?v4JDT+sXOVz/NzWh6nTg6351l+NwA+86fbX5CR0PfQe68hjZz9aErv0M?= =?Windows-1252?Q?hmx1bRgWTNn/XxxmJpK233JemxlBYHJ0n4T76iUI4BDbDcV8ytpI1Ba1?= =?Windows-1252?Q?8Qq6jY3AWvDltASUNkzTx8iXtl54On5KqufjpxdHqX8xRPFp5IS3PGT9?= =?Windows-1252?Q?CZLCzTp6uTBhmMFBZS8Ym33w+h5siZjk+VxB/O9Qf2SQDf9ti5b/Sz+h?= =?Windows-1252?Q?kblj8l7zuPJsIXy4g8Vu1EzykvYfDr10AGYI0vXUP6atmiWUZCQ21LB0?= =?Windows-1252?Q?LQRBIDXT8KSk615oZ78WPH4goVdf6/V/t1PARPNd64fVhQcb03yfMIKt?= =?Windows-1252?Q?FkXhGBq4KQfHZ/YGH63yzlcYRcDsRnimAdiKIjpy+eY4tZ41E85TtxT+?= =?Windows-1252?Q?wlTZz1OJXeTtHpACJRNt1u7DDOELp2nkXRfxG8ea5HjoszmA28aF2Gkv?= =?Windows-1252?Q?TZU8SpY/iyAk906bIOPjJ9Y1CerdlImE48+MSkFEpxCKzcCVtRMYCofo?= =?Windows-1252?Q?diY27WfNrY2LRGkeD/lIxYtlp5cmSclRuR6l1mXX+yaLYj6ZiNJZVR3r?= =?Windows-1252?Q?wHF8as0q12jmmKGg9OTcic/5i3yeb6RDlwTBrjjplHGQj1yskw/lBqU/?= =?Windows-1252?Q?JyTpYMv9IDERHtw8Bg4QucdDBV2qWVNYZYAMOz6U9JVTxhpuK4PJr/+R?= =?Windows-1252?Q?/9hUHF+ldZz3Zot+dQY+0C39jiLiuBoHJ31KEjw8cC7tDusoo7t0gbi5?= =?Windows-1252?Q?TibVeLybzB71tVsFtQSa9YfAE+BD1gV3xMJ3WcFsn6rETlefxh?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB467; 6:QioPm5N4ipCMbNlt2ORx5R4AZWdbsCErK6xl1YdbbrkupqpqN9HOwlccQ4Gd3YGpX9uU+X4Vk+AH0w4N3NHZmS7VvUQcMLmGp5egOtw1+AQuBGodlhKgoq8U3Oae1DKb9/FZBeab1y7mVXEo53KlyuKq4zQIdaEWRhPVedzYJTBuTNnYgzEfZU9Q9NB7bXdEmwUdxf9ffHZEWHKRrgLr92ptYQxMVocBjzYMwZo+Xfu1dPTKi+oULE+ONAyRZBWR8yo8mlvp9J7OPn+Xy0zFvl0fDPIDlzjaO/0kbILr5Jb/MiBhIAPjU9Hilqy23y9R0zgeXaCOJgDdlDUR5hK3oPY1+RpDOD7vqeooNolz7wunmT2KUxErvfiUK8CIsUDgLPz9V+Bsn9fFV33L2yXKgx9par3A8ReHZzfsvrJRjorwtreE99yrGcyCb/RFtg/C; 5:QpDACbomIx1aTKZmSCLW33WIbMUaSE5ADwuDGqADQbAhRkqm7Ul0GtCuAfPzhOTWvWyjn77PsUmj1Xf5/Wsf2Fl4kIaGcW7JMjBDCX1PJKUdb3O09iMV9TGAiQLqpGwKkwWKSEDRslYHlDSjlNdbdYMTXP/G4Cwc0YaLJGh0mDqnsUrvsh+5cjcQCy+aR81m; 24:mDcVE6DOy25doOJaxcxD5aRlgqRKwPryvh4/PiXB6os01Fw0aTBDrC2+gAEEBmsseXMUvNcZEhawcgQUsUUWcsWyITnNUSFtfC9Bps4xX8Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB467; 7:g7Gm859pOwio3xp09C1OekYSOixvKvPAuOkJftOol2kVCm2/nf0oVIadbeWUYGx7S78GiRUFXOvwSMHNJmds9t+mrjW8WrHBMbvFifODt12LlhGKniKu7rgFWD85Z68VVNcXo5yQIcAgUxqZ/gBUW3P5/AYD43V54IIAZ0Sds6mj1YHRqcG8X8xk1GaDKOVX/D8Uj7pqeqQkfqrVxkmxIxOXDFwg+UCZ7qRKXUSNTtBeh/oPR7Z/hgflFVoCuY/ujVKlfwuuPld1HEUNexUrxaR3yRTuxT4PiGAmmuTRupUnFFntI8GL6z8zWdhU5s+jY709NLI8gp9BvDh+wFj09U6BBDcC0yoSQehewQMiXy/cpOYF2JNikZnlpllQmXhEWVGOjmN6ajFsFFKommkmDz3d3mmsM25//H1jzVWWb74Rxcmxo42Mr4EQcsvsnyl62o6DCGU0YB5KkC0rx3MKxASC+/e6ROsWOH9VJyYJIcIPA2ZzZ6xyDoI8pdjWoq/eDoC9pkdH+xCoq775vWdXXg3titxzz43BlyhtZgPQ0JvivCmWB24nTwoaURu4U9H9 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2017 19:31:53.1054 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB467 Subject: Re: [dpdk-dev] [PATCH v2] mbuf: use pktmbuf helper to create the pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 19:31:55 -0000 On 1/31/2017 3:25 PM, Olivier Matz wrote: > Hi Hemant, > > Sorry for the delay. > > On Fri, 20 Jan 2017 12:41:20 +0530, Hemant Agrawal > wrote: >> When possible, replace the uses of rte_mempool_create() with >> the helper provided in librte_mbuf: rte_pktmbuf_pool_create(). >> >> This is the preferred way to create a mbuf pool. >> >> This also updates the documentation. >> >> Signed-off-by: Olivier Matz >> Signed-off-by: Hemant Agrawal >> >> [...] >> >> --- a/examples/ip_reassembly/main.c >> @@ -909,11 +908,13 @@ struct rte_lpm6_config lpm6_config = { >> >> snprintf(buf, sizeof(buf), "mbuf_pool_%u_%u", lcore, queue); >> >> - if ((rxq->pool = rte_mempool_create(buf, nb_mbuf, MBUF_SIZE, >> 0, >> - sizeof(struct rte_pktmbuf_pool_private), >> - rte_pktmbuf_pool_init, NULL, >> rte_pktmbuf_init, NULL, >> - socket, MEMPOOL_F_SP_PUT | >> MEMPOOL_F_SC_GET)) == NULL) { >> - RTE_LOG(ERR, IP_RSMBL, "mempool_create(%s) failed", >> buf); >> + rxq->pool = rte_pktmbuf_pool_create(buf, nb_mbuf, >> + 0, /* cache size */ >> + 0, /* priv size */ >> + MBUF_DATA_SIZE, socket); >> + if (rxq->pool == NULL) { >> + RTE_LOG(ERR, IP_RSMBL, >> + "rte_pktmbuf_pool_create(%s) failed", buf); >> return -1; > > Here we loose the SP/SC flags. In the ip reassembly example, it looks > there is one mbuf pool per rx core since the beginning (commit > cc8f4d020). It's probably not critical, but I think we should remove > the ip reass part of the patch, what do you think? > I agree, I will send the next version. > Note that this issue was also in my RFC patch, so it's my > mistake :) > > > Apart from that, the patch looks good. > > Thanks > Olivier >