From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78DA741F45; Wed, 12 Jun 2024 03:12:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E37D4028B; Wed, 12 Jun 2024 03:12:32 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062.outbound.protection.outlook.com [40.107.244.62]) by mails.dpdk.org (Postfix) with ESMTP id 936B44021E for ; Wed, 12 Jun 2024 03:12:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MsR/06haNZtSXsBvcbEEEsDwOI+/nA49uyS3AqlnDh7lfAkBDf12bF2Q/PoToEV8QAjEKgORD6SogVLAUtSfNPZ3hjoIw0Wi+q1w309HTs0vY77m4NAEJTkubWmX6jYJxvdoe7pXnjxnJgmdKB9lu9fiO+997xPYCWF6ItgouDEN54Xd+jwIz+0iUVgPLVoV4IrCVR8HxrBooD7K5grgePFO/kC/b6jZT0u3zH/EhS8U+GCNdeup97zpBniIHyI3bjQa0B9i4eEIeXRqFZST37DwOnWT6ZcndIDX7ZcUoYAOAmhrlvbdXFIXDLiJDqx25sZbmXZonkRtWrX3z7UYuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9pdOgM/c7MIjF+aByVlfy9Sjvb2d8Il+bmejtf4vt6U=; b=Jtxo40ah73g8Ql4eCllnCgiueXPk8J9682WBvqhMY9cckmTAzGWqxgbXpQCUbY6MULfh+klnbd8LULzvbZ+lgjH2nNIAakiryL8Sqd6TIfYr41g1Ukz50VLk8Glwf6KlBRvdQcwWyVQ29GhxFGCpoE+6ZRT8fuxR2CKDNqqISNrpRcFoEJrb8PcNPgAMbcME9Y+j33nstDl7IPJq2NdYsb6OYQlcksUjLlRRjIOPLlRE8NMkHYa4jzAWTf085drP8YRUA9JRNbA1vaYFUnIrMH5mmq+jpOOZM51q44ogOI922yDxgbElM6s5O4U7B4zwlObNEYHJStD6zI8mT+XqrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pdOgM/c7MIjF+aByVlfy9Sjvb2d8Il+bmejtf4vt6U=; b=ADmfqhQMuv+OE4DBYR10Whc4+XFI+Ljtcn8IHpGjpOwfxDqruYILE3+sUJij2F0W8zMPFuRjwCSOTrku0nR0MWbSUo091BcpV6au21e78zft91ofGDnzGcsrHVgcX+UGsuTL19chFwSXFch9W8kzNOSo6jkexiK8vq+BMt6OHZQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB6749.namprd12.prod.outlook.com (2603:10b6:806:255::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Wed, 12 Jun 2024 01:12:27 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7633.036; Wed, 12 Jun 2024 01:12:27 +0000 Message-ID: <9b196355-578a-48f3-926b-38cadff28052@amd.com> Date: Wed, 12 Jun 2024 02:12:22 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 4/4] net/ice: remove use of VLAs To: Konstantin Ananyev , dev@dpdk.org Cc: hujiayu.hu@foxmail.com, roretzla@linux.microsoft.com, bruce.richardson@intel.com, anatoly.burakov@intel.com, vladimir.medvedkin@intel.com, Konstantin Ananyev References: <20240523162604.2600-1-konstantin.v.ananyev@yandex.ru> <20240523162604.2600-5-konstantin.v.ananyev@yandex.ru> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240523162604.2600-5-konstantin.v.ananyev@yandex.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0353.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB6749:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e79becc-f3aa-4211-b39c-08dc8a7cb9b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230032|376006|366008|1800799016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TlJiRStjZWN2U3lsNjFGZXVONm1TVWY5RzJ5RWQ4N0kzbjFBWWRSYk1vc0pQ?= =?utf-8?B?OVZyQ3B6ZnJhMy8rRzBmNzEyb0I0UEZOVkFHakpZa1REWWtMUzF4UWtFeHJQ?= =?utf-8?B?Q3pRTWVOMGtiTkFzV3pKYnRkTkFEVTMxclhWZG5Ha1pFcVd2alYraE1xVE8r?= =?utf-8?B?eXVxaGs0TUhySU93bnFTeHNMNkY1YWhYU3JNUG1mVFQ3UmlWaUxzQzQwOER6?= =?utf-8?B?UjAxWS9rT2RFeE9pMC9yS0NZSzY2aUtoV2RVMElEbm81Y09ERjY2dWdCYWtl?= =?utf-8?B?UkdRc2lNR2Q2dGZVTmhyQW5XSWJUcWVKOGdueElPVFgwZTVlYVovNFdjU0dT?= =?utf-8?B?L1N6RmVqWFNTakNoNEtuazkwTXo3cEcxNlJpWWxBYTMvYmpnNWpmdUNsT3ZW?= =?utf-8?B?cGJDS241cmV6bzBTQ3Mrb1RPZkRpU0ZLNEJUVDcrdVF5YjhiUjVSQlRUWVFR?= =?utf-8?B?VzUra2o3UHpCYTJJWm1aUzkzSGUvSjNTc3QwRkM4d0ZwRWR6ekhYdzBkMjMr?= =?utf-8?B?SDE2aFdDV1M1M05IVVo5Zk5QM0NWb0kvdkkzaXF1SkZmRFhydFluaG9YMklY?= =?utf-8?B?ak00ZDhpOVVLZ2RlMjdlcUVpWnBIVnE2S292UG5TVTVtbm92T3VHODJwMTVV?= =?utf-8?B?QUVJN1FWcjVGV0c0QU9tdWZnQTExSDY0N0pTRndoTkMrSnRhTU5Dc3ZEZ1FN?= =?utf-8?B?MktIL0pDMERZeHBYL1pKbnlxNTlnVmFhTlZvUzlNSUpOYU9odTMxLzhqcXBJ?= =?utf-8?B?c3EzTEpaNDJ4UGVXOVE5SWFFZ3MyMStSWDFCVDYxWlpReU01bittZE83eStz?= =?utf-8?B?QUYxMkdEOFF4QjRQTkphbXlUekQ5ZmhlZTFUTUc2a0dmc1F3K3RneUhqVDZp?= =?utf-8?B?cThWL2pxOXB0bEN6OWE4VE5LenA3S1pYbUhBSWtpYWk1aHMxcy91Qi9jZEZt?= =?utf-8?B?SGMvdDR2SGlYaGx0Wk1OUVhOcDhpTk5SVG1IQ0RjMWdHenBHMWt1dXh1d21a?= =?utf-8?B?TDB6bml0SDQ4b2dKRVFObGo2OUUvbVRvRXNnc3lmNGhGdU5OaVZrQWMyOHFn?= =?utf-8?B?dVVHckYzdlZZRkxzbmpEUFdFMWdYeG90eEhCQTJSKzdsL3ZQZldpRG12OWQr?= =?utf-8?B?NTI2TTNCSlFyeHh2MWVNTWZNZlBjVU91c3NMNlFyL0xIdnAxMUo1R2IrRnQz?= =?utf-8?B?b1ZTVmYzKy9OL204RC9tbUF2bG5mSWdHa0JSL1RnN25TbHFRZFFmRGlVUjlY?= =?utf-8?B?M0I3RlpnQjArV1Q5RFZCS0h5bGFtSVdUOWV3S1QyZyswOUZRV2Myb2I4Q2ps?= =?utf-8?B?WW1sNjhSQ2xSeDZoeXc4K2pXdE95TDhoUVErTEJZT0NMR0d6eWp1SHJvUWxk?= =?utf-8?B?VDBkZ3p1Q1N1NzlXQTYyN0IwZForaVh0eUZBbXk0NnVBbm9vQmV5bnVOYVd6?= =?utf-8?B?b1IranBTWEJiTVUrSXhoOXN5eW1ERUhWL3ZTWkVaUndjOWhpaHAwZjZjazVP?= =?utf-8?B?SnBnaWtqcGZaTTRndzBmb2IyUE1tYnBNUGc0cGh5L1RFenV2cVpySW1UM1Ay?= =?utf-8?B?Zjh0V05JK1I3cllDS3NmaWRvL0g0OENkVllVcDNuRWhDaWRQMXZ1ZDRtV2ly?= =?utf-8?B?VytQWXJoYmxCZU1kTm9wSmZkeFhNOW0zMEQ3cnljazZrQnV6czRicDNFcGRt?= =?utf-8?B?N3hhYW4wckNqWFB2Q29uNEFtNk9uSU5hbjJGRG1tNUVOVWpHSkJpZGVUMTRE?= =?utf-8?Q?BZmRUPIBhZLP+HoGA7eISzfU6kNano7vxfvxy8q?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230032)(376006)(366008)(1800799016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUFYQ3JTTURoOFZLbkZPVWtpS1VVS1NWeno3NUNHZ2pvRzE1cEt2QVlzS0ZH?= =?utf-8?B?U3N6YzN4MVNSZE8zc3p1eHVyVjhUdmozS24wQmFqSTlnbTdUSXk2VEh4T3g0?= =?utf-8?B?Y0QzU2tGL0l5cWRiYWRnMnJQaVhzMFJQUWJKTzlLa29xNlRFVXZxN3lWK1BR?= =?utf-8?B?SXlyZEZjWUgvMGJRVldIT1N3U2VmdVEzSUpyc3lQTExZeEtjNm01bjA0c3gr?= =?utf-8?B?UCtnSThTbFI1ZjA5Z0VlTjRROVNUWU5WVExkOGNDTmJOdzY0RUJBbUJuZFlF?= =?utf-8?B?WnV3SU5XS2tzaDRjR1BUSTZQOVBlMlJnM2lMVUI2VXB4YjV4UGpmS040Z2hs?= =?utf-8?B?WGt6Z2N4NXRZWHMvZFFnMU1UaGJDU0UrNVFEOEcwZ2gvQVMxcjVFd2Q5QVpa?= =?utf-8?B?NkU0UFVKNGRGaXZjK0Y1cU14WDh5TE40N2pGWlJVeXNpc25tRXdMNkdiNHNt?= =?utf-8?B?NG1ROTVkMlloSTZqMXFneEhFeXBPaytjMkNIV0U3ZlRTSTJ0aFh2Si9BRlZX?= =?utf-8?B?YWN4d2tuelNtY3hlWFp6OFZienV0aXZ4VUJqME9EbnNVRnRsempuSEE3L3Ri?= =?utf-8?B?U1NIWEF1V0kveWdoaklqUmNMUTRzNGxFY01FdXZOaTRBN2pnMy9IYVNGckNS?= =?utf-8?B?UDRzbldPWVhibXorcXJLQW1mbnJmUTdyejJBZXYrNks4UEdkYUNYL3VoWW1U?= =?utf-8?B?RGhFcVA5Nmlkb05qenVCU0NTdlN6Z1NrNzUzenpEUFY5cGIxNmQ2K01oa1Mv?= =?utf-8?B?RXVBc0UwMEZzRWdrQmF3dlljTG9laE9ab3hVWmZLODhjUmRVdGFrWlhOTFBo?= =?utf-8?B?ak03R1c2Tm12cUN4WVRTMndVemtGcmR0eWRFUjcvbGhvSG1mcVRobjFtdFFW?= =?utf-8?B?eU5JRWhRdXpmVTduSSs4YzZ0clFTKzBYYlFzZER2TDVRT3EyV3hnMzBUTU9q?= =?utf-8?B?L0FpYmxpeUIwZ0V3T0dENHArY00yc3d3OXdQVGw3RXZCdEcrbEt5dlpScm8w?= =?utf-8?B?cTBCUW9Jb1REOTJXOGp1SW9Xd1ZoWTNjVWlwdjR5STFnQ3BraUNYQkczUWVM?= =?utf-8?B?UHJ5bGFWQzlDUEdjRHk4eERPM2JjQzZWTDhqd09XNmRiQnJRSi83YkVMd3pk?= =?utf-8?B?UXBpSWNEVGk5aGF0YmhFcjNDUDF3VlQzQzlnUmRyZ3czZjVzWVlNdHlSSktB?= =?utf-8?B?RmE4WjR6QWl5SS9lQWZvUUVFS1gzaEVnWlRFdmhVNjcrMWIzVFNkNHNRMFBq?= =?utf-8?B?TUhxM0hnNEtnS3J6cy9CK1VGT1ZLMTcyTGNmdElSQ1RnR3pGVktvTjVEVlNz?= =?utf-8?B?QzIwQXVNdlAyL3BuYlhpeERZWHB3eU5tVHF0VHdqd3NQRWtMVjRsMTB0Snkz?= =?utf-8?B?aGNFTHlBWHp4YWdja3E1Sm5HeGhtZzFGQWNzRFl1S05DL0dBNHo0alFVQTdW?= =?utf-8?B?WEVJRm55TEJ0WmYzb2V0Nk1oZUJZQUtCUFpESE42WWFiK3BiOFkrR2hDREla?= =?utf-8?B?WW4xMnJKWDd1SlFvV24wL0ZaOUgwdExEL3JWUjhLS2ZUa3BLY0preTZsMEpj?= =?utf-8?B?d0dPWHhzM1U4aVlQS3dnN1RwSXhoYURjaGN6d3B0YUVybUVzMXR5d1V4eEJ0?= =?utf-8?B?YUl3TTVqRGRwMTJ4MHdxMUI4TkVEVVhIWjRZam1oS3lSYUttcTJ2N29VNlNN?= =?utf-8?B?RkhJQ2kwNW5GTjcydTdobVludUNlakthTnlMWEFZMW5KcmlIeHRjdnhYN1NC?= =?utf-8?B?cVJUanVnWUlPekl1VXhRVnpkNzhOMHdaM3VyeVZPVTJMeDR0clRSUmQxR1Ny?= =?utf-8?B?V3V4cWZmSzBpUDFIbnBobUthNDF5dDlzSytoN0dJNGJXWklJbDFvZVM4Q1Rl?= =?utf-8?B?VkRWN2tOdlVrWTZqTDlzUFBOemtVa29uYTNza2c2Tnp3UU1kR21FWmszcWhF?= =?utf-8?B?bDNHNFF1STJOYnNZM002SysxV0dLYkVDQ0VPVGR4QmNPK0twVllzODJpaW9u?= =?utf-8?B?VlpQVmgyL1p3TTd3N2tISVdTNm1EYXNpN0YwelVkVDZCTnl1cnA3am9EL1Fl?= =?utf-8?B?MXMzU0o1NkIvSCtVYjN3Vy9ZYXMwNnJUOUxQSGxpYVpGUk9UeXEzRk1oZ2J0?= =?utf-8?Q?TGxsojvIqoRum6q96Ug4JB4pR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e79becc-f3aa-4211-b39c-08dc8a7cb9b0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 01:12:27.7519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a//Nkm768YJUmRIu/QNetav3tfCqU/1xBi6itPaovhAhCCEAEQbbxOtNNpalfjbq X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6749 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] > > Here VLA is used as a temp array for mbufs that will be used as a split > RX data buffers. > As at any given time only one thread can do RX from particular queue, > at rx_queue_setup() we can allocate extra space for that array, and then > safely use it at RX fast-path. > Is there a reason to allocate extra space in sw_ring and used some part of it for split buffer, instead of allocating a new buffer for it? > Signed-off-by: Konstantin Ananyev > --- > drivers/net/ice/ice_rxtx.c | 18 ++++++++++++------ > drivers/net/ice/ice_rxtx.h | 2 ++ > 2 files changed, 14 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c > index 95a2db3432..6395a3b50a 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -1171,7 +1171,7 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, > struct ice_vsi *vsi = pf->main_vsi; > struct ice_rx_queue *rxq; > const struct rte_memzone *rz; > - uint32_t ring_size; > + uint32_t ring_size, tlen; > uint16_t len; > int use_def_burst_func = 1; > uint64_t offloads; > @@ -1279,9 +1279,14 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, > /* always reserve more for bulk alloc */ > len = (uint16_t)(nb_desc + ICE_RX_MAX_BURST); > > + /* allocate extra entries for SW split buffer */ > + tlen = ((rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0) ? > + rxq->rx_free_thresh : 0; > + tlen += len; > + > /* Allocate the software ring. */ > rxq->sw_ring = rte_zmalloc_socket(NULL, > - sizeof(struct ice_rx_entry) * len, > + sizeof(struct ice_rx_entry) * tlen, > RTE_CACHE_LINE_SIZE, > socket_id); > if (!rxq->sw_ring) { > @@ -1290,6 +1295,8 @@ ice_rx_queue_setup(struct rte_eth_dev *dev, > return -ENOMEM; > } > > + rxq->sw_split_buf = (tlen == len) ? NULL : rxq->sw_ring + len; > + > ice_reset_rx_queue(rxq); > rxq->q_set = true; > dev->data->rx_queues[queue_idx] = rxq; > @@ -1868,7 +1875,6 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq) > uint64_t dma_addr; > int diag, diag_pay; > uint64_t pay_addr; > - struct rte_mbuf *mbufs_pay[rxq->rx_free_thresh]; > > /* Allocate buffers in bulk */ > alloc_idx = (uint16_t)(rxq->rx_free_trigger - > @@ -1883,7 +1889,7 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq) > > if (rxq->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) { > diag_pay = rte_mempool_get_bulk(rxq->rxseg[1].mp, > - (void *)mbufs_pay, rxq->rx_free_thresh); > + (void *)rxq->sw_split_buf, rxq->rx_free_thresh); > Are we allowed to call 'rte_mempool_get_bulk()' with NULL object_table, as 'rxq->sw_split_buf' can be NULL? Perhaps can allocate 'rxq->sw_split_buf' even buffer split offload is not enabled?