From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 46E0B3DC for ; Tue, 7 Mar 2017 13:17:51 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 07 Mar 2017 04:17:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,258,1484035200"; d="scan'208";a="233212472" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.191.241]) ([10.254.191.241]) by fmsmga004.fm.intel.com with ESMTP; 07 Mar 2017 04:17:49 -0800 To: Shrikrishna Khare References: <1488059989-6930-1-git-send-email-skhare@vmware.com> <8019d737-e839-b5e9-53ef-3717db6ab5b3@intel.com> Cc: Shrikrishna Khare , yongwang@vmware.com, dev@dpdk.org From: Ferruh Yigit Message-ID: <9b2a52c9-beaa-5ca3-839e-b000ec09f3c5@intel.com> Date: Tue, 7 Mar 2017 12:17:48 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/7] vmxnet3: upgrade to version 3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 12:17:52 -0000 On 3/6/2017 5:25 PM, Shrikrishna Khare wrote: > > > On Fri, 3 Mar 2017, Ferruh Yigit wrote: > >>> Shrikrishna Khare (7): >>> vmxnet3: prepare for version 3 changes >>> vmxnet3: introduce generalized command interface to configure the >>> device >>> vmxnet3: allow variable length transmit data ring buffer >>> vmxnet3: add receive data ring support >>> vmxnet3: add reserved version 3 command >>> vmxnet3: introduce command to register memory region >>> vmxnet3: update to version 3 >> >> Hi Shrikrishna, >> >> Can you please update release notes with this change with one or two >> sentences in next version of the patchset? >> >> Also there are helper scripts in dpdk: >> - dpdk/devtools/check-git-log.sh to check patch titles >> - dpdk/devtools/checkpatches.sh (a wrapper to Linux checkpatch.pl) >> >> Both are generating some warnings, can you please check them? >> >> For checkpatches script, it is free to ignore CAMELCASE & >> LONG_LINE_STRING warnings. > > Hi Ferruh, > > Thank you for the review comments. I have addressed them all and sent v2 > patches for review. > > In addition to CAMELCASE, there are few LEADING_SPACE warnings that I > have not addressed. This is an existing problem with all the vmxnet3 > headers and only fixing it for the lines added by this patch series will > be odd. Hope that is OK. I agree, better to keep existing style. > Perhaps a separate patch can fix these style > issues in vmxnet3 header files all at once. That would be nice, thank you. > > Thanks, > Shri <...>