From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: Don't allow umem sharing for xsks with same netdev, qid
Date: Tue, 13 Oct 2020 13:37:48 +0000 [thread overview]
Message-ID: <9b3473fad0514661b2f2816a28d61cf8@intel.com> (raw)
In-Reply-To: <504881d7-0ecb-70e4-a063-1f56d3fe4653@intel.com>
> On 10/8/2020 10:17 AM, Ciara Loftus wrote:
> > Supporting this would require locks, which would impact the performance
> of
> > the more typical cases - xsks with different qids and netdevs.
> >
> > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> > Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM")
>
> Hi Ciara,
>
> 'check-git-log.sh' script is giving some errors, can you please fix them, you
> can run script as: "./devtools/check-git-log.sh -n1"
>
> And can you please give some sample in the description what is not
> supported now?
>
> Also does this require any documentation update, as kind of limitation or
> known
> issues?
Thanks for the suggestions Ferruh, all valid. I've implemented them in the v2.
Ciara
next prev parent reply other threads:[~2020-10-13 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 9:17 Ciara Loftus
2020-10-08 11:55 ` Ferruh Yigit
2020-10-13 8:52 ` Ferruh Yigit
2020-10-13 13:37 ` Loftus, Ciara [this message]
2020-10-13 13:10 ` [dpdk-dev] [PATCH v2] net/af_xdp: don't allow umem sharing for xsks with same ctx Ciara Loftus
2020-10-13 15:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b3473fad0514661b2f2816a28d61cf8@intel.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).