From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83A0BA04C7; Tue, 15 Sep 2020 14:04:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6409D1C0C0; Tue, 15 Sep 2020 14:04:40 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 039F7DE0; Tue, 15 Sep 2020 14:04:38 +0200 (CEST) IronPort-SDR: wxAoTycl+6XzxYUsn6Y8SCSs9JTnTxO1qCkhJM3oBvch7dfuhizQ+oqxO8xUVwQI6KzC86NVFt 6D5eyb/Ffc+A== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="138748402" X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="138748402" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 05:04:36 -0700 IronPort-SDR: JmU1eUryfrKjIuMB4Mt0ACP0luhehbfqvF5le6X3DExLlMyXcYUhjGRTxOS2fM7qXgoazyidk6 TqcbsatiUxfw== X-IronPort-AV: E=Sophos;i="5.76,429,1592895600"; d="scan'208";a="482748572" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.215.1]) ([10.213.215.1]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2020 05:04:34 -0700 To: "Ling, WeiX" , "Jiang, YuX" , "Richardson, Bruce" , "dev@dpdk.org" Cc: "stable@dpdk.org" References: <20200902155611.654185-1-bruce.richardson@intel.com> <20200902162427.668466-1-bruce.richardson@intel.com> <7b12c900017e4d6da77ec225bb897750@intel.com> <30714b80c3d34c79b91727cdc2403895@intel.com> From: Ferruh Yigit Message-ID: <9b4f4bae-789d-86da-c4e8-4be51bb64654@intel.com> Date: Tue, 15 Sep 2020 13:04:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <30714b80c3d34c79b91727cdc2403895@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix name of bitrate library in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2020 7:21 AM, Ling, WeiX wrote: <...> > > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, September 3, 2020 12:24 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix name of bitrate library in meson build > > The bitrate library in DPDK is actually in a "bitratestats" directory, so that is used by meson for the macro and library name. Therefore, we need to update references to RTE_LIBRTE_BITRATE to RTE_LIBRTE_BITRATESTATS in testpmd to have it found. Rather than supporting both defines, since make is being removed, we can just replace all instances of the former define with the latter. > > To ensure testpmd links ok when this is done, we also need to add bitratestats to the list of library dependencies. > > Fixes: 5b9656b157d3 ("lib: build with meson") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > > Tested-by: Ling Wei > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.